You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by at...@apache.org on 2012/05/22 09:50:01 UTC

svn commit: r1341338 - in /hadoop/common/trunk/hadoop-common-project/hadoop-common/src: main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemDelegationTokenSupport.java

Author: atm
Date: Tue May 22 07:50:00 2012
New Revision: 1341338

URL: http://svn.apache.org/viewvc?rev=1341338&view=rev
Log:
Amend HADOOP-8408 per Daryn's post-commit feedback.

Modified:
    hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
    hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemDelegationTokenSupport.java

Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java?rev=1341338&r1=1341337&r2=1341338&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java (original)
+++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java Tue May 22 07:50:00 2012
@@ -236,7 +236,7 @@ public class ViewFileSystem extends File
   
   @Override
   public String getCanonicalServiceName() {
-    return getUri().getHost();
+    return null;
   }
 
   @Override

Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemDelegationTokenSupport.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemDelegationTokenSupport.java?rev=1341338&r1=1341337&r2=1341338&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemDelegationTokenSupport.java (original)
+++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemDelegationTokenSupport.java Tue May 22 07:50:00 2012
@@ -31,15 +31,15 @@ import org.junit.Test;
 /**
  * Test ViewFileSystem's support for having delegation tokens fetched and cached
  * for the file system.
+ * 
+ * Currently this class just ensures that getCanonicalServiceName() always
+ * returns <code>null</code> for ViewFileSystem instances.
  */
 public class TestViewFileSystemDelegationTokenSupport {
   
   private static final String MOUNT_TABLE_NAME = "vfs-cluster";
 
   /**
-   * Ensure that a canonical service name can be determined for ViewFileSystem
-   * instances configured with a non-default mount table name.
-   * 
    * Regression test for HADOOP-8408.
    */
   @Test
@@ -53,8 +53,7 @@ public class TestViewFileSystemDelegatio
         "://" + MOUNT_TABLE_NAME), conf);
     
     String serviceName = viewFs.getCanonicalServiceName();
-    assertNotNull(serviceName);
-    assertEquals(MOUNT_TABLE_NAME, serviceName);
+    assertNull(serviceName);
   }
   
   @Test