You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/04/15 03:13:59 UTC

[GitHub] [ozone] JacksonYao287 opened a new pull request #2157: HDDS-5107. Add trace for containerReport

JacksonYao287 opened a new pull request #2157:
URL: https://github.com/apache/ozone/pull/2157


   ## What changes were proposed in this pull request?
   
   Add trace for containerReport to help debugging SCM OOM
   
   ## What is the link to the Apache JIRA
   
   HDDS-5107
   
   ## How was this patch tested?
   
   no need to test
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] JacksonYao287 closed pull request #2157: HDDS-5107. Add trace for containerReport

Posted by GitBox <gi...@apache.org>.
JacksonYao287 closed pull request #2157:
URL: https://github.com/apache/ozone/pull/2157


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] GlenGeng commented on a change in pull request #2157: HDDS-5107. Add trace for containerReport

Posted by GitBox <gi...@apache.org>.
GlenGeng commented on a change in pull request #2157:
URL: https://github.com/apache/ozone/pull/2157#discussion_r613731514



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerReportHandler.java
##########
@@ -118,6 +121,9 @@ public void onMessage(final ContainerReportFromDatanode reportFromDatanode,
     try {
       final List<ContainerReplicaProto> replicas =
           containerReport.getReportsList();
+      LOG.trace("begin processing ContainerReport of {} at {}," +

Review comment:
       Please use `LOG.info` instead.

##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerReportHandler.java
##########
@@ -144,7 +150,9 @@ public void onMessage(final ContainerReportFromDatanode reportFromDatanode,
       LOG.error("Received container report from unknown datanode {}.",
           datanodeDetails, ex);
     }
-
+    LOG.trace("complete processing ContainerReport of {} at {}" +
+        "and processedContainerReportCount is {}", datanodeDetails.getUuid(),
+        Time.now(), processedContaienReportCount.addAndGet(1L));

Review comment:
       Please calculate the latency and add to the `LOF.info` as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] JacksonYao287 commented on a change in pull request #2157: HDDS-5107. Add trace for containerReport

Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on a change in pull request #2157:
URL: https://github.com/apache/ozone/pull/2157#discussion_r613739231



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerReportHandler.java
##########
@@ -118,6 +121,9 @@ public void onMessage(final ContainerReportFromDatanode reportFromDatanode,
     try {
       final List<ContainerReplicaProto> replicas =
           containerReport.getReportsList();
+      LOG.trace("begin processing ContainerReport of {} at {}," +

Review comment:
       ok, and a process latency is added too




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org