You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "hxmhlt (GitHub)" <gi...@apache.org> on 2020/01/26 15:52:17 UTC
[GitHub] [dubbo-go] hxmhlt opened pull request #343: Optimize zk
ListenServiceEvent listener
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
[ Full content available at: https://github.com/apache/dubbo-go/pull/343 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on pull request #343: Optimize zk
ListenServiceEvent listener
Posted by "zouyx (GitHub)" <gi...@apache.org>.
as above
[ Full content available at: https://github.com/apache/dubbo-go/pull/343 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on issue #343: Optimize zk
ListenServiceEvent listener
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
LGTM
[ Full content available at: https://github.com/apache/dubbo-go/pull/343 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #343: Optimize zk
ListenServiceEvent listener
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=h1) Report
> Merging [#343](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/6809d8d21e1b6d1caa0638aa9e233a0f0751bc11?src=pr&el=desc) will **increase** coverage by `0.21%`.
> The diff coverage is `62.1%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #343 +/- ##
===========================================
+ Coverage 66.14% 66.35% +0.21%
===========================================
Files 96 123 +27
Lines 6462 7596 +1134
===========================================
+ Hits 4274 5040 +766
- Misses 1742 2067 +325
- Partials 446 489 +43
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/generic\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y29uZmlnL2dlbmVyaWNfc2VydmljZS5nbw==) | `0% <ø> (ø)` | :arrow_up: |
| [cluster/directory/static\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3Rvcnkvc3RhdGljX2RpcmVjdG9yeS5nbw==) | `90.47% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/failfast\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGZhc3RfY2x1c3Rlci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/loadbalance/random.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yYW5kb20uZ28=) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/registry\_aware\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvcmVnaXN0cnlfYXdhcmVfY2x1c3Rlci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/failover\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbG92ZXJfY2x1c3Rlci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [common/logger/logging.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y29tbW9uL2xvZ2dlci9sb2dnaW5nLmdv) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/broadcast\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYnJvYWRjYXN0X2NsdXN0ZXIuZ28=) | `100% <ø> (ø)` | :arrow_up: |
| [config/mock\_rpcservice.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y29uZmlnL21vY2tfcnBjc2VydmljZS5nbw==) | `33.33% <ø> (ø)` | :arrow_up: |
| [config/config\_utils.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ191dGlscy5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| ... and [140 more](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=footer). Last update [6809d8d...13ddacc](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/343 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #343: Optimize zk
ListenServiceEvent listener
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=h1) Report
> Merging [#343](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/6809d8d21e1b6d1caa0638aa9e233a0f0751bc11?src=pr&el=desc) will **increase** coverage by `0.21%`.
> The diff coverage is `62.1%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #343 +/- ##
===========================================
+ Coverage 66.14% 66.35% +0.21%
===========================================
Files 96 123 +27
Lines 6462 7596 +1134
===========================================
+ Hits 4274 5040 +766
- Misses 1742 2067 +325
- Partials 446 489 +43
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/generic\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y29uZmlnL2dlbmVyaWNfc2VydmljZS5nbw==) | `0% <ø> (ø)` | :arrow_up: |
| [cluster/directory/static\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3Rvcnkvc3RhdGljX2RpcmVjdG9yeS5nbw==) | `90.47% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/failfast\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGZhc3RfY2x1c3Rlci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/loadbalance/random.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yYW5kb20uZ28=) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/registry\_aware\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvcmVnaXN0cnlfYXdhcmVfY2x1c3Rlci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/failover\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbG92ZXJfY2x1c3Rlci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [common/logger/logging.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y29tbW9uL2xvZ2dlci9sb2dnaW5nLmdv) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/broadcast\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYnJvYWRjYXN0X2NsdXN0ZXIuZ28=) | `100% <ø> (ø)` | :arrow_up: |
| [config/mock\_rpcservice.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y29uZmlnL21vY2tfcnBjc2VydmljZS5nbw==) | `33.33% <ø> (ø)` | :arrow_up: |
| [config/config\_utils.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ191dGlscy5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| ... and [140 more](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=footer). Last update [6809d8d...ade85d6](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/343 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on pull request #343: Optimize zk
ListenServiceEvent listener
Posted by "zouyx (GitHub)" <gi...@apache.org>.
@AlexStocks ok.
[ Full content available at: https://github.com/apache/dubbo-go/pull/343 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks closed pull request #343: Optimize zk
ListenServiceEvent listener
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
[ pull request closed by AlexStocks ]
[ Full content available at: https://github.com/apache/dubbo-go/pull/343 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #343:
Optimize zk ListenServiceEvent listener
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
@zouyx , @hxmhlt used the errNilChildren later. so there is no need to add the zkPath in the error. maybe an error log is better.
[ Full content available at: https://github.com/apache/dubbo-go/pull/343 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #343: Optimize zk
ListenServiceEvent listener
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=h1) Report
> Merging [#343](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/6809d8d21e1b6d1caa0638aa9e233a0f0751bc11?src=pr&el=desc) will **increase** coverage by `0.21%`.
> The diff coverage is `62.1%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #343 +/- ##
===========================================
+ Coverage 66.14% 66.35% +0.21%
===========================================
Files 96 123 +27
Lines 6462 7596 +1134
===========================================
+ Hits 4274 5040 +766
- Misses 1742 2067 +325
- Partials 446 489 +43
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/generic\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y29uZmlnL2dlbmVyaWNfc2VydmljZS5nbw==) | `0% <ø> (ø)` | :arrow_up: |
| [cluster/directory/static\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3Rvcnkvc3RhdGljX2RpcmVjdG9yeS5nbw==) | `90.47% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/failfast\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGZhc3RfY2x1c3Rlci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/loadbalance/random.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yYW5kb20uZ28=) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/registry\_aware\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvcmVnaXN0cnlfYXdhcmVfY2x1c3Rlci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/failover\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbG92ZXJfY2x1c3Rlci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [common/logger/logging.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y29tbW9uL2xvZ2dlci9sb2dnaW5nLmdv) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/broadcast\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYnJvYWRjYXN0X2NsdXN0ZXIuZ28=) | `100% <ø> (ø)` | :arrow_up: |
| [config/mock\_rpcservice.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y29uZmlnL21vY2tfcnBjc2VydmljZS5nbw==) | `33.33% <ø> (ø)` | :arrow_up: |
| [config/config\_utils.go](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ191dGlscy5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| ... and [140 more](https://codecov.io/gh/apache/dubbo-go/pull/343/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=footer). Last update [6809d8d...0d5e447](https://codecov.io/gh/apache/dubbo-go/pull/343?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/343 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org