You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by lq...@apache.org on 2017/01/26 08:12:35 UTC
svn commit: r1780338 -
/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/
Author: lquack
Date: Thu Jan 26 08:12:34 2017
New Revision: 1780338
URL: http://svn.apache.org/viewvc?rev=1780338&view=rev
Log:
QPID-7586: [Java Broker] [AMQP 1.0] add @Override and final
Modified:
qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/AbstractDescribedTypeWriter.java
qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/BooleanWriter.java
qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/ByteWriter.java
qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/CompoundWriter.java
qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/DelegatingValueWriter.java
qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedEightWriter.java
qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedFourWriter.java
qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedOneWriter.java
qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedSixteenWriter.java
qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedTwoWriter.java
qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/IntegerWriter.java
qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/ListWriter.java
qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/LongWriter.java
qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/NullWriter.java
qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/SimpleVariableWidthWriter.java
qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/UnsignedByteWriter.java
qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/UnsignedIntegerWriter.java
qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/UnsignedLongWriter.java
qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/VariableWidthWriter.java
Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/AbstractDescribedTypeWriter.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/AbstractDescribedTypeWriter.java?rev=1780338&r1=1780337&r2=1780338&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/AbstractDescribedTypeWriter.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/AbstractDescribedTypeWriter.java Thu Jan 26 08:12:34 2017
@@ -36,17 +36,16 @@ public abstract class AbstractDescribedT
_describedWriter = describedWriter;
}
-
- public void writeToBuffer(QpidByteBuffer buffer)
+ @Override
+ public final void writeToBuffer(QpidByteBuffer buffer)
{
buffer.put(DESCRIBED_TYPE);
_descriptorWriter.writeToBuffer(buffer);
_describedWriter.writeToBuffer(buffer);
-
}
@Override
- public int getEncodedSize()
+ public final int getEncodedSize()
{
return 1 + _descriptorWriter.getEncodedSize() + _describedWriter.getEncodedSize();
}
Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/BooleanWriter.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/BooleanWriter.java?rev=1780338&r1=1780337&r2=1780338&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/BooleanWriter.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/BooleanWriter.java Thu Jan 26 08:12:34 2017
@@ -42,6 +42,7 @@ public class BooleanWriter implements Va
return 1;
}
+ @Override
public void writeToBuffer(QpidByteBuffer buffer)
{
buffer.put(_value ? (byte)0x41 : (byte)0x42);
Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/ByteWriter.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/ByteWriter.java?rev=1780338&r1=1780337&r2=1780338&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/ByteWriter.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/ByteWriter.java Thu Jan 26 08:12:34 2017
@@ -42,6 +42,7 @@ public class ByteWriter implements Value
return 2;
}
+ @Override
public void writeToBuffer(QpidByteBuffer buffer)
{
Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/CompoundWriter.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/CompoundWriter.java?rev=1780338&r1=1780337&r2=1780338&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/CompoundWriter.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/CompoundWriter.java Thu Jan 26 08:12:34 2017
@@ -40,7 +40,7 @@ public abstract class CompoundWriter<V>
@Override
- public int getEncodedSize()
+ public final int getEncodedSize()
{
int encodedSize = 1; // byte for the count
if(_length == -1)
@@ -71,7 +71,7 @@ public abstract class CompoundWriter<V>
}
@Override
- public void writeToBuffer(QpidByteBuffer buffer)
+ public final void writeToBuffer(QpidByteBuffer buffer)
{
if(_length == -1)
{
Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/DelegatingValueWriter.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/DelegatingValueWriter.java?rev=1780338&r1=1780337&r2=1780338&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/DelegatingValueWriter.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/DelegatingValueWriter.java Thu Jan 26 08:12:34 2017
@@ -39,13 +39,14 @@ public abstract class DelegatingValueWri
setValue(object);
}
- public void writeToBuffer(final QpidByteBuffer buffer)
+ @Override
+ public final void writeToBuffer(final QpidByteBuffer buffer)
{
_delegate.writeToBuffer(buffer);
}
@Override
- public int getEncodedSize()
+ public final int getEncodedSize()
{
return _delegate.getEncodedSize();
}
Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedEightWriter.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedEightWriter.java?rev=1780338&r1=1780337&r2=1780338&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedEightWriter.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedEightWriter.java Thu Jan 26 08:12:34 2017
@@ -32,6 +32,7 @@ public abstract class FixedEightWriter<T
_value = value;
}
+ @Override
public final void writeToBuffer(QpidByteBuffer buffer)
{
buffer.put(getFormatCode());
@@ -39,7 +40,7 @@ public abstract class FixedEightWriter<T
}
@Override
- public int getEncodedSize()
+ public final int getEncodedSize()
{
return 9;
}
Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedFourWriter.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedFourWriter.java?rev=1780338&r1=1780337&r2=1780338&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedFourWriter.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedFourWriter.java Thu Jan 26 08:12:34 2017
@@ -33,6 +33,7 @@ public abstract class FixedFourWriter<T
_value = object;
}
+ @Override
public final void writeToBuffer(QpidByteBuffer buffer)
{
buffer.put(getFormatCode());
@@ -40,7 +41,7 @@ public abstract class FixedFourWriter<T
}
@Override
- public int getEncodedSize()
+ public final int getEncodedSize()
{
return 5;
}
Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedOneWriter.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedOneWriter.java?rev=1780338&r1=1780337&r2=1780338&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedOneWriter.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedOneWriter.java Thu Jan 26 08:12:34 2017
@@ -31,14 +31,15 @@ public abstract class FixedOneWriter<T>
_value = value;
}
- public void writeToBuffer(QpidByteBuffer buffer)
+ @Override
+ public final void writeToBuffer(QpidByteBuffer buffer)
{
buffer.put(getFormatCode());
buffer.put(_value);
}
@Override
- public int getEncodedSize()
+ public final int getEncodedSize()
{
return 2;
}
Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedSixteenWriter.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedSixteenWriter.java?rev=1780338&r1=1780337&r2=1780338&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedSixteenWriter.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedSixteenWriter.java Thu Jan 26 08:12:34 2017
@@ -37,8 +37,7 @@ public abstract class FixedSixteenWriter
setValue(object);
}
-
-
+ @Override
public final void writeToBuffer(QpidByteBuffer buffer)
{
buffer.put(getFormatCode());
@@ -47,7 +46,7 @@ public abstract class FixedSixteenWriter
}
@Override
- public int getEncodedSize()
+ public final int getEncodedSize()
{
return 17;
}
Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedTwoWriter.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedTwoWriter.java?rev=1780338&r1=1780337&r2=1780338&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedTwoWriter.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/FixedTwoWriter.java Thu Jan 26 08:12:34 2017
@@ -36,14 +36,15 @@ public abstract class FixedTwoWriter <T
setValue(object);
}
- public void writeToBuffer(QpidByteBuffer buffer)
+ @Override
+ public final void writeToBuffer(QpidByteBuffer buffer)
{
buffer.put(getFormatCode());
buffer.putShort(_value);
}
@Override
- public int getEncodedSize()
+ public final int getEncodedSize()
{
return 3;
}
Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/IntegerWriter.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/IntegerWriter.java?rev=1780338&r1=1780337&r2=1780338&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/IntegerWriter.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/IntegerWriter.java Thu Jan 26 08:12:34 2017
@@ -72,7 +72,8 @@ public class IntegerWriter
super(value.byteValue());
}
- @Override protected byte getFormatCode()
+ @Override
+ protected byte getFormatCode()
{
return ONE_BYTE_FORMAT_CODE;
}
Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/ListWriter.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/ListWriter.java?rev=1780338&r1=1780337&r2=1780338&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/ListWriter.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/ListWriter.java Thu Jan 26 08:12:34 2017
@@ -77,6 +77,7 @@ public class ListWriter
return 1;
}
+ @Override
public void writeToBuffer(QpidByteBuffer buffer)
{
buffer.put(ZERO_BYTE_FORMAT_CODE);
Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/LongWriter.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/LongWriter.java?rev=1780338&r1=1780337&r2=1780338&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/LongWriter.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/LongWriter.java Thu Jan 26 08:12:34 2017
@@ -72,7 +72,8 @@ public class LongWriter
super(value.byteValue());
}
- @Override protected byte getFormatCode()
+ @Override
+ protected byte getFormatCode()
{
return ONE_BYTE_FORMAT_CODE;
}
Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/NullWriter.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/NullWriter.java?rev=1780338&r1=1780337&r2=1780338&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/NullWriter.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/NullWriter.java Thu Jan 26 08:12:34 2017
@@ -33,6 +33,7 @@ public class NullWriter implements Value
return 1;
}
+ @Override
public void writeToBuffer(QpidByteBuffer buffer)
{
Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/SimpleVariableWidthWriter.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/SimpleVariableWidthWriter.java?rev=1780338&r1=1780337&r2=1780338&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/SimpleVariableWidthWriter.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/SimpleVariableWidthWriter.java Thu Jan 26 08:12:34 2017
@@ -33,6 +33,7 @@ public abstract class SimpleVariableWidt
_buf = value;
}
+ @Override
protected final void writeBytes(QpidByteBuffer buf, int offset, int length)
{
buf.put(_buf, offset, length);
Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/UnsignedByteWriter.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/UnsignedByteWriter.java?rev=1780338&r1=1780337&r2=1780338&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/UnsignedByteWriter.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/UnsignedByteWriter.java Thu Jan 26 08:12:34 2017
@@ -22,38 +22,18 @@
package org.apache.qpid.server.protocol.v1_0.codec;
import org.apache.qpid.server.protocol.v1_0.type.UnsignedByte;
-import org.apache.qpid.bytebuffer.QpidByteBuffer;
-public class UnsignedByteWriter implements ValueWriter<UnsignedByte>
+public class UnsignedByteWriter extends FixedOneWriter<UnsignedByte>
{
- private byte _value;
-
- public UnsignedByteWriter()
- {
- }
-
-
- public UnsignedByteWriter(UnsignedByte value)
+ public UnsignedByteWriter(final UnsignedByte value)
{
- setValue(value);
+ super(value.byteValue());
}
-
@Override
- public int getEncodedSize()
- {
- return 2;
- }
-
- public void writeToBuffer(QpidByteBuffer buffer)
- {
- buffer.put((byte)0x50);
- buffer.put(_value);
- }
-
- public void setValue(UnsignedByte value)
+ protected byte getFormatCode()
{
- _value = value.byteValue();
+ return (byte) 0x50;
}
private static Factory<UnsignedByte> FACTORY = new Factory<UnsignedByte>()
Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/UnsignedIntegerWriter.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/UnsignedIntegerWriter.java?rev=1780338&r1=1780337&r2=1780338&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/UnsignedIntegerWriter.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/UnsignedIntegerWriter.java Thu Jan 26 08:12:34 2017
@@ -40,6 +40,7 @@ public class UnsignedIntegerWriter
return 1;
}
+ @Override
public void writeToBuffer(QpidByteBuffer buffer)
{
buffer.put(ZERO_BYTE_FORMAT_CODE);
@@ -101,7 +102,8 @@ public class UnsignedIntegerWriter
super(value.byteValue());
}
- @Override protected byte getFormatCode()
+ @Override
+ protected byte getFormatCode()
{
return ONE_BYTE_FORMAT_CODE;
}
Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/UnsignedLongWriter.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/UnsignedLongWriter.java?rev=1780338&r1=1780337&r2=1780338&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/UnsignedLongWriter.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/UnsignedLongWriter.java Thu Jan 26 08:12:34 2017
@@ -39,6 +39,7 @@ public class UnsignedLongWriter
return 1;
}
+ @Override
public void writeToBuffer(QpidByteBuffer buffer)
{
buffer.put(ZERO_BYTE_FORMAT_CODE);
@@ -87,7 +88,8 @@ public class UnsignedLongWriter
super(value);
}
- @Override protected byte getFormatCode()
+ @Override
+ protected byte getFormatCode()
{
return ONE_BYTE_FORMAT_CODE;
}
Modified: qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/VariableWidthWriter.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/VariableWidthWriter.java?rev=1780338&r1=1780337&r2=1780338&view=diff
==============================================================================
--- qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/VariableWidthWriter.java (original)
+++ qpid/java/trunk/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/codec/VariableWidthWriter.java Thu Jan 26 08:12:34 2017
@@ -34,7 +34,8 @@ public abstract class VariableWidthWrite
_size = (_length & 0xFFFFFF00) == 0 ? 1 : 4;
}
- public void writeToBuffer(QpidByteBuffer buffer)
+ @Override
+ public final void writeToBuffer(QpidByteBuffer buffer)
{
final int length = getLength();
@@ -54,7 +55,7 @@ public abstract class VariableWidthWrite
}
@Override
- public int getEncodedSize()
+ public final int getEncodedSize()
{
return 1 + _size + getLength();
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org