You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/09 01:58:32 UTC
[GitHub] [incubator-nuttx] zouboan opened a new pull request, #7560: tools: Fix some buid error
zouboan opened a new pull request, #7560:
URL: https://github.com/apache/incubator-nuttx/pull/7560
## Summary
1、The lost of include tools/LibTargets.mk in Win.mk will cause fatal error in Windows native build;
2、Fix an error in Windows native build caused by lack of double quotation on `X` in expression `export DEFINE_PREFIX := $(subst X,,${shell $(DEFINE) "$(CC)" "X"});`
3、Fix an error when run `make -C tools -f Makefile.host clean` in Unix host without configure nuttx;
## Impact
Windows native build
## Testing
ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7560: tools: Fix some buid error
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7560:
URL: https://github.com/apache/incubator-nuttx/pull/7560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7560: tools: Fix some buid error
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7560:
URL: https://github.com/apache/incubator-nuttx/pull/7560#discussion_r1017345583
##########
tools/Config.mk:
##########
@@ -583,7 +583,7 @@ $(1)_$(2):
endef
-export DEFINE_PREFIX := $(subst X,,${shell $(DEFINE) "$(CC)" "X"})
+export DEFINE_PREFIX := $(subst "X",,${shell $(DEFINE) "$(CC)" "X"})
Review Comment:
this line cause ci break? @zouboan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] zouboan commented on a diff in pull request #7560: tools: Fix some buid error
Posted by GitBox <gi...@apache.org>.
zouboan commented on code in PR #7560:
URL: https://github.com/apache/incubator-nuttx/pull/7560#discussion_r1017355202
##########
tools/Config.mk:
##########
@@ -583,7 +583,7 @@ $(1)_$(2):
endef
-export DEFINE_PREFIX := $(subst X,,${shell $(DEFINE) "$(CC)" "X"})
+export DEFINE_PREFIX := $(subst "X",,${shell $(DEFINE) "$(CC)" "X"})
Review Comment:
yes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org