You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by bzz <gi...@git.apache.org> on 2016/08/02 13:26:37 UTC
[GitHub] zeppelin pull request #1263: Small cleanup of zeppelin-server tests
GitHub user bzz opened a pull request:
https://github.com/apache/zeppelin/pull/1263
Small cleanup of zeppelin-server tests
### What is this PR for?
Small cleanup of zeppelin-server tests
### What type of PR is it?
Refactoring
### How should this be tested?
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bzz/incubator-zeppelin cleanup/zeppelin-server-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1263.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1263
----
commit 95462d6dedb834b8d8d63865083cf215894f951c
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2016-08-02T11:05:36Z
Small cleanup of org.apache.zeppelin.* tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1263: Small cleanup of zeppelin-server tests
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1263: Small cleanup of zeppelin-server tests
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1263
I like this kind of PR. LGTM. Thanks for cleaning tests and removing unnecessary class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1263: Small cleanup of zeppelin-server tests
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1263
Thank you for review @jongyoul !
CI fails on spark 1.6 profile, same as master, handled under [ZEPPELIN-1286](https://issues.apache.org/jira/browse/ZEPPELIN-1286)
Merging if there is no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1263: Small cleanup of zeppelin-server tests
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1263
CI failure
```
Results :
Failed tests:
ZeppelinSparkClusterTest.sparkRTest:116 expected:<[[1] 3]> but was:<[<pre><code>Error in getSparkSession(): SparkSession not initialized
</code></pre>
<pre><code>Error in (function (classes, fdef, mtable) : unable to find an inherited method for function 'count' for signature '"function"'
</code></pre>]>
Tests run: 65, Failures: 1, Errors: 0, Skipped: 0
````
Fixed in #1259 so rebasing again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1263: Small cleanup of zeppelin-server tests
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1263
CI failed due to [ZEPPELIN-1264](https://issues.apache.org/jira/browse/ZEPPELIN-1264)
Rebasing on latest master and merging, if there is no further discusison
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---