You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Michael Osipov (Jira)" <ji...@apache.org> on 2021/04/25 20:03:00 UTC
[jira] [Updated] (MRESOLVER-164) DefaultDependencyCollector
filterVersions seems always return full version range
[ https://issues.apache.org/jira/browse/MRESOLVER-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Osipov updated MRESOLVER-164:
-------------------------------------
Component/s: Resolver
> DefaultDependencyCollector filterVersions seems always return full version range
> --------------------------------------------------------------------------------
>
> Key: MRESOLVER-164
> URL: https://issues.apache.org/jira/browse/MRESOLVER-164
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
> Affects Versions: 1.4.2, 1.6.1
> Reporter: Xiang Li
> Priority: Major
>
> Related to MNG-7049 but I think the root cause is in maven-resolver so I opened a new issue. Correct me if it is better to still use the old ticket.
> During using version ranges, I notice that maven will download all poms from a version range, which happen in that [loop|https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L404], the reason is that [verFilter|https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L155] here seems return null. Since by default, versionFilter is set to null by DefaultRepositorySystemSession, and I do not see many examples that setVersionFilter get used for some reason.
> Another thing that confuses me is that version range is resolved by DefaultVersionRangeResolver in maven rather than maven-resolver here.
>
> I wonder if it possible to set HighestVersionFilter [here|https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L155] instead of return all version range results. I am happy to contribute a PR with some guidance.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)