You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by lewismc <gi...@git.apache.org> on 2016/05/26 06:55:19 UTC
[GitHub] gora pull request: GORA-478 Address Sonar issues within gora-accum...
GitHub user lewismc opened a pull request:
https://github.com/apache/gora/pull/68
GORA-478 Address Sonar issues within gora-accumulo Encoder classes
This issue addresses https://issues.apache.org/jira/browse/GORA-478
It
* uses the @override notation where appropriate
* uses try-with-resources notation to greatly reduce the amount of incorrect exception handling, steam closing and encoder closing, this has the knock on issue of better Encoder APi design where Exceptions are included and enforced as part of the Encoder interface
* implements very trivial safety improvements such as moving array declarations from variables to types, and uppercasing 'l' to 'L' for long values.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lewismc/gora GORA-478
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/gora/pull/68.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #68
----
commit ae1b59c3c7304bc6f9a02f6efdcbc9997888297b
Author: Lewis John McGibbney <le...@gmail.com>
Date: 2016-05-24T13:35:47Z
Merge branch 'GORA_225' of https://github.com/djkevincr/gora this closes #61
commit 7a487145701c539f7439b58d7a837a7651418cc1
Author: Lewis John McGibbney <le...@gmail.com>
Date: 2016-05-26T06:36:42Z
GORA-478 Address Sonar issues within gora-accumulo Encoder classes
commit ef39527c11beba90669052fe8afea41c3ddb0bf8
Author: Lewis John McGibbney <le...@gmail.com>
Date: 2016-05-26T06:54:25Z
Merge branch 'master' of https://github.com/lewismc/gora
commit cf508cf07c3bf3907cebca1a930efcf7da37aae7
Author: Lewis John McGibbney <le...@gmail.com>
Date: 2016-05-26T06:56:32Z
Merge branch 'master' into GORA-478
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-478 Address Sonar issues within gora-accum...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/gora/pull/68
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-478 Address Sonar issues within gora-accum...
Posted by renato2099 <gi...@git.apache.org>.
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/68#issuecomment-221812629
:+1: Thanks @lewismc !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---