You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2026/08/13 17:15:43 UTC
[Impala-ASF-CR] IMPALA-15259: Update omake skill for ninja
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24664
Change subject: IMPALA-15259: Update omake skill for ninja
......................................................................
IMPALA-15259: Update omake skill for ninja
Change-Id: I1dc6211bec4a76fd1938749bd990d5bd890b4741
---
M .agents/skills/build-one-cc-file/scripts/omake.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/24664/2
--
To view, visit http://gerrit.cloudera.org:8080/24664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1dc6211bec4a76fd1938749bd990d5bd890b4741
Gerrit-Change-Number: 24664
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-15259: Update omake skill for ninja
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24664 )
Change subject: IMPALA-15259: Update omake skill for ninja
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/23602/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dc6211bec4a76fd1938749bd990d5bd890b4741
Gerrit-Change-Number: 24664
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Aug 2026 17:38:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15259: Update omake skill for ninja
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24664 )
Change subject: IMPALA-15259: Update omake skill for ninja
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/23643/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dc6211bec4a76fd1938749bd990d5bd890b4741
Gerrit-Change-Number: 24664
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Aug 2026 17:14:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15259: Update omake skill for ninja
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24664 )
Change subject: IMPALA-15259: Update omake skill for ninja
......................................................................
IMPALA-15259: Update omake skill for ninja
Updates the omake skill for Ninja, which puts build rules in a single
build.ninja and has different CLI options.
Change-Id: I1dc6211bec4a76fd1938749bd990d5bd890b4741
Reviewed-on: http://gerrit.cloudera.org:8080/24664
Reviewed-by: Jason Fehr <jf...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M .agents/skills/build-one-cc-file/scripts/omake.sh
1 file changed, 12 insertions(+), 3 deletions(-)
Approvals:
Jason Fehr: Looks good to me, approved
Michael Smith: Verified
--
To view, visit http://gerrit.cloudera.org:8080/24664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1dc6211bec4a76fd1938749bd990d5bd890b4741
Gerrit-Change-Number: 24664
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-15259: Update omake skill for ninja
Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24664 )
Change subject: IMPALA-15259: Update omake skill for ninja
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dc6211bec4a76fd1938749bd990d5bd890b4741
Gerrit-Change-Number: 24664
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Aug 2026 17:14:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15259: Update omake skill for ninja
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24664 )
Change subject: IMPALA-15259: Update omake skill for ninja
......................................................................
Patch Set 2:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24664/2/.agents/skills/build-one-cc-file/scripts/omake.sh
File .agents/skills/build-one-cc-file/scripts/omake.sh:
http://gerrit.cloudera.org:8080/#/c/24664/2/.agents/skills/build-one-cc-file/scripts/omake.sh@48
PS2, Line 48: MAKE_CMD=($IMPALA_MAKE_CMD DEBUG_NOOPT=1 -s -f "$MAKEFILE" "${MAKEFILE%/*}/$BASENAME.cc.o")
line too long (91 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/24664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dc6211bec4a76fd1938749bd990d5bd890b4741
Gerrit-Change-Number: 24664
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Aug 2026 17:18:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-15259: Update omake skill for ninja
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/24664 )
Change subject: IMPALA-15259: Update omake skill for ninja
......................................................................
IMPALA-15259: Update omake skill for ninja
Change-Id: I1dc6211bec4a76fd1938749bd990d5bd890b4741
---
M .agents/skills/build-one-cc-file/scripts/omake.sh
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/24664/3
--
To view, visit http://gerrit.cloudera.org:8080/24664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1dc6211bec4a76fd1938749bd990d5bd890b4741
Gerrit-Change-Number: 24664
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-15259: Update omake skill for ninja
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24664 )
Change subject: IMPALA-15259: Update omake skill for ninja
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/23603/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dc6211bec4a76fd1938749bd990d5bd890b4741
Gerrit-Change-Number: 24664
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Aug 2026 17:46:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15259: Update omake skill for ninja
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has removed a vote on this change.
Change subject: IMPALA-15259: Update omake skill for ninja
......................................................................
Removed Code-Review+2 by Peter Rozsa <pr...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/24664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I1dc6211bec4a76fd1938749bd990d5bd890b4741
Gerrit-Change-Number: 24664
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-15259: Update omake skill for ninja
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24664 )
Change subject: IMPALA-15259: Update omake skill for ninja
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24664/3/.agents/skills/build-one-cc-file/scripts/omake.sh
File .agents/skills/build-one-cc-file/scripts/omake.sh:
http://gerrit.cloudera.org:8080/#/c/24664/3/.agents/skills/build-one-cc-file/scripts/omake.sh@49
PS3, Line 49: ($IMPALA_MAKE_CMD DEBUG_NOOPT=1 -s -f "$MAKEFILE" "${MAKEFILE%/*}/$BASENAME.cc.o")
This isn't actually enough. build.make doesn't exist, and the layout of build.ninja is different.
--
To view, visit http://gerrit.cloudera.org:8080/24664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dc6211bec4a76fd1938749bd990d5bd890b4741
Gerrit-Change-Number: 24664
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Aug 2026 16:29:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-15259: Update omake skill for ninja
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Jason Fehr, Zoltan Borok-Nagy, Peter Rozsa, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24664
to look at the new patch set (#4).
Change subject: IMPALA-15259: Update omake skill for ninja
......................................................................
IMPALA-15259: Update omake skill for ninja
Updates the omake skill for Ninja, which puts build rules in a single
build.ninja and has different CLI options.
Change-Id: I1dc6211bec4a76fd1938749bd990d5bd890b4741
---
M .agents/skills/build-one-cc-file/scripts/omake.sh
1 file changed, 12 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/24664/4
--
To view, visit http://gerrit.cloudera.org:8080/24664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1dc6211bec4a76fd1938749bd990d5bd890b4741
Gerrit-Change-Number: 24664
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-15259: Update omake skill for ninja
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24664 )
Change subject: IMPALA-15259: Update omake skill for ninja
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24664/3/.agents/skills/build-one-cc-file/scripts/omake.sh
File .agents/skills/build-one-cc-file/scripts/omake.sh:
http://gerrit.cloudera.org:8080/#/c/24664/3/.agents/skills/build-one-cc-file/scripts/omake.sh@49
PS3, Line 49: MAKE_CMD=(make DEBUG_NOOPT=1 -s -f "$MAKEFILE" "${MAKEFILE%/*}/$BASENAME.cc.o")
> This isn't actually enough. build.make doesn't exist, and the layout of bui
Done
--
To view, visit http://gerrit.cloudera.org:8080/24664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dc6211bec4a76fd1938749bd990d5bd890b4741
Gerrit-Change-Number: 24664
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Aug 2026 16:49:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-15259: Update omake skill for ninja
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24664 )
Change subject: IMPALA-15259: Update omake skill for ninja
......................................................................
Patch Set 5: Verified+1
Manually confirmed it works with make and ninja. Not used in regular CI.
--
To view, visit http://gerrit.cloudera.org:8080/24664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dc6211bec4a76fd1938749bd990d5bd890b4741
Gerrit-Change-Number: 24664
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Aug 2026 17:22:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15259: Update omake skill for ninja
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24664 )
Change subject: IMPALA-15259: Update omake skill for ninja
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dc6211bec4a76fd1938749bd990d5bd890b4741
Gerrit-Change-Number: 24664
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Aug 2026 11:08:25 +0000
Gerrit-HasComments: No