You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@commons.apache.org by ma...@apache.org on 2011/06/13 17:40:01 UTC

svn commit: r1135148 - in /commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl: GenericKeyedObjectPool.java GenericObjectPool.java

Author: markt
Date: Mon Jun 13 15:40:01 2011
New Revision: 1135148

URL: http://svn.apache.org/viewvc?rev=1135148&view=rev
Log:
Review of r1135111

Modified:
    commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
    commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericObjectPool.java

Modified: commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java?rev=1135148&r1=1135147&r2=1135148&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java (original)
+++ commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java Mon Jun 13 15:40:01 2011
@@ -1739,7 +1739,7 @@ public class GenericKeyedObjectPool<K,T>
 
     /** My {@link KeyedPoolableObjectFactory}. */
     private volatile KeyedPoolableObjectFactory<K,T> _factory = null;
-    private Object factoryLock = new Object();
+    final private Object factoryLock = new Object();
 
     /**
      * My idle object eviction {@link TimerTask}, if any.

Modified: commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericObjectPool.java?rev=1135148&r1=1135147&r2=1135148&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericObjectPool.java (original)
+++ commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericObjectPool.java Mon Jun 13 15:40:01 2011
@@ -1997,8 +1997,8 @@ public class GenericObjectPool<T> extend
     private volatile boolean _lifo = DEFAULT_LIFO;
 
     /** My {@link PoolableObjectFactory}. */
-    private PoolableObjectFactory<T> _factory;
-    private Object factoryLock = new Object();
+    private volatile PoolableObjectFactory<T> _factory;
+    final private Object factoryLock = new Object();
 
     /**
      * My idle object eviction {@link TimerTask}, if any.