[GitHub] CNNJYB opened a new pull request #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout

[GitBox <gi...@apache.org>]

CNNJYB opened a new pull request #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout
URL: https://github.com/apache/activemq-artemis/pull/2533
 
 
   We found server crash becauseof critical analyzer timeout, thread dump can be seen in attachment.	
   Suppose that there is a topic t with two subscriber ta and tb. Some messages were routed to subscriber ta, not to tb. When a consumer that subscribe tb is created and send ConsumerCredits to server, ServerConsumerImpl will call promptDelivery method, then forceDelivery() -> messageQueue.deliverAsync() -> deliverRunner will executed in the pageSubscription's executor(step1), then checkDepage(step2) -> pageIterator.hasNext(synchronized method) -> next -> moveNext, moveNext method will iterate through queue until find a matching message. At this time(step1), DeliverRunner call deliver method -> checkDepage -> pageIterator.hasNext, this step blocked on CursorIterator which was locked by step2, then critical analyzer timeout.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services