[GitHub] [carbondata] jackylk commented on a change in pull request #3630: [CARBONDATA-3715]Fix Timeseries Query Rollup failure for timeseries column of Date type

[GitBox <gi...@apache.org>]

jackylk commented on a change in pull request #3630: [CARBONDATA-3715]Fix Timeseries Query Rollup failure for timeseries column of Date type
URL: https://github.com/apache/carbondata/pull/3630#discussion_r386100218
 
 

 ##########
 File path: mv/core/src/main/scala/org/apache/carbondata/mv/rewrite/Utils.scala
 ##########
 @@ -590,6 +591,21 @@ object Utils extends PredicateHelper {
     }
   }
 
+  /**
+   * transform cast expression to change it's child attribute reference name to lower case
+   */
+  def getTransformedCastExpression(cast: Cast): Expression = {
+    cast.transform {
+      case attr: AttributeReference =>
+        CarbonToSparkAdapter.createAttributeReference(attr.name.toLowerCase,
 
 Review comment:
   move `attr.name.toLowerCase` to next line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services