You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Johannes Koch (JIRA)" <ji...@apache.org> on 2009/07/16 13:16:14 UTC

[jira] Created: (HTTPCLIENT-861) URI reference resolution fails examples in RFC 3986

URI reference resolution fails examples in RFC 3986
---------------------------------------------------

                 Key: HTTPCLIENT-861
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-861
             Project: HttpComponents HttpClient
          Issue Type: Bug
          Components: HttpClient
    Affects Versions: 4.0 Beta 2
            Reporter: Johannes Koch
            Priority: Minor


org.apache.http.client.utils.URIUtils.resolve(final URI baseURI, URI reference) fails to resolve some examples from RFC 3986 section 5.3 correctly. See TestCase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Reopened: (HTTPCLIENT-861) URI reference resolution fails examples in RFC 3986

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski reopened HTTPCLIENT-861:
------------------------------------------


> URI reference resolution fails examples in RFC 3986
> ---------------------------------------------------
>
>                 Key: HTTPCLIENT-861
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-861
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.0 Beta 2
>            Reporter: Johannes Koch
>            Priority: Minor
>             Fix For: 4.0 Final
>
>         Attachments: HTTPCLIENT-861-patch.txt, TestURIUtils.java, TestURIUtils.java
>
>
> org.apache.http.client.utils.URIUtils.resolve(final URI baseURI, URI reference) fails to resolve some examples from RFC 3986 section 5.3 correctly. See TestCase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Updated: (HTTPCLIENT-861) URI reference resolution fails examples in RFC 3986

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski updated HTTPCLIENT-861:
-----------------------------------------

    Fix Version/s: 4.0 Final

> URI reference resolution fails examples in RFC 3986
> ---------------------------------------------------
>
>                 Key: HTTPCLIENT-861
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-861
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.0 Beta 2
>            Reporter: Johannes Koch
>            Priority: Minor
>             Fix For: 4.0 Final
>
>         Attachments: HTTPCLIENT-861-patch.txt, TestURIUtils.java, TestURIUtils.java
>
>
> org.apache.http.client.utils.URIUtils.resolve(final URI baseURI, URI reference) fails to resolve some examples from RFC 3986 section 5.3 correctly. See TestCase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Resolved: (HTTPCLIENT-861) URI reference resolution fails examples in RFC 3986

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-861.
------------------------------------------

    Resolution: Fixed

Patch checked in

Many thanks, Johannes

Oleg

> URI reference resolution fails examples in RFC 3986
> ---------------------------------------------------
>
>                 Key: HTTPCLIENT-861
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-861
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.0 Beta 2
>            Reporter: Johannes Koch
>            Priority: Minor
>             Fix For: 4.0 Final
>
>         Attachments: HTTPCLIENT-861-patch.txt, TestURIUtils.java, TestURIUtils.java
>
>
> org.apache.http.client.utils.URIUtils.resolve(final URI baseURI, URI reference) fails to resolve some examples from RFC 3986 section 5.3 correctly. See TestCase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Updated: (HTTPCLIENT-861) URI reference resolution fails examples in RFC 3986

Posted by "Johannes Koch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johannes Koch updated HTTPCLIENT-861:
-------------------------------------

    Attachment: TestURIUtils.java

> URI reference resolution fails examples in RFC 3986
> ---------------------------------------------------
>
>                 Key: HTTPCLIENT-861
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-861
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.0 Beta 2
>            Reporter: Johannes Koch
>            Priority: Minor
>         Attachments: TestURIUtils.java
>
>
> org.apache.http.client.utils.URIUtils.resolve(final URI baseURI, URI reference) fails to resolve some examples from RFC 3986 section 5.3 correctly. See TestCase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Updated: (HTTPCLIENT-861) URI reference resolution fails examples in RFC 3986

Posted by "Johannes Koch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johannes Koch updated HTTPCLIENT-861:
-------------------------------------

    Attachment: TestURIUtils.java
                HTTPCLIENT-861-patch.txt

Please review the patch and the extended test case.

> URI reference resolution fails examples in RFC 3986
> ---------------------------------------------------
>
>                 Key: HTTPCLIENT-861
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-861
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.0 Beta 2
>            Reporter: Johannes Koch
>            Priority: Minor
>         Attachments: HTTPCLIENT-861-patch.txt, TestURIUtils.java, TestURIUtils.java
>
>
> org.apache.http.client.utils.URIUtils.resolve(final URI baseURI, URI reference) fails to resolve some examples from RFC 3986 section 5.3 correctly. See TestCase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Closed: (HTTPCLIENT-861) URI reference resolution fails examples in RFC 3986

Posted by "Johannes Koch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johannes Koch closed HTTPCLIENT-861.
------------------------------------


> URI reference resolution fails examples in RFC 3986
> ---------------------------------------------------
>
>                 Key: HTTPCLIENT-861
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-861
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.0 Beta 2
>            Reporter: Johannes Koch
>            Priority: Minor
>             Fix For: 4.0 Final
>
>         Attachments: HTTPCLIENT-861-patch.txt, TestURIUtils.java, TestURIUtils.java
>
>
> org.apache.http.client.utils.URIUtils.resolve(final URI baseURI, URI reference) fails to resolve some examples from RFC 3986 section 5.3 correctly. See TestCase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Re: [jira] Resolved: (HTTPCLIENT-861) URI reference resolution fails examples in RFC 3986

Posted by Oleg Kalnichevski <ol...@apache.org>.
On Thu, Jul 16, 2009 at 02:11:39PM +0200, Johannes Koch wrote:
> Oleg,
>
> Oleg Kalnichevski (JIRA) schrieb:
>>      [ https://issues.apache.org/jira/browse/HTTPCLIENT-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Oleg Kalnichevski resolved HTTPCLIENT-861.
>> ------------------------------------------
>>
>>     Resolution: Won't Fix
>>
>> Johannes,
>>
>> I get 6 test failures locally. However in all 6 cases HttpClient merely passes the call onto JRE's method URI URI#resolve(URI uri). The URI resolution itself is handled by JRE code. I am afraid there is simply not much we can do about it. This problem should be reported to OpenJDK / Sun / Oracle developers.
>>
>> Alternatively one could consider contributing a new implementation of that method completely independent from JRE code, but I personally think we ought not duplicate URI functionality provided by the platform.
>
> the resolve methods in the URIUtils class were introduced as a  
> work-around for known bugs in the URI.resolve() methods. Some of these  
> bugs were reported to Sun many years ago. And there's not much hope that  
> they will be fixed soon.
>
> I can try to create more work-arounds so that the tests pass.
>

Sure thing. As long as people are willing to contribute code along with accompanying test cases ('scratch their own itch', so to speak) I will be willing to review contributions and commit them to the repository.

Oleg

> -- 
> Johannes Koch
> Fraunhofer Institute for Applied Information Technology FIT
> Web Compliance Center
> Schloss Birlinghoven, D-53757 Sankt Augustin, Germany
> Phone: +49-2241-142628    Fax: +49-2241-142065
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Re: [jira] Resolved: (HTTPCLIENT-861) URI reference resolution fails examples in RFC 3986

Posted by Johannes Koch <jo...@fit.fraunhofer.de>.
Oleg,

Oleg Kalnichevski (JIRA) schrieb:
>      [ https://issues.apache.org/jira/browse/HTTPCLIENT-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> 
> Oleg Kalnichevski resolved HTTPCLIENT-861.
> ------------------------------------------
> 
>     Resolution: Won't Fix
> 
> Johannes,
> 
> I get 6 test failures locally. However in all 6 cases HttpClient merely passes the call onto JRE's method URI URI#resolve(URI uri). The URI resolution itself is handled by JRE code. I am afraid there is simply not much we can do about it. This problem should be reported to OpenJDK / Sun / Oracle developers.
> 
> Alternatively one could consider contributing a new implementation of that method completely independent from JRE code, but I personally think we ought not duplicate URI functionality provided by the platform.

the resolve methods in the URIUtils class were introduced as a 
work-around for known bugs in the URI.resolve() methods. Some of these 
bugs were reported to Sun many years ago. And there's not much hope that 
they will be fixed soon.

I can try to create more work-arounds so that the tests pass.

-- 
Johannes Koch
Fraunhofer Institute for Applied Information Technology FIT
Web Compliance Center
Schloss Birlinghoven, D-53757 Sankt Augustin, Germany
Phone: +49-2241-142628    Fax: +49-2241-142065

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Resolved: (HTTPCLIENT-861) URI reference resolution fails examples in RFC 3986

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-861.
------------------------------------------

    Resolution: Won't Fix

Johannes,

I get 6 test failures locally. However in all 6 cases HttpClient merely passes the call onto JRE's method URI URI#resolve(URI uri). The URI resolution itself is handled by JRE code. I am afraid there is simply not much we can do about it. This problem should be reported to OpenJDK / Sun / Oracle developers.

Alternatively one could consider contributing a new implementation of that method completely independent from JRE code, but I personally think we ought not duplicate URI functionality provided by the platform.

Oleg

> URI reference resolution fails examples in RFC 3986
> ---------------------------------------------------
>
>                 Key: HTTPCLIENT-861
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-861
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.0 Beta 2
>            Reporter: Johannes Koch
>            Priority: Minor
>         Attachments: TestURIUtils.java
>
>
> org.apache.http.client.utils.URIUtils.resolve(final URI baseURI, URI reference) fails to resolve some examples from RFC 3986 section 5.3 correctly. See TestCase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org