[jira] [Comment Edited] (HDFS-14452) Make Op#valueOf() Public

["Surendra Singh Lilhore (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-14452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908832#comment-16908832 ] 

Surendra Singh Lilhore edited comment on HDFS-14452 at 8/16/19 8:52 AM:
------------------------------------------------------------------------

Hi [~belugabehr],

InterfaceAudience for {{OP}} is {{private}}, means it is used only in hadoop. Can you tell me your scenario ?
{code:java}
/** Operation */
@InterfaceAudience.Private
@InterfaceStability.Evolving
public enum Op {
  WRITE_BLOCK((byte)80),{code}


was (Author: surendrasingh):
LGTM, +1

> Make Op#valueOf() Public
> ------------------------
>
>                 Key: HDFS-14452
>                 URL: https://issues.apache.org/jira/browse/HDFS-14452
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 3.2.0
>            Reporter: David Mollitor
>            Assignee: hemanthboyina
>            Priority: Minor
>              Labels: noob
>         Attachments: HDFS-14452.patch
>
>
> Change signature of {{private static Op valueOf(byte code)}} to be public.  Right now, the only easy way to look up in Op is to pass in a {{DataInput}} object, which is not all that flexible and efficient for other custom implementations that want to store the Op code a different way.
> https://github.com/apache/hadoop/blob/8c95cb9d6bef369fef6a8364f0c0764eba90e44a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Op.java#L53



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org