You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/05/19 06:37:06 UTC
[GitHub] [arrow] kou opened a new pull request, #35682: GH-35681: [Ruby] Add support for #select_columns with empty table
kou opened a new pull request, #35682:
URL: https://github.com/apache/arrow/pull/35682
### Rationale for this change
We can't use `garrow_chunked_array_combine()` with an empty `GArrowChunkedArray`.
### What changes are included in this PR?
Create an empty array instead of combining with an empty `GArrowChunkedArray`.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35682: GH-35681: [Ruby] Add support for #select_columns with empty table
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35682:
URL: https://github.com/apache/arrow/pull/35682#issuecomment-1554079826
* Closes: #35681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #35682: GH-35681: [Ruby] Add support for #select_columns with empty table
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #35682:
URL: https://github.com/apache/arrow/pull/35682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35682: GH-35681: [Ruby] Add support for #select_columns with empty table
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35682:
URL: https://github.com/apache/arrow/pull/35682#issuecomment-1555156250
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35682: GH-35681: [Ruby] Add support for #select_columns with empty table
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35682:
URL: https://github.com/apache/arrow/pull/35682#issuecomment-1554079847
:warning: GitHub issue #35681 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35682: GH-35681: [Ruby] Add support for #select_columns with empty table
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35682:
URL: https://github.com/apache/arrow/pull/35682#issuecomment-1556342650
Benchmark runs are scheduled for baseline = 8a856c90f9b8fa33de636f98eb33123ccc304b25 and contender = a4bcee3e389f73669c64637c93cd691ee26b1cd2. a4bcee3e389f73669c64637c93cd691ee26b1cd2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4ec0af40c406403b95dbc5d39e90c12c...8b1984e05a954da2ac29d971422bc2c1/)
[Finished :arrow_down:0.27% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5f6004d72b3a4ba6be69b057ade1259c...8fe557596e0e4c8b9068a61dbba4963b/)
[Finished :arrow_down:2.29% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bb42ae27d3f14ab4859115557bbc969e...2a01fa8531ae4c70ba78070cb2111ed7/)
[Finished :arrow_down:0.39% :arrow_up:0.06%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a8db8dbe44894d79bb00a2acd7b653c6...2412e3b45cab49d085fa74a5bbb38715/)
Buildkite builds:
[Finished] [`a4bcee3e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2904)
[Finished] [`a4bcee3e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2940)
[Finished] [`a4bcee3e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2905)
[Finished] [`a4bcee3e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2930)
[Finished] [`8a856c90` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2903)
[Finished] [`8a856c90` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2939)
[Finished] [`8a856c90` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2904)
[Finished] [`8a856c90` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2929)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35682: GH-35681: [Ruby] Add support for #select_columns with empty table
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35682:
URL: https://github.com/apache/arrow/pull/35682#issuecomment-1556343308
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bb42ae27d3f14ab4859115557bbc969e...2a01fa8531ae4c70ba78070cb2111ed7/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org