You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Ismael Juma (Jira)" <ji...@apache.org> on 2021/04/05 20:36:00 UTC
[jira] [Commented] (KAFKA-12618) Convert LogManager (and other
EasyMocks) in ReplicaManagerTest to Mockito
[ https://issues.apache.org/jira/browse/KAFKA-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315087#comment-17315087 ]
Ismael Juma commented on KAFKA-12618:
-------------------------------------
Also see https://issues.apache.org/jira/browse/KAFKA-7438
> Convert LogManager (and other EasyMocks) in ReplicaManagerTest to Mockito
> -------------------------------------------------------------------------
>
> Key: KAFKA-12618
> URL: https://issues.apache.org/jira/browse/KAFKA-12618
> Project: Kafka
> Issue Type: Task
> Reporter: Justine Olshan
> Priority: Minor
>
> [This commit|https://github.com/apache/kafka/commit/40f001cc537d6ff2efa71e609c2f84c6b934994d] introduced changes that have Partition calling getLog when there is no topic ID associated to the Partition. In this case, getLog will use a default argument. EasyMock (a Java framework) does not play well with scala's default arguments. For now, we are manually creating a partition and associating it in the initializeLogAndTopicId method. But a better long term solution is to use Mockito which better supports default arguments.
> It would be good to convert all EasyMocks over to mockito as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)