You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/07/28 06:44:22 UTC
[GitHub] [iotdb] CRZbulabula opened a new pull request, #6819: [IOTDB-3779] The Non-Seed-ConfigNode should suicide if waiting leader's scheduling for too long
CRZbulabula opened a new pull request, #6819:
URL: https://github.com/apache/iotdb/pull/6819
It's obviously that this new feature is necessary. I decide to complete this feature by judging if the current Non-Seed-ConfigNode joins in the ConsensusGroup sucessfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] Beyyes commented on a diff in pull request #6819: [IOTDB-3779] The Non-Seed-ConfigNode should suicide if waiting leader's scheduling for too long
Posted by GitBox <gi...@apache.org>.
Beyyes commented on code in PR #6819:
URL: https://github.com/apache/iotdb/pull/6819#discussion_r932794125
##########
confignode/src/main/java/org/apache/iotdb/confignode/service/ConfigNode.java:
##########
@@ -119,6 +119,27 @@ public void active() {
"{} has registered successfully. Waiting for the leader's scheduling to join the cluster.",
ConfigNodeConstant.GLOBAL_NAME);
+ boolean isJoinedCluster = false;
+ for (int retry = 0; retry < 20; retry++) {
Review Comment:
20 can be defined as a static final variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] Beyyes merged pull request #6819: [IOTDB-3779] The Non-Seed-ConfigNode should suicide if waiting leader's scheduling for too long
Posted by GitBox <gi...@apache.org>.
Beyyes merged PR #6819:
URL: https://github.com/apache/iotdb/pull/6819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] CRZbulabula commented on a diff in pull request #6819: [IOTDB-3779] The Non-Seed-ConfigNode should suicide if waiting leader's scheduling for too long
Posted by GitBox <gi...@apache.org>.
CRZbulabula commented on code in PR #6819:
URL: https://github.com/apache/iotdb/pull/6819#discussion_r932796193
##########
confignode/src/main/java/org/apache/iotdb/confignode/service/ConfigNode.java:
##########
@@ -119,6 +119,27 @@ public void active() {
"{} has registered successfully. Waiting for the leader's scheduling to join the cluster.",
ConfigNodeConstant.GLOBAL_NAME);
+ boolean isJoinedCluster = false;
+ for (int retry = 0; retry < 20; retry++) {
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org