You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "TisonKun (Jira)" <ji...@apache.org> on 2019/09/18 09:51:00 UTC
[jira] [Commented] (FLINK-14114) Shift down ClusterClient#timeout
to RestClusterClient
[ https://issues.apache.org/jira/browse/FLINK-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16932256#comment-16932256 ]
TisonKun commented on FLINK-14114:
----------------------------------
Hi [~zhuzh] if you'd like to work on this coordinate with FLINK-14070 I'm glad to assign this to you.
[~Zentol] [~kkl0u] I'm not sure if this breaks user cases that programming directly to {{ClusterClient}}...Anyway if we towards an interface-ized {{ClusterClient}} there should be no fields, but maybe we can do that all at once to prevent multiple bump from those users.
> Shift down ClusterClient#timeout to RestClusterClient
> -----------------------------------------------------
>
> Key: FLINK-14114
> URL: https://issues.apache.org/jira/browse/FLINK-14114
> Project: Flink
> Issue Type: Sub-task
> Components: Client / Job Submission
> Reporter: TisonKun
> Priority: Major
> Fix For: 1.10.0
>
>
> {{ClusterClient#timeout}} is only used in {{RestClusterClient}}, even without this prerequisite we can always shift down {{timeout}} field to subclasses of {{ClusterClient}}. It is towards an interface-ized {{ClusterClient}}. By side effect, we could reduce the dependency to parsing duration with Scala Duration on the fly.
> CC [~till.rohrmann] [~zhuzh]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)