You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/15 17:00:39 UTC

[GitHub] [shardingsphere] codecov-commenter commented on pull request #18379: Add getConfiguration method in ShardingSphereRule interface

codecov-commenter commented on PR #18379:
URL: https://github.com/apache/shardingsphere/pull/18379#issuecomment-1156717862

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18379?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#18379](https://codecov.io/gh/apache/shardingsphere/pull/18379?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d7ebf28) into [master](https://codecov.io/gh/apache/shardingsphere/commit/d4d05e7afc758d56e81a584152094c052b6e5057?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d4d05e7) will **increase** coverage by `0.01%`.
   > The diff coverage is `88.46%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18379      +/-   ##
   ============================================
   + Coverage     59.14%   59.15%   +0.01%     
   - Complexity     2195     2196       +1     
   ============================================
     Files          3738     3738              
     Lines         54790    54803      +13     
     Branches       9313     9305       -8     
   ============================================
   + Hits          32404    32418      +14     
   - Misses        19628    19633       +5     
   + Partials       2758     2752       -6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18379?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...data/database/rule/ShardingSphereRuleMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/18379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9ydWxlL1NoYXJkaW5nU3BoZXJlUnVsZU1ldGFEYXRhLmphdmE=) | `40.00% <0.00%> (-35.00%)` | :arrow_down: |
   | [...a/merge/engine/decorator/impl/TransparentRule.java](https://codecov.io/gh/apache/shardingsphere/pull/18379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtbWVyZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL21lcmdlL2VuZ2luZS9kZWNvcmF0b3IvaW1wbC9UcmFuc3BhcmVudFJ1bGUuamF2YQ==) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [...ache/shardingsphere/parser/rule/SQLParserRule.java](https://codecov.io/gh/apache/shardingsphere/pull/18379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1wYXJzZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcGFyc2VyL3J1bGUvU1FMUGFyc2VyUnVsZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ngsphere/sqltranslator/rule/SQLTranslatorRule.java](https://codecov.io/gh/apache/shardingsphere/pull/18379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC10cmFuc2xhdG9yL3NoYXJkaW5nc3BoZXJlLXNxbC10cmFuc2xhdG9yLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbHRyYW5zbGF0b3IvcnVsZS9TUUxUcmFuc2xhdG9yUnVsZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../updatable/SetReadwriteSplittingStatusHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/18379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi91cGRhdGFibGUvU2V0UmVhZHdyaXRlU3BsaXR0aW5nU3RhdHVzSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../manager/cluster/ClusterContextManagerBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/18379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9DbHVzdGVyQ29udGV4dE1hbmFnZXJCdWlsZGVyLmphdmE=) | `70.42% <33.33%> (+1.50%)` | :arrow_up: |
   | [...ShardingTableRulesUsedAlgorithmQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/18379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2Rpc3RzcWwvaGFuZGxlci9xdWVyeS9TaGFyZGluZ1RhYmxlUnVsZXNVc2VkQWxnb3JpdGhtUXVlcnlSZXN1bHRTZXQuamF2YQ==) | `56.25% <55.55%> (+1.41%)` | :arrow_up: |
   | [...ardingsphere/singletable/rule/SingleTableRule.java](https://codecov.io/gh/apache/shardingsphere/pull/18379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNpbmdsZS10YWJsZS9zaGFyZGluZ3NwaGVyZS1zaW5nbGUtdGFibGUtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2luZ2xldGFibGUvcnVsZS9TaW5nbGVUYWJsZVJ1bGUuamF2YQ==) | `65.59% <71.42%> (+0.37%)` | :arrow_up: |
   | [.../ral/common/queryable/ShowTrafficRulesHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/18379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9xdWVyeWFibGUvU2hvd1RyYWZmaWNSdWxlc0hhbmRsZXIuamF2YQ==) | `76.92% <83.33%> (-3.08%)` | :arrow_down: |
   | [...sphere/dbdiscovery/rule/DatabaseDiscoveryRule.java](https://codecov.io/gh/apache/shardingsphere/pull/18379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYmRpc2NvdmVyeS9ydWxlL0RhdGFiYXNlRGlzY292ZXJ5UnVsZS5qYXZh) | `63.75% <100.00%> (+2.93%)` | :arrow_up: |
   | ... and [29 more](https://codecov.io/gh/apache/shardingsphere/pull/18379/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18379?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18379?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d4d05e7...d7ebf28](https://codecov.io/gh/apache/shardingsphere/pull/18379?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org