Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #44393:
URL: https://github.com/apache/spark/pull/44393#discussion_r1444169083


##########
docs/sql-ref-functions-builtin.md:
##########
@@ -17,202 +17,125 @@ license: |
   limitations under the License.
 ---
 
-{% for static_file in site.static_files %}

Review Comment:
   Actually it was my bad. we still need this if-else because of `SKIP_API=1 bundle exec jekyll build`. It fails as below
   
   ```
   Configuration file: /.../workspace/forked/spark/docs/_config.yml
               Source: /.../workspace/forked/spark/docs
          Destination: /.../workspace/forked/spark/docs/_site
    Incremental build: disabled. Enable with --incremental
         Generating...
     Liquid Exception: Could not locate the included file '_generated_function_html/agg-funcs-table.html' in any of ["/.../workspace/forked/spark/docs/"]. Ensure it exists in one of those directories and, if it is a symlink, does not point outside your site source. in sql-ref-functions-builtin.md
   ...
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org