You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/01/04 15:03:09 UTC

[GitHub] [drill] cgivre opened a new pull request #2134: DRILL-7835: XML Reader Not Reading XML Nested Attributes Correctly

cgivre opened a new pull request #2134:
URL: https://github.com/apache/drill/pull/2134


   # [DRILL-7835](https://issues.apache.org/jira/browse/DRILL-7835): XML Reader Not Reading XML Nested Attributes Correctly
   
   ## Description
   This PR fixes a minor bug with XML files with nested fields which contain attributes.
   
   ## Documentation
   No user facing changes.  I updated the docs to reflect some limitations of the XML reader.
   
   ## Testing
   Added two additional unit tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] cgivre merged pull request #2134: DRILL-7835: XML Reader Not Reading XML Nested Attributes Correctly

Posted by GitBox <gi...@apache.org>.
cgivre merged pull request #2134:
URL: https://github.com/apache/drill/pull/2134


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] cgivre commented on pull request #2134: DRILL-7835: XML Reader Not Reading XML Nested Attributes Correctly

Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2134:
URL: https://github.com/apache/drill/pull/2134#issuecomment-754729618


   > @cgivre +1
   > BTW, I think I may have found an issue. It's got the `Schemas don't match` if i set `key1` value to null(`<key1></key1>`) in `nested-with-attributes.xml`. It should be a value mismatch.
   
   This is actually the desired behavior.  (I think)  The reader will basically ignore empty fields. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org