You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/03/11 07:23:25 UTC
[PR] CAMEL-22857: Fix issues found during Jackson 3 migration review [camel]
gnodet opened a new pull request, #21921:
URL: https://github.com/apache/camel/pull/21921
## Summary
Follow-up fixes for the Jackson 3 migration (#21800). These address issues found during code review.
### Fixes included:
- **Salesforce `JsonUtils`**: Restore `WRITE_DATES_AS_TIMESTAMPS` and `ADJUST_DATES_TO_CONTEXT_TIME_ZONE` using Jackson 3's `DateTimeFeature` — without this, dates serialize as numeric timestamps
- **ServiceNow `ServiceNowConfiguration`**: Restore custom date/time format serializers using the user's `dateFormat`/`timeFormat`/`dateTimeFormat` config properties, which became dead code after migration
- **CBOR `CBORDataFormat`**: Fix registry lookup to find `ObjectMapper` instances (not `TokenStreamFactory`) so users with registered `CBORMapper` are still auto-discovered; consolidate repeated `rebuild().build()` into single call
- **Micrometer `MicrometerModule`**: Remove dead `throws IOException` and try-catch from serializer methods (Jackson 3 uses unchecked exceptions)
- **Salesforce exception handling**: Restore try-catch in `AbstractDTOBase.toString()`, `LoginConfigHelper`, `StreamingApiConsumer`, and `DefaultBulkApiV2Client` — Jackson 3's unchecked `JacksonException` was causing lost error handling
### Context
See review comment: https://github.com/apache/camel/pull/21800#issuecomment-4037001940
This PR should be merged after #21800.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22857: Fix issues found during Jackson 3 migration review [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet closed pull request #21921: CAMEL-22857: Fix issues found during Jackson 3 migration review
URL: https://github.com/apache/camel/pull/21921
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22857: Fix issues found during Jackson 3 migration review [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #21921:
URL: https://github.com/apache/camel/pull/21921#issuecomment-4037070065
Pushed fixes directly to #21800 instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22857: Fix issues found during Jackson 3 migration review [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21921:
URL: https://github.com/apache/camel/pull/21921#issuecomment-4037050725
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org