You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by bh...@apache.org on 2016/11/09 06:53:11 UTC
[1/3] git commit: updated refs/heads/master to 96a2602
Repository: cloudstack
Updated Branches:
refs/heads/master 495f7bb1f -> 96a260214
CLOUDSTACK-8326: Always fill UDP checksums in DHCP replies in VR
In some cases the UDP checksums in packets from DHCP servers are
incorrect. This is a problem for some DHCP clients that ignore
packets with bad checksums. This patch inserts an iptables rule
to ensure DHCP servers always send packets with correct checksums.
Due to this bug DHCP offers are sometimes not accepted by Instances.
The end-result without this fix is no connectivity for the Instance
due to the lack of a IPv4 address.
This is also commited in OpenStack:
- https://github.com/projectcalico/felix/issues/40
- https://review.openstack.org/148718
- https://bugzilla.redhat.com/show_bug.cgi?id=910619
Signed-off-by: Wido den Hollander <wi...@widodh.nl>
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/fa56d0b3
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/fa56d0b3
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/fa56d0b3
Branch: refs/heads/master
Commit: fa56d0b3e6b8bf62396a820a84621c9eb8707a42
Parents: fcee71f
Author: Wido den Hollander <wi...@widodh.nl>
Authored: Mon Oct 31 20:43:39 2016 +0100
Committer: Wido den Hollander <wi...@widodh.nl>
Committed: Tue Nov 8 18:41:37 2016 +0100
----------------------------------------------------------------------
.../patches/debian/config/opt/cloud/bin/cs/CsAddress.py | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/fa56d0b3/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
----------------------------------------------------------------------
diff --git a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
index 64ddb26..075fddb 100755
--- a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
+++ b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
@@ -359,6 +359,10 @@ class CsIP:
"-m state --state RELATED,ESTABLISHED " +
"-j CONNMARK --restore-mark --nfmask 0xffffffff --ctmask 0xffffffff"])
+ self.fw.append(["mangle", "front",
+ "-A POSTROUTING " +
+ "-p udp -m udp --dport 68 -j CHECKSUM --checksum-fill"])
+
if self.get_type() in ["public"]:
self.fw.append(["mangle", "front",
"-A PREROUTING " +
@@ -375,9 +379,6 @@ class CsIP:
"-A VPN_%s -m state --state RELATED,ESTABLISHED -j ACCEPT" % self.address['public_ip']])
self.fw.append(["mangle", "",
"-A VPN_%s -j RETURN" % self.address['public_ip']])
- self.fw.append(["mangle", "front",
- "-A POSTROUTING " +
- "-p udp -m udp --dport 68 -j CHECKSUM --checksum-fill"])
self.fw.append(["nat", "",
"-A POSTROUTING -o eth2 -j SNAT --to-source %s" % self.address['public_ip']])
self.fw.append(["mangle", "",
@@ -454,6 +455,8 @@ class CsIP:
self.fw.append(
["filter", "", "-A INPUT -i %s -p udp -m udp --dport 67 -j ACCEPT" % self.dev])
self.fw.append(
+ ["mangle", "front", "-A POSTROUTING " + "-p udp -m udp --dport 68 -j CHECKSUM --checksum-fill"])
+ self.fw.append(
["filter", "", "-A INPUT -i %s -p udp -m udp --dport 53 -s %s -j ACCEPT" % (self.dev, guestNetworkCidr)])
self.fw.append(
["filter", "", "-A INPUT -i %s -p tcp -m tcp --dport 53 -s %s -j ACCEPT" % (self.dev, guestNetworkCidr)])
[3/3] git commit: updated refs/heads/master to 96a2602
Posted by bh...@apache.org.
Merge branch '4.9'
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/96a26021
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/96a26021
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/96a26021
Branch: refs/heads/master
Commit: 96a260214811a4f4d0110f690daac6f3a5e33ab3
Parents: 495f7bb 8b786d1
Author: Rohit Yadav <ro...@shapeblue.com>
Authored: Wed Nov 9 12:22:53 2016 +0530
Committer: Rohit Yadav <ro...@shapeblue.com>
Committed: Wed Nov 9 12:22:53 2016 +0530
----------------------------------------------------------------------
.../patches/debian/config/opt/cloud/bin/cs/CsAddress.py | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
[2/3] git commit: updated refs/heads/master to 96a2602
Posted by bh...@apache.org.
Merge pull request #1743 from wido/CLOUDSTACK-8326
CLOUDSTACK-8326: Always fill UDP checksums in DHCP replies in VRIn some cases the UDP checksums in packets from DHCP servers are
incorrect. This is a problem for some DHCP clients that ignore
packets with bad checksums. This patch inserts an iptables rule
to ensure DHCP servers always send packets with correct checksums.
Due to this bug DHCP offers are sometimes not accepted by Instances.
The end-result without this fix is no connectivity for the Instance
due to the lack of a IPv4 address.
Signed-off-by: Wido den Hollander <wi...@widodh.nl>
* pr/1743:
CLOUDSTACK-8326: Always fill UDP checksums in DHCP replies in VR
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/8b786d1f
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/8b786d1f
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/8b786d1f
Branch: refs/heads/master
Commit: 8b786d1fb2129326426e63d0c11eac717147f091
Parents: c09fc27 fa56d0b
Author: Rohit Yadav <ro...@shapeblue.com>
Authored: Wed Nov 9 12:17:38 2016 +0530
Committer: Rohit Yadav <ro...@shapeblue.com>
Committed: Wed Nov 9 12:18:03 2016 +0530
----------------------------------------------------------------------
.../patches/debian/config/opt/cloud/bin/cs/CsAddress.py | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------