[jira] [Resolved] (WW-3766) remove struts.freemarker.mru.max.strong.size from default.properties

["Lukasz Lenart (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WW-3766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukasz Lenart resolved WW-3766.
-------------------------------

    Resolution: Fixed
      Assignee: Lukasz Lenart

Set default for struts.freemarker.mru.max.strong.size to 0
                
> remove struts.freemarker.mru.max.strong.size from default.properties
> --------------------------------------------------------------------
>
>                 Key: WW-3766
>                 URL: https://issues.apache.org/jira/browse/WW-3766
>             Project: Struts 2
>          Issue Type: Improvement
>            Reporter: zhouyanming
>            Assignee: Lukasz Lenart
>            Priority: Critical
>              Labels: freemarker
>             Fix For: 2.3.8
>
>
> if struts.freemarker.mru.max.strong.size > 0 ,freemarker will use MruCacheStorage instead of SoftCacheStorage,and MruCacheStorage is not concurrent,it will synchronized on every call,it will affect performance. 
> in TemplateCache:
> {code:java}
> CachedTemplate cachedTemplate;
> if(isStorageConcurrent) {
>     cachedTemplate = (CachedTemplate)storage.get(tk);
> }
> else {
>     synchronized(storage) {
>        cachedTemplate = (CachedTemplate)storage.get(tk);
>     }
> }
> {code}
> please remove struts.freemarker.mru.max.strong.size from default.properties lets developers make their own choice.
> a better solution is implements a concurrent MruCacheStorage for struts2

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira