You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "David W. Van Couvering" <Da...@Sun.COM> on 2006/02/13 20:26:43 UTC
Wiki for patches
I would like to propose setting up a volunteer-only Wiki page for
patches. If you are a contributor you can add an entry to this page to
indicate you've got a patch submitted, and can track status. If you're
a committer, *if you want* you can scan this page and see what's pending.
Any objections?
I'll start working on it but will very willingly back it out if there is
generally agreement that this is Not a Good Idea.
David
Re: Wiki for patches
Posted by Rick Hillegas <Ri...@Sun.COM>.
Thanks, Andrew. I will look for this box again later when JIRA isn't
having an artistic fit.
Cheers,
-Rick
Andrew McIntyre wrote:
>
> On Feb 13, 2006, at 1:05 PM, Rick Hillegas wrote:
>
>> I'm afraid I'm more blind. Where on what screen is the "patch
>> available" box?
>
>
> When you create or edit an issue, it's just below the description and
> just above where you comment. It's small and unassuming - it doesn't
> blink and it's not bright magenta - so it's easy to miss.
>
> When searching for issues, you pick Find Issues, and then you need to
> select Derby as the project to search. That makes the custom 'patch
> available' field appear in the bottom left section of the screen, in
> the section labeled Custom Fields.
>
> Now that I've got the hang of the custom fields in JIRA, I could add
> all sorts of things - drop-down boxes, radio buttons, checkboxes.
> But, I don't want to overload JIRA with a bunch of fields whose state
> is poorly maintained, either. A query for open issues with a patch
> available should satisfy the answer to the question: what needs
> review? That leaves the question: what needs commit? But, if there's
> a checkbox for 'Patch needs commit,' but it will still be up to the
> committer to review the review comments (be they in JIRA or on the
> list) and determine whether or not there is consensus to apply a
> patch, and the committer will still need to review the patch
> themselves anyway, so I guess I'm just not sure what value another
> checkbox would add.
>
> andrew
Re: Wiki for patches
Posted by Andrew McIntyre <mc...@gmail.com>.
On Feb 13, 2006, at 1:05 PM, Rick Hillegas wrote:
> I'm afraid I'm more blind. Where on what screen is the "patch
> available" box?
When you create or edit an issue, it's just below the description and
just above where you comment. It's small and unassuming - it doesn't
blink and it's not bright magenta - so it's easy to miss.
When searching for issues, you pick Find Issues, and then you need to
select Derby as the project to search. That makes the custom 'patch
available' field appear in the bottom left section of the screen, in
the section labeled Custom Fields.
Now that I've got the hang of the custom fields in JIRA, I could add
all sorts of things - drop-down boxes, radio buttons, checkboxes.
But, I don't want to overload JIRA with a bunch of fields whose state
is poorly maintained, either. A query for open issues with a patch
available should satisfy the answer to the question: what needs
review? That leaves the question: what needs commit? But, if there's
a checkbox for 'Patch needs commit,' but it will still be up to the
committer to review the review comments (be they in JIRA or on the
list) and determine whether or not there is consensus to apply a
patch, and the committer will still need to review the patch
themselves anyway, so I guess I'm just not sure what value another
checkbox would add.
andrew
Re: Wiki for patches
Posted by Dy...@Sun.COM.
>>>>> "MvL" == Myrna van Lunteren <m....@gmail.com> writes:
MvL> You need to edit the jira issue.
MvL> (I'd forgotten where it was too, for a while :-) ).
MvL> I can see y'all's point that a wiki on this will get stale quickly.
MvL> However, it would be nice if there was more detail to be
MvL> had. Like, what state the patches / patch review is in, which
MvL> committer / other contributor is currently reviewing a
MvL> patch...that sort of thing.
Absolutely, no disagreement there. I hope that much of this can be
supported by JIRA directly. If not, I would prefer a system of
standardized JIRA comments, or standardized Subjects on mails to
derby-dev...
--
dt
Re: Wiki for patches
Posted by Myrna van Lunteren <m....@gmail.com>.
You need to edit the jira issue.
(I'd forgotten where it was too, for a while :-) ).
I can see y'all's point that a wiki on this will get stale quickly.
However, it would be nice if there was more detail to be had. Like, what
state the patches / patch review is in, which committer / other contributor
is currently reviewing a patch...that sort of thing.
Myrna
On 2/13/06, Rick Hillegas <Ri...@sun.com> wrote:
> I'm afraid I'm more blind. Where on what screen is the "patch available"
> box?
>
> Thanks,
> -Rick
>
> Kathey Marsden wrote:
>
> >David W. Van Couvering wrote:
> >
> >
> >
> >>I would like to propose setting up a volunteer-only Wiki page for
> >>patches. If you are a contributor you can add an entry to this page
> >>to indicate you've got a patch submitted, and can track status. If
> >>you're a committer, *if you want* you can scan this page and see
> >>what's pending.
> >>
> >>Any objections?
> >>
> >>
> >
> >We have the "patch available" box in Jira. I have been wondering how to
> >query to find issues with patches available. If this is possible that
> >seems like it would be more easily kept up to date instead of creating
> >another data repository for this information. I am quite sure I am just
> >being blind but does anyone know how to query Jira issues with patches
> >available?
> >
> >
> >Kathey
> >
> >
> >
> >
> >
>
>
Re: Wiki for patches
Posted by Rick Hillegas <Ri...@Sun.COM>.
I'm afraid I'm more blind. Where on what screen is the "patch available"
box?
Thanks,
-Rick
Kathey Marsden wrote:
>David W. Van Couvering wrote:
>
>
>
>>I would like to propose setting up a volunteer-only Wiki page for
>>patches. If you are a contributor you can add an entry to this page
>>to indicate you've got a patch submitted, and can track status. If
>>you're a committer, *if you want* you can scan this page and see
>>what's pending.
>>
>>Any objections?
>>
>>
>
>We have the "patch available" box in Jira. I have been wondering how to
>query to find issues with patches available. If this is possible that
>seems like it would be more easily kept up to date instead of creating
>another data repository for this information. I am quite sure I am just
>being blind but does anyone know how to query Jira issues with patches
>available?
>
>
>Kathey
>
>
>
>
>
Re: Wiki for patches
Posted by "David W. Van Couvering" <Da...@Sun.COM>.
OK, looks like there's general agreement not to do this. So I'll remove
the page.
David
Bernt M. Johnsen wrote:
>>>>>>>>>>>>>Dyre.Tjeldvoll@Sun.COM wrote (2006-02-13 21:15:01):
>>>>>>>
>>>>>>>"KM" == Kathey Marsden <km...@sbcglobal.net> writes:
>>
>> KM> David W. Van Couvering wrote:
>> >> I would like to propose setting up a volunteer-only Wiki page for
>> >> patches. If you are a contributor you can add an entry to this page
>> >> to indicate you've got a patch submitted, and can track status. If
>> >> you're a committer, *if you want* you can scan this page and see
>> >> what's pending.
>> >>
>> >> Any objections?
>>
>> KM> We have the "patch available" box in Jira. I have been wondering how to
>> KM> query to find issues with patches available. If this is possible that
>> KM> seems like it would be more easily kept up to date instead of creating
>> KM> another data repository for this information.
>>
>> I agree. I think the development process needs to be simpler (for
>> everybody) and not more complex. If this could be accomplished
>> within JIRA somehow, that would be preferable (to me at least).
>
>
> I agreee with Dyre. This is exactly the kind of wiki-pages that tend
> to become "stale" in a project. Jira is the plaec to do this if at all
> possible.
>
>
>
>>--
>>dt
>>
>
>
Re: Wiki for patches
Posted by "Bernt M. Johnsen" <Be...@Sun.COM>.
>>>>>>>>>>>> Dyre.Tjeldvoll@Sun.COM wrote (2006-02-13 21:15:01):
> >>>>> "KM" == Kathey Marsden <km...@sbcglobal.net> writes:
>
> KM> David W. Van Couvering wrote:
> >> I would like to propose setting up a volunteer-only Wiki page for
> >> patches. If you are a contributor you can add an entry to this page
> >> to indicate you've got a patch submitted, and can track status. If
> >> you're a committer, *if you want* you can scan this page and see
> >> what's pending.
> >>
> >> Any objections?
>
> KM> We have the "patch available" box in Jira. I have been wondering how to
> KM> query to find issues with patches available. If this is possible that
> KM> seems like it would be more easily kept up to date instead of creating
> KM> another data repository for this information.
>
> I agree. I think the development process needs to be simpler (for
> everybody) and not more complex. If this could be accomplished
> within JIRA somehow, that would be preferable (to me at least).
I agreee with Dyre. This is exactly the kind of wiki-pages that tend
to become "stale" in a project. Jira is the plaec to do this if at all
possible.
>
> --
> dt
>
--
Bernt Marius Johnsen, Database Technology Group,
Staff Engineer, Technical Lead Derby/Java DB
Sun Microsystems, Trondheim, Norway
Re: Wiki for patches
Posted by Dy...@Sun.COM.
>>>>> "KM" == Kathey Marsden <km...@sbcglobal.net> writes:
KM> David W. Van Couvering wrote:
>> I would like to propose setting up a volunteer-only Wiki page for
>> patches. If you are a contributor you can add an entry to this page
>> to indicate you've got a patch submitted, and can track status. If
>> you're a committer, *if you want* you can scan this page and see
>> what's pending.
>>
>> Any objections?
KM> We have the "patch available" box in Jira. I have been wondering how to
KM> query to find issues with patches available. If this is possible that
KM> seems like it would be more easily kept up to date instead of creating
KM> another data repository for this information.
I agree. I think the development process needs to be simpler (for
everybody) and not more complex. If this could be accomplished
within JIRA somehow, that would be preferable (to me at least).
--
dt
Re: Wiki for patches
Posted by "David W. Van Couvering" <Da...@Sun.COM>.
One question in terms of process. When someone reviews a patch with
comments they expect to be addressed, should they "un-check" the "patch
available" check box? Or should that be an invariant once the initial
patch has been submitted?
If we don't do this, how do I as a reviewer/committer, know that a new
patch revision is available, without being lucky enough to see the email
fly by?
David
Andrew McIntyre wrote:
>
> On Feb 13, 2006, at 11:55 AM, Kathey Marsden wrote:
>
>> I am quite sure I am just being blind but does anyone know how to
>> query Jira issues with patches
>>
>> available?
>>
>
> When you choose Find Issues, "Patch Available" is in the set of fields
> to search on the left, at the very bottom in the Custom Fields section.
>
> andrew
Re: Wiki for patches
Posted by Andrew McIntyre <mc...@gmail.com>.
On Feb 13, 2006, at 11:55 AM, Kathey Marsden wrote:
> I am quite sure I am just being blind but does anyone know how to
> query Jira issues with patches
> available?
When you choose Find Issues, "Patch Available" is in the set of
fields to search on the left, at the very bottom in the Custom Fields
section.
andrew
Re: Wiki for patches
Posted by Daniel John Debrunner <dj...@apache.org>.
Kathey Marsden wrote:
> David W. Van Couvering wrote:
>
>
>>I would like to propose setting up a volunteer-only Wiki page for
>>patches. If you are a contributor you can add an entry to this page
>>to indicate you've got a patch submitted, and can track status. If
>>you're a committer, *if you want* you can scan this page and see
>>what's pending.
>>
>>Any objections?
>
>
> We have the "patch available" box in Jira. I have been wondering how to
> query to find issues with patches available. If this is possible that
> seems like it would be more easily kept up to date instead of creating
> another data repository for this information. I am quite sure I am just
> being blind but does anyone know how to query Jira issues with patches
> available?
Forrest has a query for open bugs with available patches. I see this
when I click on filters and then scroll down the list.
I couldn't see how they were doing it due to jira rendering issues.
Dan.
Re: Wiki for patches
Posted by "David W. Van Couvering" <Da...@Sun.COM>.
Even if we get this working, how do we know about those strange
"in-between" status such as "patch reviewed", "new patch provided" or
"patch accepted, working on committing"? The nice thing about the Wiki
page is that it is more open-ended in terms of "current status" and
allows for these subtleties.
Again, the Truth is in JIRA and the mailing list; this is just available
as a supplement to the Truth.
David
Kathey Marsden wrote:
> David W. Van Couvering wrote:
>
>
>>I would like to propose setting up a volunteer-only Wiki page for
>>patches. If you are a contributor you can add an entry to this page
>>to indicate you've got a patch submitted, and can track status. If
>>you're a committer, *if you want* you can scan this page and see
>>what's pending.
>>
>>Any objections?
>
>
> We have the "patch available" box in Jira. I have been wondering how to
> query to find issues with patches available. If this is possible that
> seems like it would be more easily kept up to date instead of creating
> another data repository for this information. I am quite sure I am just
> being blind but does anyone know how to query Jira issues with patches
> available?
>
>
> Kathey
>
>
>
Re: Wiki for patches
Posted by Kathey Marsden <km...@sbcglobal.net>.
David W. Van Couvering wrote:
> I would like to propose setting up a volunteer-only Wiki page for
> patches. If you are a contributor you can add an entry to this page
> to indicate you've got a patch submitted, and can track status. If
> you're a committer, *if you want* you can scan this page and see
> what's pending.
>
> Any objections?
We have the "patch available" box in Jira. I have been wondering how to
query to find issues with patches available. If this is possible that
seems like it would be more easily kept up to date instead of creating
another data repository for this information. I am quite sure I am just
being blind but does anyone know how to query Jira issues with patches
available?
Kathey
Re: Wiki for patches
Posted by Myrna van Lunteren <m....@gmail.com>.
On 2/13/06, David W. Van Couvering <Da...@sun.com> wrote:
>
> I would like to propose setting up a volunteer-only Wiki page for
> patches. If you are a contributor you can add an entry to this page to
> indicate you've got a patch submitted, and can track status. If you're
> a committer, *if you want* you can scan this page and see what's pending.
>
> Any objections?
>
> I'll start working on it but will very willingly back it out if there is
> generally agreement that this is Not a Good Idea.
>
> David
>
>
>
I think that would be nice!
Myrna