You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2010/10/09 21:15:30 UTC
[jira] Created: (HBASE-3100) TestMergeTable failing in TRUNK
TestMergeTable failing in TRUNK
-------------------------------
Key: HBASE-3100
URL: https://issues.apache.org/jira/browse/HBASE-3100
Project: HBase
Issue Type: Bug
Reporter: stack
Fix For: 0.90.0
This is an old crufty test that is failing in TRUNK. We create regions -- user, root, and meta regions offline -- but then come along and disable them after starting up minicluster. Confuses new master. This test also does not emit logging up in hudson because its written against old-style testing... even has a subclass of the HBaseTestCase to do this crazy manual creation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-3100) TestMergeTable failing in TRUNK
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-3100:
-------------------------
Attachment: 3100-part3.txt
Upping compaction threshold did not prevent splits. A split went ahead because there were 'References'. Trying another config. Also, set an upper bound timer of 5 minutes on this test. Turns out this test failed on hudson and it cause TestTableMapReduce to fail (hudson #1541) because it left a zk running. TTMR put up its own zk on a different port but last task in the MR job suddenly finds this tests ZK instead of the TTMR one (looking into that too but committing this in meantime).
> TestMergeTable failing in TRUNK
> -------------------------------
>
> Key: HBASE-3100
> URL: https://issues.apache.org/jira/browse/HBASE-3100
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 0.90.0
>
> Attachments: 3100-part3.txt, 3100-xtra-debug.txt, 3100.txt
>
>
> This is an old crufty test that is failing in TRUNK. We create regions -- user, root, and meta regions offline -- but then come along and disable them after starting up minicluster. Confuses new master. This test also does not emit logging up in hudson because its written against old-style testing... even has a subclass of the HBaseTestCase to do this crazy manual creation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-3100) TestMergeTable failing in TRUNK
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-3100:
-------------------------
Attachment: 3100.txt
Here's a patch. I rewrote TestMergeTable so it should now be intelligible. Also added assertions that its actually doing a merge. Patch also does some cleanup of old unused super class and a test that did nothing.
{code}
M src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
Some fixup to support stepped start up of mini cluster; allow
starting dfs cluster, then later put an hbase mini cluster on top.
(startMiniHBaseCluster, createRootDir): Added.
D src/test/java/org/apache/hadoop/hbase/AbstractMergeTestBase.java
Removed messy subclass of HBaseClusterTestCase used building
up some specific loaded regions. Replaced with utility added
to HBaseTestingUtility and by methods added to specific test.
D src/test/java/org/apache/hadoop/hbase/util/TestMergeMeta.java
Deleted test that did nothing -- test merging of .META. -- but
the superclass was making user regions, not multiple instances
of .META. -- which we don't support anyways currently.
M src/test/java/org/apache/hadoop/hbase/util/TestMergeTable.java
Rewritten to use HBaseTestingUtility. Also added assertions that
it actually did successful merge (Were none previous).
M src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
Added a new constructor. Are the others redundant given I just
added implementation of Abortable to HConnection interface (the
implmementation of HConnection used implement it -- I've just
moved it up into the Interface itself).
M src/main/java/org/apache/hadoop/hbase/util/HMerge.java
Bit of minor cleanup refactoring.
M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
The HConnection Interface now implements Abortable.
M src/main/java/org/apache/hadoop/hbase/client/HConnection.java
Extend Abortable (The implementation was implementing Abortable
anyways).
{code}
> TestMergeTable failing in TRUNK
> -------------------------------
>
> Key: HBASE-3100
> URL: https://issues.apache.org/jira/browse/HBASE-3100
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.90.0
>
> Attachments: 3100.txt
>
>
> This is an old crufty test that is failing in TRUNK. We create regions -- user, root, and meta regions offline -- but then come along and disable them after starting up minicluster. Confuses new master. This test also does not emit logging up in hudson because its written against old-style testing... even has a subclass of the HBaseTestCase to do this crazy manual creation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3100) TestMergeTable failing in TRUNK
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920447#action_12920447 ]
stack commented on HBASE-3100:
------------------------------
So, this is the last failing test up on hudson. I see a few failure types. One is that the fat region splits which is not expected in the test. Another failure I'm seeing is that Master runs OPENED region handler twice. Have a patch for the first to stop it happening in future. Will add extra debug to figure how the second comes about.
> TestMergeTable failing in TRUNK
> -------------------------------
>
> Key: HBASE-3100
> URL: https://issues.apache.org/jira/browse/HBASE-3100
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 0.90.0
>
> Attachments: 3100.txt
>
>
> This is an old crufty test that is failing in TRUNK. We create regions -- user, root, and meta regions offline -- but then come along and disable them after starting up minicluster. Confuses new master. This test also does not emit logging up in hudson because its written against old-style testing... even has a subclass of the HBaseTestCase to do this crazy manual creation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-3100) TestMergeTable failing in TRUNK
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-3100:
-------------------------
Attachment: 3100-xtra-debug.txt
Committed this fix for one hudson failure mode. Also adds debug for another failure mode seen up on hudson (3100 not done yet).
> TestMergeTable failing in TRUNK
> -------------------------------
>
> Key: HBASE-3100
> URL: https://issues.apache.org/jira/browse/HBASE-3100
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 0.90.0
>
> Attachments: 3100-xtra-debug.txt, 3100.txt
>
>
> This is an old crufty test that is failing in TRUNK. We create regions -- user, root, and meta regions offline -- but then come along and disable them after starting up minicluster. Confuses new master. This test also does not emit logging up in hudson because its written against old-style testing... even has a subclass of the HBaseTestCase to do this crazy manual creation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-3100) TestMergeTable failing in TRUNK
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reassigned HBASE-3100:
----------------------------
Assignee: stack
> TestMergeTable failing in TRUNK
> -------------------------------
>
> Key: HBASE-3100
> URL: https://issues.apache.org/jira/browse/HBASE-3100
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 0.90.0
>
> Attachments: 3100.txt
>
>
> This is an old crufty test that is failing in TRUNK. We create regions -- user, root, and meta regions offline -- but then come along and disable them after starting up minicluster. Confuses new master. This test also does not emit logging up in hudson because its written against old-style testing... even has a subclass of the HBaseTestCase to do this crazy manual creation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3100) TestMergeTable failing in TRUNK
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919532#action_12919532 ]
stack commented on HBASE-3100:
------------------------------
Committed patch. Lets see if it works up on hudson.
> TestMergeTable failing in TRUNK
> -------------------------------
>
> Key: HBASE-3100
> URL: https://issues.apache.org/jira/browse/HBASE-3100
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 0.90.0
>
> Attachments: 3100.txt
>
>
> This is an old crufty test that is failing in TRUNK. We create regions -- user, root, and meta regions offline -- but then come along and disable them after starting up minicluster. Confuses new master. This test also does not emit logging up in hudson because its written against old-style testing... even has a subclass of the HBaseTestCase to do this crazy manual creation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-3100) TestMergeTable failing in TRUNK
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-3100.
--------------------------
Resolution: Fixed
This test is now passing up on hudson. Resolving.
> TestMergeTable failing in TRUNK
> -------------------------------
>
> Key: HBASE-3100
> URL: https://issues.apache.org/jira/browse/HBASE-3100
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 0.90.0
>
> Attachments: 3100-part3.txt, 3100-xtra-debug.txt, 3100.txt
>
>
> This is an old crufty test that is failing in TRUNK. We create regions -- user, root, and meta regions offline -- but then come along and disable them after starting up minicluster. Confuses new master. This test also does not emit logging up in hudson because its written against old-style testing... even has a subclass of the HBaseTestCase to do this crazy manual creation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.