You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Adrien Grand (JIRA)" <ji...@apache.org> on 2018/09/17 16:29:00 UTC
[jira] [Commented] (LUCENE-8505) IndexWriter#addIndices should not
sort indices if they are not already sorted
[ https://issues.apache.org/jira/browse/LUCENE-8505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617770#comment-16617770 ]
Adrien Grand commented on LUCENE-8505:
--------------------------------------
+1 You only plan to merge this to master, right? We still need the ability to re-sort segments for backward-compatibility with early 6.x indices?
> IndexWriter#addIndices should not sort indices if they are not already sorted
> -----------------------------------------------------------------------------
>
> Key: LUCENE-8505
> URL: https://issues.apache.org/jira/browse/LUCENE-8505
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Jim Ferenczi
> Priority: Minor
> Attachments: LUCENE-8505.patch
>
>
> Today IndexWriter#addIndices silently re-sort non-sorted indices when they are added in a sorted index. This is not safe because the sort is done entirely in memory and cannot handle big segments efficiently. This leniency was added because prior to 6.5, segments produced by flushes were not sorted, they had to wait for a merge to apply the index sorting. Now that segments are always sorted (LUCENE-7579) we should remove this ability and throw an error if the sort of the current index does not match with the candidate.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org