[GitHub] [hudi] danny0405 commented on a diff in pull request #8512: [HUDI-6057] Support Flink 1.17

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #8512:
URL: https://github.com/apache/hudi/pull/8512#discussion_r1174883882


##########
pom.xml:
##########
@@ -2373,6 +2374,17 @@
       </activation>
     </profile>
 
+    <profile>
+      <id>flink1.17</id>
+      <properties>
+        <orc.flink.version>1.5.6</orc.flink.version>
+      </properties>
+      <activation>
+        <property>
+          <name>flink1.17</name>
+        </property>
+      </activation>
+    </profile>
     <profile>
       <id>flink1.16</id>
       <properties>

Review Comment:
   Need to fix these property items for 1.16 profile:
   
   ```xml
           <flink.version>${flink1.16.version}</flink.version>
           <hudi.flink.module>hudi-flink1.16.x</hudi.flink.module>
           <flink.bundle.version>1.16</flink.bundle.version>
   ```



##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/sort/SortOperator.java:
##########
@@ -89,7 +95,7 @@ public void open() throws Exception {
             binarySerializer,
             computer,
             comparator,
-            getContainingTask().getJobConfiguration());
+            conf);

Review Comment:
   So after this fix, user expects to pass around the sort options through SQL (guess these options are configured in `flink-conf.yaml` or in SqlClient session)?  In `HoodieTableFactory#` we can also fetch a configuration through `context.getConfiguration()`, should we use that configuration then?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org