You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@curator.apache.org by Zhang Xiaoyu <zh...@gmail.com> on 2015/06/11 23:07:09 UTC

is that possible to make couple method public in ServiceDiscoveryImpl.java

Hi, guys,
Our project depends on curator since it is a Netflix project. We notice
that after it is moved to Apache, several methods in
class ServiceDiscoveryImpl.java is change to package accessible from public:

void    cacheOpened(ServiceCache<T> cache)
void    cacheClosed(ServiceCache<T> cache)
void    providerOpened(ServiceProvider<T> provider)
void    providerClosed(ServiceProvider<T> cache)
CuratorFramework getClient()
String  pathForName(String name)
InstanceSerializer<T> getSerializer()
List<ServiceInstance<T>>  queryForInstances(String name, Watcher watcher)
throws Exception

May I ask what's the reason to do so ? And is that possible to change it
back to public ? Our project is simply break if we bump to higher version
of Curator. We don't like to branch out the code either :)

Thanks in advance,
Johnny

Re: is that possible to make couple method public in ServiceDiscoveryImpl.java

Posted by Jordan Zimmerman <jo...@jordanzimmerman.com>.
Sorry, I don’t have much extra time. Maybe you can find someone else to do it. I don’t understand why you need your company’s legal department to write some code.

-Jordan



On June 11, 2015 at 8:54:55 PM, Zhang Xiaoyu (zhangxiaoyu912@gmail.com) wrote:

Hi, Jordan, thanks for reply. I would like to contribute to Curator! But need to go through company's legal for a separate open source project, it won't move quickly. Can you do me a favor do the Jira/Patch thing? Thanks!

Johnny

On Thu, Jun 11, 2015 at 6:46 PM, Jordan Zimmerman <jo...@jordanzimmerman.com> wrote:
Seem reasonable. Open a Jira and post a PR.

-JZ



On June 11, 2015 at 4:07:32 PM, Zhang Xiaoyu (zhangxiaoyu912@gmail.com) wrote:

Hi, guys,
Our project depends on curator since it is a Netflix project. We notice that after it is moved to Apache, several methods in class ServiceDiscoveryImpl.java is change to package accessible from public:

void    cacheOpened(ServiceCache<T> cache)
void    cacheClosed(ServiceCache<T> cache)
void    providerOpened(ServiceProvider<T> provider)
void    providerClosed(ServiceProvider<T> cache)
CuratorFramework getClient()
String  pathForName(String name)
InstanceSerializer<T> getSerializer()
List<ServiceInstance<T>>  queryForInstances(String name, Watcher watcher) throws Exception

May I ask what's the reason to do so ? And is that possible to change it back to public ? Our project is simply break if we bump to higher version of Curator. We don't like to branch out the code either :)

Thanks in advance,
Johnny

Re: is that possible to make couple method public in ServiceDiscoveryImpl.java

Posted by Zhang Xiaoyu <zh...@gmail.com>.
Hi, Jordan, thanks for reply. I would like to contribute to Curator! But
need to go through company's legal for a separate open source project, it
won't move quickly. Can you do me a favor do the Jira/Patch thing? Thanks!

Johnny

On Thu, Jun 11, 2015 at 6:46 PM, Jordan Zimmerman <
jordan@jordanzimmerman.com> wrote:

> Seem reasonable. Open a Jira and post a PR.
>
> -JZ
>
>
>
> On June 11, 2015 at 4:07:32 PM, Zhang Xiaoyu (zhangxiaoyu912@gmail.com)
> wrote:
>
> Hi, guys,
> Our project depends on curator since it is a Netflix project. We notice
> that after it is moved to Apache, several methods in
> class ServiceDiscoveryImpl.java is change to package accessible from public:
>
> void    cacheOpened(ServiceCache<T> cache)
> void    cacheClosed(ServiceCache<T> cache)
> void    providerOpened(ServiceProvider<T> provider)
> void    providerClosed(ServiceProvider<T> cache)
> CuratorFramework getClient()
> String  pathForName(String name)
> InstanceSerializer<T> getSerializer()
> List<ServiceInstance<T>>  queryForInstances(String name, Watcher watcher)
> throws Exception
>
> May I ask what's the reason to do so ? And is that possible to change it
> back to public ? Our project is simply break if we bump to higher version
> of Curator. We don't like to branch out the code either :)
>
> Thanks in advance,
> Johnny
>
>

Re: is that possible to make couple method public in ServiceDiscoveryImpl.java

Posted by Jordan Zimmerman <jo...@jordanzimmerman.com>.
Seem reasonable. Open a Jira and post a PR.

-JZ



On June 11, 2015 at 4:07:32 PM, Zhang Xiaoyu (zhangxiaoyu912@gmail.com) wrote:

Hi, guys,
Our project depends on curator since it is a Netflix project. We notice that after it is moved to Apache, several methods in class ServiceDiscoveryImpl.java is change to package accessible from public:

void    cacheOpened(ServiceCache<T> cache)
void    cacheClosed(ServiceCache<T> cache)
void    providerOpened(ServiceProvider<T> provider)
void    providerClosed(ServiceProvider<T> cache)
CuratorFramework getClient()
String  pathForName(String name)
InstanceSerializer<T> getSerializer()
List<ServiceInstance<T>>  queryForInstances(String name, Watcher watcher) throws Exception

May I ask what's the reason to do so ? And is that possible to change it back to public ? Our project is simply break if we bump to higher version of Curator. We don't like to branch out the code either :)

Thanks in advance,
Johnny