You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/30 08:27:30 UTC
[GitHub] [flink] AHeise opened a new pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
AHeise opened a new pull request #13027:
URL: https://github.com/apache/flink/pull/13027
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
This is a follow-up PR of https://github.com/apache/flink/pull/11303 after https://github.com/apache/flink/pull/11611 disabled it because of performance regression in blink e2e test.
## What is the purpose of the change
Decoupling user class loader from context classloader.
Thus, user classloader can be unloaded even though a reference on the context classloader outlives the user code.
## Brief change log
- Adding SafetyNetWrapperClassLoader
- Use it for FlinkUserCodeClassLoaders
- Make sure LocalExecutor closes user classloader
Compared to the original PR, it includes the following changes
- Use the parent classloader of the FlinkUserCodeClassLoader in SafetyNetWrapperClassLoader to address the performance concerns.
- Further, improve performance by enabling parallel class loading in all involved classloaders.
## Verifying this change
Added unit test.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
}, {
"hash" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166",
"triggerID" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"triggerType" : "PUSH"
}, {
"hash" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5190",
"triggerID" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"triggerType" : "PUSH"
}, {
"hash" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5303",
"triggerID" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"triggerType" : "PUSH"
}, {
"hash" : "30c7fa20d57633b62a3e28ddf4256193e6439ec2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5310",
"triggerID" : "30c7fa20d57633b62a3e28ddf4256193e6439ec2",
"triggerType" : "PUSH"
}, {
"hash" : "d98d4b17c52db1cea0fe0308b5330175c30e90da",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d98d4b17c52db1cea0fe0308b5330175c30e90da",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 30c7fa20d57633b62a3e28ddf4256193e6439ec2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5310)
* d98d4b17c52db1cea0fe0308b5330175c30e90da UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #13027:
URL: https://github.com/apache/flink/pull/13027
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
}, {
"hash" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166",
"triggerID" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"triggerType" : "PUSH"
}, {
"hash" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5190",
"triggerID" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"triggerType" : "PUSH"
}, {
"hash" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5303",
"triggerID" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"triggerType" : "PUSH"
}, {
"hash" : "30c7fa20d57633b62a3e28ddf4256193e6439ec2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5310",
"triggerID" : "30c7fa20d57633b62a3e28ddf4256193e6439ec2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 30c7fa20d57633b62a3e28ddf4256193e6439ec2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5310)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4301bfa208eabbbe2017eaa433183266bb9b4ac9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044)
* 47ea974f8307084c080c6d343bf7b22296ed8b44 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 47ea974f8307084c080c6d343bf7b22296ed8b44 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
}, {
"hash" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166",
"triggerID" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 47ea974f8307084c080c6d343bf7b22296ed8b44 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056)
* c03925d4b90fc68ef1d8a6d4189960724cd398cd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
}, {
"hash" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 47ea974f8307084c080c6d343bf7b22296ed8b44 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056)
* c03925d4b90fc68ef1d8a6d4189960724cd398cd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #13027:
URL: https://github.com/apache/flink/pull/13027#discussion_r469080456
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -124,6 +124,15 @@
return parseParentFirstLoaderPatterns(base, append);
}
+ @Documentation.Section(Documentation.Sections.EXPERT_CLASS_LOADING)
+ public static final ConfigOption<Boolean> CHECK_LEAKED_CLASSLOADER = ConfigOptions
+ .key("classloader.check_leaked_classloader")
Review comment:
we don't use underscores.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/execution/librarycache/FlinkUserCodeClassLoaders.java
##########
@@ -136,7 +150,10 @@ public void close() {
private FlinkUserCodeClassLoader ensureInner() {
if (inner == null) {
- throw new IllegalStateException("Trying to access closed classloader");
+ throw new IllegalStateException("Trying to access closed classloader. Please check if you store " +
+ "classloaders directly or indirectly in static fields. If the stacktrace suggests that the leak " +
+ "occurs in a third party library and cannot be fixed immediately, you can disable this check " +
+ "with the configuration 'classloader.check_leaked_classloader'.");
Review comment:
Retrieve the key from the actual configuration object instead.
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -124,6 +124,15 @@
return parseParentFirstLoaderPatterns(base, append);
}
+ @Documentation.Section(Documentation.Sections.EXPERT_CLASS_LOADING)
+ public static final ConfigOption<Boolean> CHECK_LEAKED_CLASSLOADER = ConfigOptions
+ .key("classloader.check_leaked_classloader")
+ .booleanType()
+ .defaultValue(true)
+ .withDescription("Fails if a user classloader is used in another job after a job has been finished. This " +
+ "check should only be disabled if the class leak occurs in an external library cannot be fixed " +
+ "immediately.");
Review comment:
```
Fails attempts at loading classes if the user classloader of a job is used after it has terminated.
This is usually caused by the classloader being leaked by lingering threads or misbehaving libraries, which may also result in the classloader being used by other jobs.
This check should only be disabled if such a leak prevents further jobs from running.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #13027:
URL: https://github.com/apache/flink/pull/13027#discussion_r466868396
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSink.java
##########
@@ -241,12 +242,14 @@ public final DataStreamSink consumeDataStream(DataStream dataStream) {
formatTypes[i] = tableSchema.getFieldDataType(i).get().getLogicalType();
}
RowType formatType = RowType.of(formatTypes, formatNames);
- Configuration formatConf = new Configuration(jobConf);
- sd.getSerdeInfo().getParameters().forEach(formatConf::set);
if (serLib.contains("parquet")) {
+ Configuration formatConf = new Configuration(jobConf);
+ sd.getSerdeInfo().getParameters().forEach(formatConf::set);
return Optional.of(ParquetRowDataBuilder.createWriterFactory(
formatType, formatConf, hiveVersion.startsWith("3.")));
} else if (serLib.contains("orc")) {
+ Configuration formatConf = new ThreadLocalClassLoaderConfiguration(jobConf);
Review comment:
If we were to use a normal configuration, what would happen? Subsequent jobs would not be able to run?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4301bfa208eabbbe2017eaa433183266bb9b4ac9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666221455
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4301bfa208eabbbe2017eaa433183266bb9b4ac9 (Thu Jul 30 08:23:01 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
}, {
"hash" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166",
"triggerID" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"triggerType" : "PUSH"
}, {
"hash" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5190",
"triggerID" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"triggerType" : "PUSH"
}, {
"hash" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5303",
"triggerID" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"triggerType" : "PUSH"
}, {
"hash" : "30c7fa20d57633b62a3e28ddf4256193e6439ec2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5310",
"triggerID" : "30c7fa20d57633b62a3e28ddf4256193e6439ec2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f85e2aed8e736a6b384063518d72ca0cb44869ad Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5303)
* 30c7fa20d57633b62a3e28ddf4256193e6439ec2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5310)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
}, {
"hash" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166",
"triggerID" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"triggerType" : "PUSH"
}, {
"hash" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5190",
"triggerID" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"triggerType" : "PUSH"
}, {
"hash" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5303",
"triggerID" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f85e2aed8e736a6b384063518d72ca0cb44869ad Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5303)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
}, {
"hash" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166",
"triggerID" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"triggerType" : "PUSH"
}, {
"hash" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5190",
"triggerID" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"triggerType" : "PUSH"
}, {
"hash" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5303",
"triggerID" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cccf1bd4390323e70e998f819975fa9c29e0e4e5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5190)
* f85e2aed8e736a6b384063518d72ca0cb44869ad Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5303)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
}, {
"hash" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166",
"triggerID" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"triggerType" : "PUSH"
}, {
"hash" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c03925d4b90fc68ef1d8a6d4189960724cd398cd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166)
* cccf1bd4390323e70e998f819975fa9c29e0e4e5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-668501769
> Could you summarize what the problem was that caused the performance regression?
For some reason, not setting a parent classloader in the wrapper is much slower. I cannot see an obvious reason and added a couple of measurements.
First, I wanted to know if the performance difference was caused by slower class loading. So I measured the total time spent in `ClassLoader#loadClass` for the previous version and this version. I found no difference. There is also no difference by the amount of classes loaded.
Second, a profiler revealed that much time in the slow version was spent in `Class#newInstance`. I added the time measurements to `org.apache.flink.table.runtime.generated.GeneratedClass`. Interestingly, there is again no difference in compiling the class. There is a huge difference in calling `newInstance` on the generated class though that can easily account for the time difference.
Without the parent, creating an instance of the 4 specific blink operators `BatchNestedLoopJoin`, `LongHashJoinOperator`, `LocalHashAggregateWithKeys`, and `HashAggregateWithKeys` slows down over time taking up over 10s to finish at the end of the.
Interestingly, they use only the instantiation method with explicit arguments `GeneratedClass#newInstance(ClassLoader classLoader, Object... args)`. However, there are also operators that use that method that are "well-behaved".
I have also forced class resolution through reflection on the generated classes, but resolution is fast in all cases. It's really just about creating the instances.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4301bfa208eabbbe2017eaa433183266bb9b4ac9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
AHeise edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-668501769
> Could you summarize what the problem was that caused the performance regression?
For some reason, not setting a parent classloader in the wrapper is much slower. I cannot see an obvious reason and added a couple of measurements.
First, I wanted to know if the performance difference was caused by slower class loading. So I measured the total time spent in `ClassLoader#loadClass` for the previous version and this version. I found no difference. There is also no difference by the amount of classes loaded.
Second, a profiler revealed that much time in the slow version was spent in `Class#newInstance`. I added the time measurements to `org.apache.flink.table.runtime.generated.GeneratedClass`. Interestingly, there is again no difference in compiling the class. There is a huge difference in calling `newInstance` on the generated class though that can easily account for the time difference.
Without the parent, creating an instance of the 4 specific blink operators `BatchNestedLoopJoin`, `LongHashJoinOperator`, `LocalHashAggregateWithKeys`, and `HashAggregateWithKeys` slows down over time taking up over 10s to finish at the end of the.
Interestingly, they use only the instantiation method with explicit arguments `GeneratedClass#newInstance(ClassLoader classLoader, Object... args)`. However, there are also operators that use that method that are "well-behaved".
I have also forced class resolution through reflection on the generated classes, but resolution is fast in all cases. It's really just about creating the instances.
edit: log of the timed measurements without parent: https://gist.github.com/AHeise/50375144fb6d6da7acb324544722e10b ; I can also provide the full logs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #13027:
URL: https://github.com/apache/flink/pull/13027#discussion_r466991654
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSink.java
##########
@@ -241,12 +242,14 @@ public final DataStreamSink consumeDataStream(DataStream dataStream) {
formatTypes[i] = tableSchema.getFieldDataType(i).get().getLogicalType();
}
RowType formatType = RowType.of(formatTypes, formatNames);
- Configuration formatConf = new Configuration(jobConf);
- sd.getSerdeInfo().getParameters().forEach(formatConf::set);
if (serLib.contains("parquet")) {
+ Configuration formatConf = new Configuration(jobConf);
+ sd.getSerdeInfo().getParameters().forEach(formatConf::set);
return Optional.of(ParquetRowDataBuilder.createWriterFactory(
formatType, formatConf, hiveVersion.startsWith("3.")));
} else if (serLib.contains("orc")) {
+ Configuration formatConf = new ThreadLocalClassLoaderConfiguration(jobConf);
Review comment:
Yes. That makes me believe that we should probably make the safety net configurable (on by default). Or would you think we can catch up and fix leaks much quicker?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #13027:
URL: https://github.com/apache/flink/pull/13027#discussion_r466997734
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSink.java
##########
@@ -241,12 +242,14 @@ public final DataStreamSink consumeDataStream(DataStream dataStream) {
formatTypes[i] = tableSchema.getFieldDataType(i).get().getLogicalType();
}
RowType formatType = RowType.of(formatTypes, formatNames);
- Configuration formatConf = new Configuration(jobConf);
- sd.getSerdeInfo().getParameters().forEach(formatConf::set);
if (serLib.contains("parquet")) {
+ Configuration formatConf = new Configuration(jobConf);
+ sd.getSerdeInfo().getParameters().forEach(formatConf::set);
return Optional.of(ParquetRowDataBuilder.createWriterFactory(
formatType, formatConf, hiveVersion.startsWith("3.")));
} else if (serLib.contains("orc")) {
+ Configuration formatConf = new ThreadLocalClassLoaderConfiguration(jobConf);
Review comment:
An opt-out switch is a good idea; also for cases where things don't behave as expected close to the next release, and we don't want to revert commits at that point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
}, {
"hash" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166",
"triggerID" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c03925d4b90fc68ef1d8a6d4189960724cd398cd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666273158
Could you summarize what the problem was that caused the performance regression?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
}, {
"hash" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166",
"triggerID" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"triggerType" : "PUSH"
}, {
"hash" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5190",
"triggerID" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"triggerType" : "PUSH"
}, {
"hash" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5303",
"triggerID" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"triggerType" : "PUSH"
}, {
"hash" : "30c7fa20d57633b62a3e28ddf4256193e6439ec2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5310",
"triggerID" : "30c7fa20d57633b62a3e28ddf4256193e6439ec2",
"triggerType" : "PUSH"
}, {
"hash" : "d98d4b17c52db1cea0fe0308b5330175c30e90da",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5358",
"triggerID" : "d98d4b17c52db1cea0fe0308b5330175c30e90da",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 30c7fa20d57633b62a3e28ddf4256193e6439ec2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5310)
* d98d4b17c52db1cea0fe0308b5330175c30e90da Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5358)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
}, {
"hash" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166",
"triggerID" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"triggerType" : "PUSH"
}, {
"hash" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5190",
"triggerID" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"triggerType" : "PUSH"
}, {
"hash" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5303",
"triggerID" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"triggerType" : "PUSH"
}, {
"hash" : "30c7fa20d57633b62a3e28ddf4256193e6439ec2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5310",
"triggerID" : "30c7fa20d57633b62a3e28ddf4256193e6439ec2",
"triggerType" : "PUSH"
}, {
"hash" : "d98d4b17c52db1cea0fe0308b5330175c30e90da",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5358",
"triggerID" : "d98d4b17c52db1cea0fe0308b5330175c30e90da",
"triggerType" : "PUSH"
}, {
"hash" : "74857e7cfe766ea0ba163e56a41251ca3fa0b4cf",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5483",
"triggerID" : "74857e7cfe766ea0ba163e56a41251ca3fa0b4cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74857e7cfe766ea0ba163e56a41251ca3fa0b4cf Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5483)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4301bfa208eabbbe2017eaa433183266bb9b4ac9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044)
* 47ea974f8307084c080c6d343bf7b22296ed8b44 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
}, {
"hash" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166",
"triggerID" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"triggerType" : "PUSH"
}, {
"hash" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5190",
"triggerID" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"triggerType" : "PUSH"
}, {
"hash" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5303",
"triggerID" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"triggerType" : "PUSH"
}, {
"hash" : "30c7fa20d57633b62a3e28ddf4256193e6439ec2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5310",
"triggerID" : "30c7fa20d57633b62a3e28ddf4256193e6439ec2",
"triggerType" : "PUSH"
}, {
"hash" : "d98d4b17c52db1cea0fe0308b5330175c30e90da",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5358",
"triggerID" : "d98d4b17c52db1cea0fe0308b5330175c30e90da",
"triggerType" : "PUSH"
}, {
"hash" : "74857e7cfe766ea0ba163e56a41251ca3fa0b4cf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "74857e7cfe766ea0ba163e56a41251ca3fa0b4cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d98d4b17c52db1cea0fe0308b5330175c30e90da Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5358)
* 74857e7cfe766ea0ba163e56a41251ca3fa0b4cf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
}, {
"hash" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166",
"triggerID" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"triggerType" : "PUSH"
}, {
"hash" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5190",
"triggerID" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"triggerType" : "PUSH"
}, {
"hash" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5303",
"triggerID" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"triggerType" : "PUSH"
}, {
"hash" : "30c7fa20d57633b62a3e28ddf4256193e6439ec2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5310",
"triggerID" : "30c7fa20d57633b62a3e28ddf4256193e6439ec2",
"triggerType" : "PUSH"
}, {
"hash" : "d98d4b17c52db1cea0fe0308b5330175c30e90da",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5358",
"triggerID" : "d98d4b17c52db1cea0fe0308b5330175c30e90da",
"triggerType" : "PUSH"
}, {
"hash" : "74857e7cfe766ea0ba163e56a41251ca3fa0b4cf",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5483",
"triggerID" : "74857e7cfe766ea0ba163e56a41251ca3fa0b4cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d98d4b17c52db1cea0fe0308b5330175c30e90da Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5358)
* 74857e7cfe766ea0ba163e56a41251ca3fa0b4cf Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5483)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
}, {
"hash" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166",
"triggerID" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"triggerType" : "PUSH"
}, {
"hash" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5190",
"triggerID" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cccf1bd4390323e70e998f819975fa9c29e0e4e5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5190)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
}, {
"hash" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166",
"triggerID" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"triggerType" : "PUSH"
}, {
"hash" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5190",
"triggerID" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"triggerType" : "PUSH"
}, {
"hash" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5303",
"triggerID" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"triggerType" : "PUSH"
}, {
"hash" : "30c7fa20d57633b62a3e28ddf4256193e6439ec2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "30c7fa20d57633b62a3e28ddf4256193e6439ec2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f85e2aed8e736a6b384063518d72ca0cb44869ad Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5303)
* 30c7fa20d57633b62a3e28ddf4256193e6439ec2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4301bfa208eabbbe2017eaa433183266bb9b4ac9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
}, {
"hash" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166",
"triggerID" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"triggerType" : "PUSH"
}, {
"hash" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5190",
"triggerID" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c03925d4b90fc68ef1d8a6d4189960724cd398cd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166)
* cccf1bd4390323e70e998f819975fa9c29e0e4e5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5190)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-668503396
There was also a [classloader leak in ORC](https://issues.apache.org/jira/browse/ORC-653), for which I added a workaround.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
}, {
"hash" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166",
"triggerID" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"triggerType" : "PUSH"
}, {
"hash" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5190",
"triggerID" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"triggerType" : "PUSH"
}, {
"hash" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cccf1bd4390323e70e998f819975fa9c29e0e4e5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5190)
* f85e2aed8e736a6b384063518d72ca0cb44869ad UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
}, {
"hash" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5056",
"triggerID" : "47ea974f8307084c080c6d343bf7b22296ed8b44",
"triggerType" : "PUSH"
}, {
"hash" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5166",
"triggerID" : "c03925d4b90fc68ef1d8a6d4189960724cd398cd",
"triggerType" : "PUSH"
}, {
"hash" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5190",
"triggerID" : "cccf1bd4390323e70e998f819975fa9c29e0e4e5",
"triggerType" : "PUSH"
}, {
"hash" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5303",
"triggerID" : "f85e2aed8e736a6b384063518d72ca0cb44869ad",
"triggerType" : "PUSH"
}, {
"hash" : "30c7fa20d57633b62a3e28ddf4256193e6439ec2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5310",
"triggerID" : "30c7fa20d57633b62a3e28ddf4256193e6439ec2",
"triggerType" : "PUSH"
}, {
"hash" : "d98d4b17c52db1cea0fe0308b5330175c30e90da",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5358",
"triggerID" : "d98d4b17c52db1cea0fe0308b5330175c30e90da",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d98d4b17c52db1cea0fe0308b5330175c30e90da Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5358)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13027:
URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044",
"triggerID" : "4301bfa208eabbbe2017eaa433183266bb9b4ac9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4301bfa208eabbbe2017eaa433183266bb9b4ac9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5044)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org