[jira] [Commented] (PHOENIX-4969) Clean up and unify code paths for RVCs with respect to Optimizations for SortOrder

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648611#comment-16648611 ] 

ASF GitHub Bot commented on PHOENIX-4969:
-----------------------------------------

Github user dbwong commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/362#discussion_r224941422
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/WhereOptimizer.java ---
    @@ -2060,10 +2084,13 @@ public Integer getScale() {
     
                                     @Override
                                     public SortOrder getSortOrder() {
    -                                    // The parts of the RVC have already been converted
    -                                    // to ascending, so we don't need to consider the
    -                                    // childPart sort order.
    -                                    return SortOrder.ASC;
    +                                    //WARNING HACK: Handle the different paths for InList vs Normal Comparison
    --- End diff --
    
    Made https://issues.apache.org/jira/browse/PHOENIX-4969 and will update the comment.


> Clean up and unify code paths for RVCs with respect to Optimizations for SortOrder
> ----------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4969
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4969
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Daniel Wong
>            Priority: Minor
>
> InList expressions for RVCs during key extraction assume that the SortOrder is ascending.  Investigation into PHOENIX-4841 showed that RVCs are in actual row order for Comparisons and this was causing the Filters to evaluate incorrectly. 
> A workaround was considered for 4841 that uses that RVCs with equality are rewritten to non-RVC form and InList should be the main user of the key extraction for equality comparisons.  A simpler cleaner should be taken instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)