[GitHub] [hive] anishek commented on a change in pull request #932: HIVE-22954 Repl Load using scheduler

[GitBox <gi...@apache.org>]

anishek commented on a change in pull request #932: HIVE-22954 Repl Load using scheduler
URL: https://github.com/apache/hive/pull/932#discussion_r388174308
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
 ##########
 @@ -121,7 +121,9 @@ public String getName() {
   public int execute() {
     try {
       Hive hiveDb = getHive();
-      Path dumpRoot = new Path(conf.getVar(HiveConf.ConfVars.REPLDIR), work.dbNameOrPattern.toLowerCase());
+      Path dumpRoot = new Path(conf.getVar(HiveConf.ConfVars.REPLDIR),
+              Base64.getEncoder().encodeToString(work.dbNameOrPattern.toLowerCase()
 
 Review comment:
   Given that we are not going to have expression ( for ex for table level replication ) do we still need the base64 encoding ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org