You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mehul Parikh <me...@freestoneinfotech.com> on 2018/05/04 07:03:19 UTC

Review Request 66945: RANGER-2094 : Handle Export Policy feature for different browsers

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66945/
-----------------------------------------------------------

Review request for ranger, Colm O hEigeartaigh, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2094
    https://issues.apache.org/jira/browse/RANGER-2094


Repository: ranger


Description
-------

Policies are not getting exported in Firefox 59.
"Add validity period" button is not working in Internet Explore 11.


Diffs
-----

  security-admin/src/main/webapp/libs/bower/moment/js/moment-timezone-with-data.min.js PRE-CREATION 
  security-admin/src/main/webapp/libs/bower/moment/js/moment-with-langs.min.js 15a339c 
  security-admin/src/main/webapp/libs/bower/moment/js/moment-with-locales.min.js PRE-CREATION 
  security-admin/src/main/webapp/scripts/Init.js 4de6b6d 
  security-admin/src/main/webapp/scripts/utils/XATemplateHelpers.js b64f911 
  security-admin/src/main/webapp/scripts/utils/XAUtils.js ed83669 
  security-admin/src/main/webapp/scripts/views/DownloadServicePolicy.js fc8edbb 
  security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 0a6b16c 
  security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js cb13908 
  security-admin/src/main/webapp/templates/common/downloadservicepolicy_tmpl.html e608a0f 
  security-admin/src/main/webapp/templates/helpers/XAHelpers.js e58bece 


Diff: https://reviews.apache.org/r/66945/diff/1/


Testing
-------

Verified Import Export feature on firefox as well as IE and chrome.
Also verified Add validaity feature on all 3 browsers. 

Did sanity testing on Firefox, Chrome and IE 11.


Thanks,

Mehul Parikh


Re: Review Request 66945: RANGER-2094 : Handle Export Policy feature for different browsers

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66945/#review202440
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On May 4, 2018, 7:03 a.m., Mehul Parikh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66945/
> -----------------------------------------------------------
> 
> (Updated May 4, 2018, 7:03 a.m.)
> 
> 
> Review request for ranger, Colm O hEigeartaigh, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2094
>     https://issues.apache.org/jira/browse/RANGER-2094
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Policies are not getting exported in Firefox 59.
> "Add validity period" button is not working in Internet Explore 11.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/libs/bower/moment/js/moment-timezone-with-data.min.js PRE-CREATION 
>   security-admin/src/main/webapp/libs/bower/moment/js/moment-with-langs.min.js 15a339c 
>   security-admin/src/main/webapp/libs/bower/moment/js/moment-with-locales.min.js PRE-CREATION 
>   security-admin/src/main/webapp/scripts/Init.js 4de6b6d 
>   security-admin/src/main/webapp/scripts/utils/XATemplateHelpers.js b64f911 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js ed83669 
>   security-admin/src/main/webapp/scripts/views/DownloadServicePolicy.js fc8edbb 
>   security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 0a6b16c 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js cb13908 
>   security-admin/src/main/webapp/templates/common/downloadservicepolicy_tmpl.html e608a0f 
>   security-admin/src/main/webapp/templates/helpers/XAHelpers.js e58bece 
> 
> 
> Diff: https://reviews.apache.org/r/66945/diff/1/
> 
> 
> Testing
> -------
> 
> Verified Import Export feature on firefox as well as IE and chrome.
> Also verified Add validaity feature on all 3 browsers. 
> 
> Did sanity testing on Firefox, Chrome and IE 11.
> 
> 
> Thanks,
> 
> Mehul Parikh
> 
>


Re: Review Request 66945: RANGER-2094 : Handle Export Policy feature for different browsers

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66945/#review202422
-----------------------------------------------------------


Ship it!




Ship It!

- Gautam Borad


On May 4, 2018, 7:03 a.m., Mehul Parikh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66945/
> -----------------------------------------------------------
> 
> (Updated May 4, 2018, 7:03 a.m.)
> 
> 
> Review request for ranger, Colm O hEigeartaigh, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2094
>     https://issues.apache.org/jira/browse/RANGER-2094
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Policies are not getting exported in Firefox 59.
> "Add validity period" button is not working in Internet Explore 11.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/libs/bower/moment/js/moment-timezone-with-data.min.js PRE-CREATION 
>   security-admin/src/main/webapp/libs/bower/moment/js/moment-with-langs.min.js 15a339c 
>   security-admin/src/main/webapp/libs/bower/moment/js/moment-with-locales.min.js PRE-CREATION 
>   security-admin/src/main/webapp/scripts/Init.js 4de6b6d 
>   security-admin/src/main/webapp/scripts/utils/XATemplateHelpers.js b64f911 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js ed83669 
>   security-admin/src/main/webapp/scripts/views/DownloadServicePolicy.js fc8edbb 
>   security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 0a6b16c 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js cb13908 
>   security-admin/src/main/webapp/templates/common/downloadservicepolicy_tmpl.html e608a0f 
>   security-admin/src/main/webapp/templates/helpers/XAHelpers.js e58bece 
> 
> 
> Diff: https://reviews.apache.org/r/66945/diff/1/
> 
> 
> Testing
> -------
> 
> Verified Import Export feature on firefox as well as IE and chrome.
> Also verified Add validaity feature on all 3 browsers. 
> 
> Did sanity testing on Firefox, Chrome and IE 11.
> 
> 
> Thanks,
> 
> Mehul Parikh
> 
>