You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2019/10/22 20:02:04 UTC

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #13: Add JSONLayout class

ams-tschoening commented on issue #13: Add JSONLayout class
URL: https://github.com/apache/logging-log4cxx/pull/13#issuecomment-545129157
 
 
   Thanks for changing things, but I additionally ran into problems getting the new layout to compile in case the WCHAR_T-API is used and your tests failed on my Windows as well. The first problem could easily be changed by using `LOG4CXX_STR` everywhere and the latter by using `LOG4CXX_EOL` instead of `\n`. `HTMLLayout` seemed to have done the same.
   
   Would be great if you could have a look at my newly created branch containing your PR and my additional fixes, if things still work for you.
   
   https://github.com/apache/logging-log4cxx/tree/ghpr_13

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services