You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/08/12 00:03:55 UTC

[GitHub] [beam] ibzib commented on a change in pull request #15321: [GoSDK Infra] Limit simultaneous tests binaries to 3.

ibzib commented on a change in pull request #15321:
URL: https://github.com/apache/beam/pull/15321#discussion_r687272877



##########
File path: sdks/go/test/run_validatesrunner_tests.sh
##########
@@ -79,6 +79,9 @@ RUNNER=portable
 # packages are executed in parallel.
 TIMEOUT=1h
 
+# Default limit on simultaneous test binaries/packages being executed.
+PARALLEL=3

Review comment:
       I saw in the docs that the default is the number of cores, so it should be fine to leave it unset for the Dataflow runner, which doesn't need to do a lot of heavy-duty computation locally. But for Flink I think it should be 1. If nothing else, it makes reading the logs easier -- otherwise the logs for different jobs get interleaved and it becomes very difficult to tell which logs came from which test.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org