You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/07/10 17:27:00 UTC

[jira] [Commented] (IMPALA-9940) Kudu util build is missing dependency on generated protobuf

    [ https://issues.apache.org/jira/browse/IMPALA-9940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17155630#comment-17155630 ] 

ASF subversion and git services commented on IMPALA-9940:
---------------------------------------------------------

Commit dadc3bd61bfb23ad6ef713309b79f9c7bd9b4909 in impala's branch refs/heads/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=dadc3bd ]

IMPALA-9940: add missing kudu protobuf deps

Parts of Impala have transitive dependencies on protobuf
generated headers from the kudu/ subdirectories, e.g.
kudu/util/hash.pb.h. We did not define this dependency
in our CMakeLists, so race conditions are possible that
cause build failures.

This patch fixes the problem by making the gen-deps
target depend on the protobuf-generated code in the
kudu/ subdirectories.

Change-Id: I481d290b424c26da9ec3853d8681c3d6fc34bec6
Reviewed-on: http://gerrit.cloudera.org:8080/16164
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>


> Kudu util build is missing dependency on generated protobuf
> -----------------------------------------------------------
>
>                 Key: IMPALA-9940
>                 URL: https://issues.apache.org/jira/browse/IMPALA-9940
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Infrastructure
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>            Priority: Major
>
> In IMPALA-5078 [~sy117] reported a build issue. We seem to be missing a dependency in kudu util between the generated protos and the .cc files.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org