You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "oscerd (via GitHub)" <gi...@apache.org> on 2026/06/25 11:46:32 UTC
[PR] CAMEL-23464: camel-aws-bedrock - remove unused required modelId option from aws-bedrock-agent [camel]
oscerd opened a new pull request, #24248:
URL: https://github.com/apache/camel/pull/24248
## CAMEL-23464
### Problem
`BedrockAgentConfiguration.modelId` (the `aws-bedrock-agent` component) was declared `@Metadata(required = true)` with a stale enum of three **retired** Anthropic Claude model ids (`anthropic.claude-instant-v1`, `anthropic.claude-v2`, `anthropic.claude-v2:1`).
However **none** of the operations served by `aws-bedrock-agent` read `modelId`:
- Producer: `startIngestionJob`, `listIngestionJobs`, `getIngestionJob`
- Consumer: ingestion-job poll
It was a copy-paste artifact from the sibling `aws-bedrock-agent-runtime` component, where `modelId` is genuinely used (`retrieveAndGenerate` → `modelArn`). Even the dead header constant kept the runtime name: `BedrockAgentConstants.MODEL_ID = "CamelAwsBedrockAgentRuntimeModelId"`.
Forcing users to set a stale, retired, **required** model id for an unrelated ingestion operation was misleading and caused endpoint-validation friction with no functional benefit. The component's own integration tests never set it.
### Fix
Removed the `modelId` artifact from the `aws-bedrock-agent` component:
- `BedrockAgentConfiguration`: dropped the `modelId` field + `getModelId()` / `setModelId()`.
- `BedrockAgentEndpoint`: dropped the `getServiceMetadata()` override (its only entry was `modelId`; it now uses the `EndpointServiceLocation` default) and the now-unused imports.
- `BedrockAgentConstants`: removed the unused `MODEL_ID` header constant.
- Regenerated the component/endpoint configurers, URI factory, component JSON metadata, catalog, and endpoint/component DSL builders.
`aws-bedrock-agent-runtime` and `aws-bedrock` are **unaffected** — `modelId` remains valid and functional there.
### Breaking change
Removing the `modelId` endpoint option is a minor breaking change: routes that previously set `&modelId=...` on an `aws-bedrock-agent` endpoint (a value that had no effect) must remove it. Documented in the 4.21 upgrade guide.
### Tests
Added `BedrockAgentEndpointTest`:
- `ingestionEndpointResolvesWithoutModelId` — the endpoint now resolves cleanly without `modelId`.
- `modelIdOptionIsNoLongerSupported` — supplying `modelId` now fails endpoint resolution instead of being silently accepted.
All `camel-aws-bedrock` unit tests pass (100).
### Docs
Added an entry under the existing `camel-aws-bedrock` section in `camel-4x-upgrade-guide-4_21.adoc`.
---
_Claude Code on behalf of Andrea Cosentino._
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23464: camel-aws-bedrock - remove unused required modelId option from aws-bedrock-agent [camel]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #24248:
URL: https://github.com/apache/camel/pull/24248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23464: camel-aws-bedrock - remove unused required modelId option from aws-bedrock-agent [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24248:
URL: https://github.com/apache/camel/pull/24248#issuecomment-4798865806
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23464: camel-aws-bedrock - remove unused required modelId option from aws-bedrock-agent [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24248:
URL: https://github.com/apache/camel/pull/24248#issuecomment-4799004565
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `catalog/camel-catalog`
- `components/camel-aws/camel-aws-bedrock`
- `docs`
- `dsl/camel-componentdsl`
- `dsl/camel-endpointdsl`
<details><summary>All tested modules (11 modules)</summary>
- Camel :: AWS2 Bedrock
- Camel :: Catalog :: Camel Catalog
- Camel :: Component DSL
- Camel :: Endpoint DSL
- Camel :: JBang :: MCP
- Camel :: JBang :: Plugin :: Route Parser
- Camel :: JBang :: Plugin :: TUI
- Camel :: JBang :: Plugin :: Validate
- Camel :: Launcher :: Container
- Camel :: YAML DSL :: Validator
- Camel :: YAML DSL :: Validator Maven Plugin
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/28167811517)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org