You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "KannarFr (via GitHub)" <gi...@apache.org> on 2023/11/15 14:30:10 UTC

[PR] : [doc][site] split performance in two parts and add sticky reads part. [bookkeeper]

KannarFr opened a new pull request, #4131:
URL: https://github.com/apache/bookkeeper/pull/4131

   Descriptions of the changes in this PR:
   
   
   ### Motivation
   
   After the issue on disabled sticky reads, I'm adding this to improve documentation about performance on reading.
   
   ### Changes
   
   Master Issue: #4130
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Issue #4130: [doc][site] split performance in two parts and add sticky reads part. [bookkeeper]

Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 commented on code in PR #4131:
URL: https://github.com/apache/bookkeeper/pull/4131#discussion_r1398585720


##########
site3/website/docs/admin/bookies.md:
##########
@@ -18,8 +18,14 @@ There is no upper limit on the number of bookies that you can run in a single en
 
 ### Performance
 
+#### Disks
+
 To achieve optimal performance, BookKeeper requires each server to have at least two disks. It's possible to run a bookie with a single disk but performance will be significantly degraded.
 
+#### Sticky reads
+
+BookKeeper sticky reads enables bookie node to read entries efficiently. The sticky reads are only available when ensemble (E) size is equal to quorum write (Qw).

Review Comment:
   LGTM



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Issue #4130: [doc][site] split performance in two parts and add sticky reads part. [bookkeeper]

Posted by "asafm (via GitHub)" <gi...@apache.org>.
asafm commented on code in PR #4131:
URL: https://github.com/apache/bookkeeper/pull/4131#discussion_r1394322143


##########
site3/website/docs/admin/bookies.md:
##########
@@ -18,8 +18,14 @@ There is no upper limit on the number of bookies that you can run in a single en
 
 ### Performance
 
+#### Disks
+
 To achieve optimal performance, BookKeeper requires each server to have at least two disks. It's possible to run a bookie with a single disk but performance will be significantly degraded.
 
+#### Sticky reads
+
+BookKeeper sticky reads enables bookie node to read entries efficiently. The sticky reads are only available when ensemble (E) size is equal to quorum write (Qw).

Review Comment:
   @hangc0276 Can you verify me? You are the expert here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Issue #4130: [doc][site] split performance in two parts and add sticky reads part. [bookkeeper]

Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 merged PR #4131:
URL: https://github.com/apache/bookkeeper/pull/4131


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Issue #4130: [doc][site] split performance in two parts and add sticky reads part. [bookkeeper]

Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 commented on PR #4131:
URL: https://github.com/apache/bookkeeper/pull/4131#issuecomment-1844318913

   @KannarFr Please rebase the master, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Issue #4130: [doc][site] split performance in two parts and add sticky reads part. [bookkeeper]

Posted by "KannarFr (via GitHub)" <gi...@apache.org>.
KannarFr commented on PR #4131:
URL: https://github.com/apache/bookkeeper/pull/4131#issuecomment-1847055315

   @hangc0276 done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org