[spark] branch branch-3.3 updated: [SPARK-37753][FOLLOWUP][SQL] Add comments to unit test

[sr...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

srowen pushed a commit to branch branch-3.3
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.3 by this push:
     new 7adb6e21022 [SPARK-37753][FOLLOWUP][SQL] Add comments to unit test
7adb6e21022 is described below

commit 7adb6e2102232447fde0cea010c2b68a602613b5
Author: mcdull-zhang <wo...@163.com>
AuthorDate: Tue Jun 28 11:55:51 2022 -0500

    [SPARK-37753][FOLLOWUP][SQL] Add comments to unit test
    
    ### What changes were proposed in this pull request?
    add comments to unit test.
    
    ### Why are the changes needed?
    code can be hard to understand without comments
    
    ### Does this PR introduce _any_ user-facing change?
    No
    
    ### How was this patch tested?
    existing test
    
    Closes #37018 from mcdull-zhang/add_reason.
    
    Authored-by: mcdull-zhang <wo...@163.com>
    Signed-off-by: Sean Owen <sr...@gmail.com>
    (cherry picked from commit 9fd010be24fcd6d81e05bd08133fd80ba81b97ac)
    Signed-off-by: Sean Owen <sr...@gmail.com>
---
 .../apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala  | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
index dd727855ce2..d5c933fbc8b 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
@@ -711,6 +711,10 @@ class AdaptiveQueryExecSuite
 
   test("SPARK-37753: Inhibit broadcast in left outer join when there are many empty" +
     " partitions on outer/left side") {
+    // if the right side is completed first and the left side is still being executed,
+    // the right side does not know whether there are many empty partitions on the left side,
+    // so there is no demote, and then the right side is broadcast in the planning stage.
+    // so retry several times here to avoid unit test failure.
     eventually(timeout(15.seconds), interval(500.milliseconds)) {
       withSQLConf(
         SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true",


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org