You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openjpa.apache.org by pc...@apache.org on 2007/04/06 18:08:28 UTC
svn commit: r526212 - in
/incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc:
kernel/JDBCFetchConfigurationImpl.java sql/DBDictionary.java
Author: pcl
Date: Fri Apr 6 09:08:27 2007
New Revision: 526212
URL: http://svn.apache.org/viewvc?view=rev&rev=526212
Log:
OPENJPA-182
Modified:
incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java
Modified: incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
URL: http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java?view=diff&rev=526212&r1=526211&r2=526212
==============================================================================
--- incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java (original)
+++ incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java Fri Apr 6 09:08:27 2007
@@ -327,7 +327,7 @@
}
public JDBCFetchConfiguration setIsolationLevel(int level) {
- if (level != -1
+ if (level != -1 && level != DEFAULT
&& level != Connection.TRANSACTION_NONE
&& level != Connection.TRANSACTION_READ_UNCOMMITTED
&& level != Connection.TRANSACTION_READ_COMMITTED
@@ -335,8 +335,11 @@
&& level != Connection.TRANSACTION_SERIALIZABLE)
throw new IllegalArgumentException(
_loc.get("bad-level", Integer.valueOf(level)).getMessage());
-
- _state.isolationLevel = level;
+
+ if (level == DEFAULT)
+ _state.isolationLevel = -1;
+ else
+ _state.isolationLevel = level;
return this;
}
}
Modified: incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java
URL: http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java?view=diff&rev=526212&r1=526211&r2=526212
==============================================================================
--- incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java (original)
+++ incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java Fri Apr 6 09:08:27 2007
@@ -2205,8 +2205,8 @@
if (forUpdate && !simulateLocking) {
assertSupport(supportsSelectForUpdate, "SupportsSelectForUpdate");
- if (this.forUpdateClause != null)
- buf.append(" ").append(this.forUpdateClause);
+ if (forUpdateClause != null)
+ buf.append(" ").append(forUpdateClause);
}
if (range && rangePosition == RANGE_POST_LOCK)
appendSelectRange(buf, start, end);
Re: svn commit: r526212 - in /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java sql/DBDictionary.java
Posted by Ritika Maheshwari <ri...@gmail.com>.
The patch seems to work fine now.I see FOR READ ONLY clauses
On 4/6/07, Patrick Linskey <pl...@bea.com> wrote:
>
> > Also I wanted to make sure that if you want to turn off the
> > forUpdate flag
> > do u say
> >
> > qry.setHint("openjpa.FetchPlan.ReadLockMode", null)
> >
> > because LockModeType is just READ or WRITE and in both the
> > cases the flag is
> > turned on
>
> I suggest you add a test case to the TestSelectForUpdateOverride class
> and let us know what happens.
>
> You might want to test the hint behavior and also what happens if you
> pass null as a value to the method.
>
> -Patrick
>
> --
> Patrick Linskey
> BEA Systems, Inc.
>
> _______________________________________________________________________
> Notice: This email message, together with any attachments, may contain
> information of BEA Systems, Inc., its subsidiaries and affiliated
> entities, that may be confidential, proprietary, copyrighted and/or
> legally privileged, and is intended solely for the use of the individual
> or entity named in this message. If you are not the intended recipient,
> and have received this message in error, please immediately return this
> by email and then delete it.
>
> > -----Original Message-----
> > From: Ritika Maheshwari [mailto:ritikamster@gmail.com]
> > Sent: Friday, April 06, 2007 10:59 AM
> > To: open-jpa-dev@incubator.apache.org
> > Subject: Re: svn commit: r526212 - in
> > /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache
> > /openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java
> > sql/DBDictionary.java
> >
> > Also I wanted to make sure that if you want to turn off the
> > forUpdate flag
> > do u say
> >
> > qry.setHint("openjpa.FetchPlan.ReadLockMode", null)
> >
> > because LockModeType is just READ or WRITE and in both the
> > cases the flag is
> > turned on
> >
> >
> > On 4/6/07, Ritika Maheshwari <ri...@gmail.com> wrote:
> > >
> > > patch?
> > >
> > > On 4/6/07, Patrick Linskey <pl...@bea.com> wrote:
> > > >
> > > > Gotcha. The attached patch should probably get around
> > that problem; I
> > > > haven't tested it at all though. Let me know what happens in your
> > > > environment.
> > > >
> > > > -Patrick
> > > >
> > > > --
> > > > Patrick Linskey
> > > > BEA Systems, Inc.
> > > >
> > > >
> > ______________________________________________________________
> > _________
> > > > Notice: This email message, together with any
> > attachments, may contain
> > > > information of BEA Systems, Inc., its subsidiaries
> > and affiliated
> > > > entities, that may be confidential, proprietary,
> > copyrighted and/or
> > > > legally privileged, and is intended solely for the use of
> > the individual
> > > >
> > > > or entity named in this message. If you are not the
> > intended recipient,
> > > > and have received this message in error, please
> > immediately return this
> > > > by email and then delete it.
> > > >
> > > > > -----Original Message-----
> > > > > From: Ritika Maheshwari [mailto:ritikamster@gmail.com]
> > > > > Sent: Friday, April 06, 2007 10:27 AM
> > > > > To: open-jpa-dev@incubator.apache.org
> > > > > Subject: Re: svn commit: r526212 - in
> > > > > /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache
> > > > > /openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java
> > > > > sql/DBDictionary.java
> > > > >
> > > > > Patrick,
> > > > > Derby does not support this.And I am running on
> > > > > the most recent
> > > > > code and still seeing same behaviour.Essentially for DB2 you
> > > > > cannot check
> > > > > (forUpdate && !simulateLocking).DB2 will always have a
> > > > > forUpdate clause
> > > > > whether forUpdae is true or false
> > > > >
> > > > >
> > > > > On 4/6/07, Patrick Linskey <pl...@bea.com> wrote:
> > > > > >
> > > > > > Yes -- see my more recent commit. It should resolve
> > this issue.
> > > > > >
> > > > > > Once you guys get some unit tests in place for this,
> > and we have DB2
> > > > > > coverage in our checkin tests, this type of thing
> > shouldn't happen.
> > > > > >
> > > > > > Does Derby provide the same support? IIRC, Derby shares
> > > > > quite a bit of
> > > > > > DB2 syntax; maybe you could change the
> > DerbyDictionary (extends
> > > > > > AbstractDB2Dictionary) to do the same thing, in which case
> > > > > we'll be able
> > > > > > to unit test this stuff without any new database resources.
> > > > > >
> > > > > > -Patrick
> > > > > >
> > > > > > --
> > > > > > Patrick Linskey
> > > > > > BEA Systems, Inc.
> > > > > >
> > > > > >
> > > > > ______________________________________________________________
> > > > > _________
> > > > > > Notice: This email message, together with any attachments,
> > > > > may contain
> > > > > > information of BEA Systems, Inc., its subsidiaries and
> > > > > affiliated
> > > > > > entities, that may be confidential, proprietary,
> > > > > copyrighted and/or
> > > > > > legally privileged, and is intended solely for the use of
> > > > > the individual
> > > > > > or entity named in this message. If you are not the
> > > > > intended recipient,
> > > > > > and have received this message in error, please immediately
> > > > > return this
> > > > > > by email and then delete it.
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Ritika Maheshwari [mailto:ritikamster@gmail.com ]
> > > > > > > Sent: Friday, April 06, 2007 10:14 AM
> > > > > > > To: open-jpa-dev@incubator.apache.org
> > > > > > > Subject: Re: svn commit: r526212 - in
> > > > > > >
> > /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache
> > > > > > > /openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java
> > > > > > > sql/DBDictionary.java
> > > > > > >
> > > > > > > Patrick,
> > > > > > > With your recent changes regarding the
> > > > > > > OPENJPA-182 The logic
> > > > > > > has changed a little.What was intended was that if the
> > > > > > > forUpdate flag = true
> > > > > > > we append the FOR UPDATE CLAUSE.But in case of DB2 if the
> > > > > > > forUpdate flag =
> > > > > > > false then we append FOR READ ONLY clause.Now the FOR READ
> > > > > > > ONLY Clause is
> > > > > > > not getting generated.This is because you moved
> > > > > toOperation back to
> > > > > > > DBDictionary and there you check if (forUpdate &&
> > > > > > > !simulateLocking) then
> > > > > > > append forUpdateClause.Well in this case forUpdate is false
> > > > > > > and we still
> > > > > > > want the forUpdateClause.That was the reason I had
> > overridden the
> > > > > > > toOperation in DB2Dictionary and was just checking
> > > > > > > (!simulateLocking) before
> > > > > > > appending the forUpdate Clause.
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On 4/6/07, pcl@apache.org <pc...@apache.org> wrote:
> > > > > > > >
> > > > > > > > Author: pcl
> > > > > > > > Date: Fri Apr 6 09:08:27 2007
> > > > > > > > New Revision: 526212
> > > > > > > >
> > > > > > > > URL: http://svn.apache.org/viewvc?view=rev&rev=526212
> > > > > > > > Log:
> > > > > > > > OPENJPA-182
> > > > > > > >
> > > > > > > > Modified:
> > > > > > > >
> > > > > > > >
> > > > > > >
> > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > > > >
> > > > > > > >
> > > > > > >
> > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > > > openjpa/jdbc/sql/DBDictionary.java
> > > > > > > >
> > > > > > > > Modified:
> > > > > > > >
> > > > > > >
> > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > > > > URL:
> > > > > > > >
> > > > > > >
> > http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-j
> > > > > >
> > > > > dbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConf
> > > > > igurationI
> > > > > > mpl.java?> view=diff&rev=526212&r1=526211&r2=526212
> > > > > > > >
> > > > > > > >
> > > > > > >
> > ==============================================================
> > > > > > > ================
> > > > > > > > ---
> > > > > > > >
> > > > > > >
> > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > > > > (original)
> > > > > > > > +++
> > > > > > > >
> > > > > > >
> > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > > > > Fri Apr 6 09:08:27 2007
> > > > > > > > @@ -327,7 +327,7 @@
> > > > > > > > }
> > > > > > > >
> > > > > > > > public JDBCFetchConfiguration
> > setIsolationLevel(int level) {
> > > >
> > > > > > > > - if (level != -1
> > > > > > > > + if (level != -1 && level != DEFAULT
> > > > > > > > && level != Connection.TRANSACTION_NONE
> > > > > > > > && level !=
> > Connection.TRANSACTION_READ_UNCOMMITTED
> > > > > > > > && level !=
> > Connection.TRANSACTION_READ_COMMITTED
> > > > > > > > @@ -335,8 +335,11 @@
> > > > > > > > && level !=
> > Connection.TRANSACTION_SERIALIZABLE)
> > > > > > > > throw new IllegalArgumentException(
> > > > > > > > _loc.get("bad-level", Integer.valueOf
> > > > > > > > (level)).getMessage());
> > > > > > > > -
> > > > > > > > - _state.isolationLevel = level;
> > > > > > > > +
> > > > > > > > + if (level == DEFAULT)
> > > > > > > > + _state.isolationLevel = -1;
> > > > > > > > + else
> > > > > > > > + _state.isolationLevel = level;
> > > > > > > > return this;
> > > > > > > > }
> > > > > > > > }
> > > > > > > >
> > > > > > > > Modified:
> > > > > > > >
> > > > > > >
> > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > > > openjpa/jdbc/sql/DBDictionary.java
> > > > > > > > URL:
> > > > > > > >
> > > > > > >
> > http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-j
> > > > > >
> > > > > dbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.jav
> > > > > a?view=dif
> > > > > > f&rev=526212&r1=> 526211&r2=526212
> > > > > > > >
> > > > > > > >
> > > > > > >
> > ==============================================================
> > > > > > > ================
> > > > > > > > ---
> > > > > > > >
> > > > > > >
> > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > > > openjpa/jdbc/sql/DBDictionary.java
> > > > > > > > (original)
> > > > > > > > +++
> > > > > > > >
> > > > > > >
> > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > > > openjpa/jdbc/sql/DBDictionary.java
> > > > > > > > Fri Apr 6 09:08:27 2007
> > > > > > > > @@ -2205,8 +2205,8 @@
> > > > > > > >
> > > > > > > > if (forUpdate && !simulateLocking) {
> > > > > > > > assertSupport(supportsSelectForUpdate,
> > > > > > > > "SupportsSelectForUpdate");
> > > > > > > > - if (this.forUpdateClause != null)
> > > > > > > > - buf.append("
> > ").append(this.forUpdateClause);
> > > > > > > > + if (forUpdateClause != null)
> > > > > > > > + buf.append(" ").append(forUpdateClause);
> > > > > > > > }
> > > > > > > > if (range && rangePosition == RANGE_POST_LOCK)
> > > > > > > > appendSelectRange(buf, start, end);
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > > Notice: This email message, together with any attachments,
> > > > > may contain
> > > > > > information of BEA Systems, Inc., its subsidiaries and
> > > > > affiliated
> > > > > > entities, that may be confidential, proprietary,
> > > > > copyrighted and/or
> > > > > > legally privileged, and is intended solely for the use of
> > > > > the individual or
> > > > > > entity named in this message. If you are not the intended
> > > > > recipient, and
> > > > > > have received this message in error, please immediately
> > > > > return this by email
> > > > > > and then delete it.
> > > > > >
> > > > >
> > > >
> > > > Notice: This email message, together with any
> > attachments, may contain
> > > > information of BEA Systems, Inc., its subsidiaries
> > and affiliated
> > > > entities, that may be confidential, proprietary,
> > copyrighted and/or
> > > > legally privileged, and is intended solely for the use of
> > the individual or
> > > > entity named in this message. If you are not the intended
> > recipient, and
> > > > have received this message in error, please immediately
> > return this by email
> > > > and then delete it.
> > >
> > >
> > >
> >
>
> Notice: This email message, together with any attachments, may contain
> information of BEA Systems, Inc., its subsidiaries and affiliated
> entities, that may be confidential, proprietary, copyrighted and/or
> legally privileged, and is intended solely for the use of the individual or
> entity named in this message. If you are not the intended recipient, and
> have received this message in error, please immediately return this by email
> and then delete it.
>
RE: svn commit: r526212 - in /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java sql/DBDictionary.java
Posted by Patrick Linskey <pl...@bea.com>.
> Also I wanted to make sure that if you want to turn off the
> forUpdate flag
> do u say
>
> qry.setHint("openjpa.FetchPlan.ReadLockMode", null)
>
> because LockModeType is just READ or WRITE and in both the
> cases the flag is
> turned on
I suggest you add a test case to the TestSelectForUpdateOverride class
and let us know what happens.
You might want to test the hint behavior and also what happens if you
pass null as a value to the method.
-Patrick
--
Patrick Linskey
BEA Systems, Inc.
_______________________________________________________________________
Notice: This email message, together with any attachments, may contain
information of BEA Systems, Inc., its subsidiaries and affiliated
entities, that may be confidential, proprietary, copyrighted and/or
legally privileged, and is intended solely for the use of the individual
or entity named in this message. If you are not the intended recipient,
and have received this message in error, please immediately return this
by email and then delete it.
> -----Original Message-----
> From: Ritika Maheshwari [mailto:ritikamster@gmail.com]
> Sent: Friday, April 06, 2007 10:59 AM
> To: open-jpa-dev@incubator.apache.org
> Subject: Re: svn commit: r526212 - in
> /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache
> /openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java
> sql/DBDictionary.java
>
> Also I wanted to make sure that if you want to turn off the
> forUpdate flag
> do u say
>
> qry.setHint("openjpa.FetchPlan.ReadLockMode", null)
>
> because LockModeType is just READ or WRITE and in both the
> cases the flag is
> turned on
>
>
> On 4/6/07, Ritika Maheshwari <ri...@gmail.com> wrote:
> >
> > patch?
> >
> > On 4/6/07, Patrick Linskey <pl...@bea.com> wrote:
> > >
> > > Gotcha. The attached patch should probably get around
> that problem; I
> > > haven't tested it at all though. Let me know what happens in your
> > > environment.
> > >
> > > -Patrick
> > >
> > > --
> > > Patrick Linskey
> > > BEA Systems, Inc.
> > >
> > >
> ______________________________________________________________
> _________
> > > Notice: This email message, together with any
> attachments, may contain
> > > information of BEA Systems, Inc., its subsidiaries
> and affiliated
> > > entities, that may be confidential, proprietary,
> copyrighted and/or
> > > legally privileged, and is intended solely for the use of
> the individual
> > >
> > > or entity named in this message. If you are not the
> intended recipient,
> > > and have received this message in error, please
> immediately return this
> > > by email and then delete it.
> > >
> > > > -----Original Message-----
> > > > From: Ritika Maheshwari [mailto:ritikamster@gmail.com]
> > > > Sent: Friday, April 06, 2007 10:27 AM
> > > > To: open-jpa-dev@incubator.apache.org
> > > > Subject: Re: svn commit: r526212 - in
> > > > /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache
> > > > /openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java
> > > > sql/DBDictionary.java
> > > >
> > > > Patrick,
> > > > Derby does not support this.And I am running on
> > > > the most recent
> > > > code and still seeing same behaviour.Essentially for DB2 you
> > > > cannot check
> > > > (forUpdate && !simulateLocking).DB2 will always have a
> > > > forUpdate clause
> > > > whether forUpdae is true or false
> > > >
> > > >
> > > > On 4/6/07, Patrick Linskey <pl...@bea.com> wrote:
> > > > >
> > > > > Yes -- see my more recent commit. It should resolve
> this issue.
> > > > >
> > > > > Once you guys get some unit tests in place for this,
> and we have DB2
> > > > > coverage in our checkin tests, this type of thing
> shouldn't happen.
> > > > >
> > > > > Does Derby provide the same support? IIRC, Derby shares
> > > > quite a bit of
> > > > > DB2 syntax; maybe you could change the
> DerbyDictionary (extends
> > > > > AbstractDB2Dictionary) to do the same thing, in which case
> > > > we'll be able
> > > > > to unit test this stuff without any new database resources.
> > > > >
> > > > > -Patrick
> > > > >
> > > > > --
> > > > > Patrick Linskey
> > > > > BEA Systems, Inc.
> > > > >
> > > > >
> > > > ______________________________________________________________
> > > > _________
> > > > > Notice: This email message, together with any attachments,
> > > > may contain
> > > > > information of BEA Systems, Inc., its subsidiaries and
> > > > affiliated
> > > > > entities, that may be confidential, proprietary,
> > > > copyrighted and/or
> > > > > legally privileged, and is intended solely for the use of
> > > > the individual
> > > > > or entity named in this message. If you are not the
> > > > intended recipient,
> > > > > and have received this message in error, please immediately
> > > > return this
> > > > > by email and then delete it.
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Ritika Maheshwari [mailto:ritikamster@gmail.com ]
> > > > > > Sent: Friday, April 06, 2007 10:14 AM
> > > > > > To: open-jpa-dev@incubator.apache.org
> > > > > > Subject: Re: svn commit: r526212 - in
> > > > > >
> /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache
> > > > > > /openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java
> > > > > > sql/DBDictionary.java
> > > > > >
> > > > > > Patrick,
> > > > > > With your recent changes regarding the
> > > > > > OPENJPA-182 The logic
> > > > > > has changed a little.What was intended was that if the
> > > > > > forUpdate flag = true
> > > > > > we append the FOR UPDATE CLAUSE.But in case of DB2 if the
> > > > > > forUpdate flag =
> > > > > > false then we append FOR READ ONLY clause.Now the FOR READ
> > > > > > ONLY Clause is
> > > > > > not getting generated.This is because you moved
> > > > toOperation back to
> > > > > > DBDictionary and there you check if (forUpdate &&
> > > > > > !simulateLocking) then
> > > > > > append forUpdateClause.Well in this case forUpdate is false
> > > > > > and we still
> > > > > > want the forUpdateClause.That was the reason I had
> overridden the
> > > > > > toOperation in DB2Dictionary and was just checking
> > > > > > (!simulateLocking) before
> > > > > > appending the forUpdate Clause.
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > On 4/6/07, pcl@apache.org <pc...@apache.org> wrote:
> > > > > > >
> > > > > > > Author: pcl
> > > > > > > Date: Fri Apr 6 09:08:27 2007
> > > > > > > New Revision: 526212
> > > > > > >
> > > > > > > URL: http://svn.apache.org/viewvc?view=rev&rev=526212
> > > > > > > Log:
> > > > > > > OPENJPA-182
> > > > > > >
> > > > > > > Modified:
> > > > > > >
> > > > > > >
> > > > > >
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > > >
> > > > > > >
> > > > > >
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > > openjpa/jdbc/sql/DBDictionary.java
> > > > > > >
> > > > > > > Modified:
> > > > > > >
> > > > > >
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > > > URL:
> > > > > > >
> > > > > >
> http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-j
> > > > >
> > > > dbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConf
> > > > igurationI
> > > > > mpl.java?> view=diff&rev=526212&r1=526211&r2=526212
> > > > > > >
> > > > > > >
> > > > > >
> ==============================================================
> > > > > > ================
> > > > > > > ---
> > > > > > >
> > > > > >
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > > > (original)
> > > > > > > +++
> > > > > > >
> > > > > >
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > > > Fri Apr 6 09:08:27 2007
> > > > > > > @@ -327,7 +327,7 @@
> > > > > > > }
> > > > > > >
> > > > > > > public JDBCFetchConfiguration
> setIsolationLevel(int level) {
> > >
> > > > > > > - if (level != -1
> > > > > > > + if (level != -1 && level != DEFAULT
> > > > > > > && level != Connection.TRANSACTION_NONE
> > > > > > > && level !=
> Connection.TRANSACTION_READ_UNCOMMITTED
> > > > > > > && level !=
> Connection.TRANSACTION_READ_COMMITTED
> > > > > > > @@ -335,8 +335,11 @@
> > > > > > > && level !=
> Connection.TRANSACTION_SERIALIZABLE)
> > > > > > > throw new IllegalArgumentException(
> > > > > > > _loc.get("bad-level", Integer.valueOf
> > > > > > > (level)).getMessage());
> > > > > > > -
> > > > > > > - _state.isolationLevel = level;
> > > > > > > +
> > > > > > > + if (level == DEFAULT)
> > > > > > > + _state.isolationLevel = -1;
> > > > > > > + else
> > > > > > > + _state.isolationLevel = level;
> > > > > > > return this;
> > > > > > > }
> > > > > > > }
> > > > > > >
> > > > > > > Modified:
> > > > > > >
> > > > > >
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > > openjpa/jdbc/sql/DBDictionary.java
> > > > > > > URL:
> > > > > > >
> > > > > >
> http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-j
> > > > >
> > > > dbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.jav
> > > > a?view=dif
> > > > > f&rev=526212&r1=> 526211&r2=526212
> > > > > > >
> > > > > > >
> > > > > >
> ==============================================================
> > > > > > ================
> > > > > > > ---
> > > > > > >
> > > > > >
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > > openjpa/jdbc/sql/DBDictionary.java
> > > > > > > (original)
> > > > > > > +++
> > > > > > >
> > > > > >
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > > openjpa/jdbc/sql/DBDictionary.java
> > > > > > > Fri Apr 6 09:08:27 2007
> > > > > > > @@ -2205,8 +2205,8 @@
> > > > > > >
> > > > > > > if (forUpdate && !simulateLocking) {
> > > > > > > assertSupport(supportsSelectForUpdate,
> > > > > > > "SupportsSelectForUpdate");
> > > > > > > - if (this.forUpdateClause != null)
> > > > > > > - buf.append("
> ").append(this.forUpdateClause);
> > > > > > > + if (forUpdateClause != null)
> > > > > > > + buf.append(" ").append(forUpdateClause);
> > > > > > > }
> > > > > > > if (range && rangePosition == RANGE_POST_LOCK)
> > > > > > > appendSelectRange(buf, start, end);
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > > > Notice: This email message, together with any attachments,
> > > > may contain
> > > > > information of BEA Systems, Inc., its subsidiaries and
> > > > affiliated
> > > > > entities, that may be confidential, proprietary,
> > > > copyrighted and/or
> > > > > legally privileged, and is intended solely for the use of
> > > > the individual or
> > > > > entity named in this message. If you are not the intended
> > > > recipient, and
> > > > > have received this message in error, please immediately
> > > > return this by email
> > > > > and then delete it.
> > > > >
> > > >
> > >
> > > Notice: This email message, together with any
> attachments, may contain
> > > information of BEA Systems, Inc., its subsidiaries
> and affiliated
> > > entities, that may be confidential, proprietary,
> copyrighted and/or
> > > legally privileged, and is intended solely for the use of
> the individual or
> > > entity named in this message. If you are not the intended
> recipient, and
> > > have received this message in error, please immediately
> return this by email
> > > and then delete it.
> >
> >
> >
>
Notice: This email message, together with any attachments, may contain information of BEA Systems, Inc., its subsidiaries and affiliated entities, that may be confidential, proprietary, copyrighted and/or legally privileged, and is intended solely for the use of the individual or entity named in this message. If you are not the intended recipient, and have received this message in error, please immediately return this by email and then delete it.
Re: svn commit: r526212 - in /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java sql/DBDictionary.java
Posted by Ritika Maheshwari <ri...@gmail.com>.
Also I wanted to make sure that if you want to turn off the forUpdate flag
do u say
qry.setHint("openjpa.FetchPlan.ReadLockMode", null)
because LockModeType is just READ or WRITE and in both the cases the flag is
turned on
On 4/6/07, Ritika Maheshwari <ri...@gmail.com> wrote:
>
> patch?
>
> On 4/6/07, Patrick Linskey <pl...@bea.com> wrote:
> >
> > Gotcha. The attached patch should probably get around that problem; I
> > haven't tested it at all though. Let me know what happens in your
> > environment.
> >
> > -Patrick
> >
> > --
> > Patrick Linskey
> > BEA Systems, Inc.
> >
> > _______________________________________________________________________
> > Notice: This email message, together with any attachments, may contain
> > information of BEA Systems, Inc., its subsidiaries and affiliated
> > entities, that may be confidential, proprietary, copyrighted and/or
> > legally privileged, and is intended solely for the use of the individual
> >
> > or entity named in this message. If you are not the intended recipient,
> > and have received this message in error, please immediately return this
> > by email and then delete it.
> >
> > > -----Original Message-----
> > > From: Ritika Maheshwari [mailto:ritikamster@gmail.com]
> > > Sent: Friday, April 06, 2007 10:27 AM
> > > To: open-jpa-dev@incubator.apache.org
> > > Subject: Re: svn commit: r526212 - in
> > > /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache
> > > /openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java
> > > sql/DBDictionary.java
> > >
> > > Patrick,
> > > Derby does not support this.And I am running on
> > > the most recent
> > > code and still seeing same behaviour.Essentially for DB2 you
> > > cannot check
> > > (forUpdate && !simulateLocking).DB2 will always have a
> > > forUpdate clause
> > > whether forUpdae is true or false
> > >
> > >
> > > On 4/6/07, Patrick Linskey <pl...@bea.com> wrote:
> > > >
> > > > Yes -- see my more recent commit. It should resolve this issue.
> > > >
> > > > Once you guys get some unit tests in place for this, and we have DB2
> > > > coverage in our checkin tests, this type of thing shouldn't happen.
> > > >
> > > > Does Derby provide the same support? IIRC, Derby shares
> > > quite a bit of
> > > > DB2 syntax; maybe you could change the DerbyDictionary (extends
> > > > AbstractDB2Dictionary) to do the same thing, in which case
> > > we'll be able
> > > > to unit test this stuff without any new database resources.
> > > >
> > > > -Patrick
> > > >
> > > > --
> > > > Patrick Linskey
> > > > BEA Systems, Inc.
> > > >
> > > >
> > > ______________________________________________________________
> > > _________
> > > > Notice: This email message, together with any attachments,
> > > may contain
> > > > information of BEA Systems, Inc., its subsidiaries and
> > > affiliated
> > > > entities, that may be confidential, proprietary,
> > > copyrighted and/or
> > > > legally privileged, and is intended solely for the use of
> > > the individual
> > > > or entity named in this message. If you are not the
> > > intended recipient,
> > > > and have received this message in error, please immediately
> > > return this
> > > > by email and then delete it.
> > > >
> > > > > -----Original Message-----
> > > > > From: Ritika Maheshwari [mailto:ritikamster@gmail.com ]
> > > > > Sent: Friday, April 06, 2007 10:14 AM
> > > > > To: open-jpa-dev@incubator.apache.org
> > > > > Subject: Re: svn commit: r526212 - in
> > > > > /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache
> > > > > /openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java
> > > > > sql/DBDictionary.java
> > > > >
> > > > > Patrick,
> > > > > With your recent changes regarding the
> > > > > OPENJPA-182 The logic
> > > > > has changed a little.What was intended was that if the
> > > > > forUpdate flag = true
> > > > > we append the FOR UPDATE CLAUSE.But in case of DB2 if the
> > > > > forUpdate flag =
> > > > > false then we append FOR READ ONLY clause.Now the FOR READ
> > > > > ONLY Clause is
> > > > > not getting generated.This is because you moved
> > > toOperation back to
> > > > > DBDictionary and there you check if (forUpdate &&
> > > > > !simulateLocking) then
> > > > > append forUpdateClause.Well in this case forUpdate is false
> > > > > and we still
> > > > > want the forUpdateClause.That was the reason I had overridden the
> > > > > toOperation in DB2Dictionary and was just checking
> > > > > (!simulateLocking) before
> > > > > appending the forUpdate Clause.
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > On 4/6/07, pcl@apache.org <pc...@apache.org> wrote:
> > > > > >
> > > > > > Author: pcl
> > > > > > Date: Fri Apr 6 09:08:27 2007
> > > > > > New Revision: 526212
> > > > > >
> > > > > > URL: http://svn.apache.org/viewvc?view=rev&rev=526212
> > > > > > Log:
> > > > > > OPENJPA-182
> > > > > >
> > > > > > Modified:
> > > > > >
> > > > > >
> > > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > >
> > > > > >
> > > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > openjpa/jdbc/sql/DBDictionary.java
> > > > > >
> > > > > > Modified:
> > > > > >
> > > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > > URL:
> > > > > >
> > > > > http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-j
> > > >
> > > dbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConf
> > > igurationI
> > > > mpl.java?> view=diff&rev=526212&r1=526211&r2=526212
> > > > > >
> > > > > >
> > > > > ==============================================================
> > > > > ================
> > > > > > ---
> > > > > >
> > > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > > (original)
> > > > > > +++
> > > > > >
> > > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > > Fri Apr 6 09:08:27 2007
> > > > > > @@ -327,7 +327,7 @@
> > > > > > }
> > > > > >
> > > > > > public JDBCFetchConfiguration setIsolationLevel(int level) {
> >
> > > > > > - if (level != -1
> > > > > > + if (level != -1 && level != DEFAULT
> > > > > > && level != Connection.TRANSACTION_NONE
> > > > > > && level != Connection.TRANSACTION_READ_UNCOMMITTED
> > > > > > && level != Connection.TRANSACTION_READ_COMMITTED
> > > > > > @@ -335,8 +335,11 @@
> > > > > > && level != Connection.TRANSACTION_SERIALIZABLE)
> > > > > > throw new IllegalArgumentException(
> > > > > > _loc.get("bad-level", Integer.valueOf
> > > > > > (level)).getMessage());
> > > > > > -
> > > > > > - _state.isolationLevel = level;
> > > > > > +
> > > > > > + if (level == DEFAULT)
> > > > > > + _state.isolationLevel = -1;
> > > > > > + else
> > > > > > + _state.isolationLevel = level;
> > > > > > return this;
> > > > > > }
> > > > > > }
> > > > > >
> > > > > > Modified:
> > > > > >
> > > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > openjpa/jdbc/sql/DBDictionary.java
> > > > > > URL:
> > > > > >
> > > > > http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-j
> > > >
> > > dbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.jav
> > > a?view=dif
> > > > f&rev=526212&r1=> 526211&r2=526212
> > > > > >
> > > > > >
> > > > > ==============================================================
> > > > > ================
> > > > > > ---
> > > > > >
> > > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > openjpa/jdbc/sql/DBDictionary.java
> > > > > > (original)
> > > > > > +++
> > > > > >
> > > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > openjpa/jdbc/sql/DBDictionary.java
> > > > > > Fri Apr 6 09:08:27 2007
> > > > > > @@ -2205,8 +2205,8 @@
> > > > > >
> > > > > > if (forUpdate && !simulateLocking) {
> > > > > > assertSupport(supportsSelectForUpdate,
> > > > > > "SupportsSelectForUpdate");
> > > > > > - if (this.forUpdateClause != null)
> > > > > > - buf.append(" ").append(this.forUpdateClause);
> > > > > > + if (forUpdateClause != null)
> > > > > > + buf.append(" ").append(forUpdateClause);
> > > > > > }
> > > > > > if (range && rangePosition == RANGE_POST_LOCK)
> > > > > > appendSelectRange(buf, start, end);
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > > > Notice: This email message, together with any attachments,
> > > may contain
> > > > information of BEA Systems, Inc., its subsidiaries and
> > > affiliated
> > > > entities, that may be confidential, proprietary,
> > > copyrighted and/or
> > > > legally privileged, and is intended solely for the use of
> > > the individual or
> > > > entity named in this message. If you are not the intended
> > > recipient, and
> > > > have received this message in error, please immediately
> > > return this by email
> > > > and then delete it.
> > > >
> > >
> >
> > Notice: This email message, together with any attachments, may contain
> > information of BEA Systems, Inc., its subsidiaries and affiliated
> > entities, that may be confidential, proprietary, copyrighted and/or
> > legally privileged, and is intended solely for the use of the individual or
> > entity named in this message. If you are not the intended recipient, and
> > have received this message in error, please immediately return this by email
> > and then delete it.
>
>
>
Re: svn commit: r526212 - in /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java sql/DBDictionary.java
Posted by Ritika Maheshwari <ri...@gmail.com>.
patch?
On 4/6/07, Patrick Linskey <pl...@bea.com> wrote:
>
> Gotcha. The attached patch should probably get around that problem; I
> haven't tested it at all though. Let me know what happens in your
> environment.
>
> -Patrick
>
> --
> Patrick Linskey
> BEA Systems, Inc.
>
> _______________________________________________________________________
> Notice: This email message, together with any attachments, may contain
> information of BEA Systems, Inc., its subsidiaries and affiliated
> entities, that may be confidential, proprietary, copyrighted and/or
> legally privileged, and is intended solely for the use of the individual
> or entity named in this message. If you are not the intended recipient,
> and have received this message in error, please immediately return this
> by email and then delete it.
>
> > -----Original Message-----
> > From: Ritika Maheshwari [mailto:ritikamster@gmail.com]
> > Sent: Friday, April 06, 2007 10:27 AM
> > To: open-jpa-dev@incubator.apache.org
> > Subject: Re: svn commit: r526212 - in
> > /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache
> > /openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java
> > sql/DBDictionary.java
> >
> > Patrick,
> > Derby does not support this.And I am running on
> > the most recent
> > code and still seeing same behaviour.Essentially for DB2 you
> > cannot check
> > (forUpdate && !simulateLocking).DB2 will always have a
> > forUpdate clause
> > whether forUpdae is true or false
> >
> >
> > On 4/6/07, Patrick Linskey <pl...@bea.com> wrote:
> > >
> > > Yes -- see my more recent commit. It should resolve this issue.
> > >
> > > Once you guys get some unit tests in place for this, and we have DB2
> > > coverage in our checkin tests, this type of thing shouldn't happen.
> > >
> > > Does Derby provide the same support? IIRC, Derby shares
> > quite a bit of
> > > DB2 syntax; maybe you could change the DerbyDictionary (extends
> > > AbstractDB2Dictionary) to do the same thing, in which case
> > we'll be able
> > > to unit test this stuff without any new database resources.
> > >
> > > -Patrick
> > >
> > > --
> > > Patrick Linskey
> > > BEA Systems, Inc.
> > >
> > >
> > ______________________________________________________________
> > _________
> > > Notice: This email message, together with any attachments,
> > may contain
> > > information of BEA Systems, Inc., its subsidiaries and
> > affiliated
> > > entities, that may be confidential, proprietary,
> > copyrighted and/or
> > > legally privileged, and is intended solely for the use of
> > the individual
> > > or entity named in this message. If you are not the
> > intended recipient,
> > > and have received this message in error, please immediately
> > return this
> > > by email and then delete it.
> > >
> > > > -----Original Message-----
> > > > From: Ritika Maheshwari [mailto:ritikamster@gmail.com]
> > > > Sent: Friday, April 06, 2007 10:14 AM
> > > > To: open-jpa-dev@incubator.apache.org
> > > > Subject: Re: svn commit: r526212 - in
> > > > /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache
> > > > /openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java
> > > > sql/DBDictionary.java
> > > >
> > > > Patrick,
> > > > With your recent changes regarding the
> > > > OPENJPA-182 The logic
> > > > has changed a little.What was intended was that if the
> > > > forUpdate flag = true
> > > > we append the FOR UPDATE CLAUSE.But in case of DB2 if the
> > > > forUpdate flag =
> > > > false then we append FOR READ ONLY clause.Now the FOR READ
> > > > ONLY Clause is
> > > > not getting generated.This is because you moved
> > toOperation back to
> > > > DBDictionary and there you check if (forUpdate &&
> > > > !simulateLocking) then
> > > > append forUpdateClause.Well in this case forUpdate is false
> > > > and we still
> > > > want the forUpdateClause.That was the reason I had overridden the
> > > > toOperation in DB2Dictionary and was just checking
> > > > (!simulateLocking) before
> > > > appending the forUpdate Clause.
> > > >
> > > >
> > > >
> > > >
> > > > On 4/6/07, pcl@apache.org <pc...@apache.org> wrote:
> > > > >
> > > > > Author: pcl
> > > > > Date: Fri Apr 6 09:08:27 2007
> > > > > New Revision: 526212
> > > > >
> > > > > URL: http://svn.apache.org/viewvc?view=rev&rev=526212
> > > > > Log:
> > > > > OPENJPA-182
> > > > >
> > > > > Modified:
> > > > >
> > > > >
> > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > >
> > > > >
> > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > openjpa/jdbc/sql/DBDictionary.java
> > > > >
> > > > > Modified:
> > > > >
> > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > URL:
> > > > >
> > > > http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-j
> > >
> > dbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConf
> > igurationI
> > > mpl.java?> view=diff&rev=526212&r1=526211&r2=526212
> > > > >
> > > > >
> > > > ==============================================================
> > > > ================
> > > > > ---
> > > > >
> > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > (original)
> > > > > +++
> > > > >
> > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > Fri Apr 6 09:08:27 2007
> > > > > @@ -327,7 +327,7 @@
> > > > > }
> > > > >
> > > > > public JDBCFetchConfiguration setIsolationLevel(int level) {
> > > > > - if (level != -1
> > > > > + if (level != -1 && level != DEFAULT
> > > > > && level != Connection.TRANSACTION_NONE
> > > > > && level != Connection.TRANSACTION_READ_UNCOMMITTED
> > > > > && level != Connection.TRANSACTION_READ_COMMITTED
> > > > > @@ -335,8 +335,11 @@
> > > > > && level != Connection.TRANSACTION_SERIALIZABLE)
> > > > > throw new IllegalArgumentException(
> > > > > _loc.get("bad-level", Integer.valueOf
> > > > > (level)).getMessage());
> > > > > -
> > > > > - _state.isolationLevel = level;
> > > > > +
> > > > > + if (level == DEFAULT)
> > > > > + _state.isolationLevel = -1;
> > > > > + else
> > > > > + _state.isolationLevel = level;
> > > > > return this;
> > > > > }
> > > > > }
> > > > >
> > > > > Modified:
> > > > >
> > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > openjpa/jdbc/sql/DBDictionary.java
> > > > > URL:
> > > > >
> > > > http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-j
> > >
> > dbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.jav
> > a?view=dif
> > > f&rev=526212&r1=> 526211&r2=526212
> > > > >
> > > > >
> > > > ==============================================================
> > > > ================
> > > > > ---
> > > > >
> > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > openjpa/jdbc/sql/DBDictionary.java
> > > > > (original)
> > > > > +++
> > > > >
> > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > openjpa/jdbc/sql/DBDictionary.java
> > > > > Fri Apr 6 09:08:27 2007
> > > > > @@ -2205,8 +2205,8 @@
> > > > >
> > > > > if (forUpdate && !simulateLocking) {
> > > > > assertSupport(supportsSelectForUpdate,
> > > > > "SupportsSelectForUpdate");
> > > > > - if (this.forUpdateClause != null)
> > > > > - buf.append(" ").append(this.forUpdateClause);
> > > > > + if (forUpdateClause != null)
> > > > > + buf.append(" ").append(forUpdateClause);
> > > > > }
> > > > > if (range && rangePosition == RANGE_POST_LOCK)
> > > > > appendSelectRange(buf, start, end);
> > > > >
> > > > >
> > > > >
> > > >
> > >
> > > Notice: This email message, together with any attachments,
> > may contain
> > > information of BEA Systems, Inc., its subsidiaries and
> > affiliated
> > > entities, that may be confidential, proprietary,
> > copyrighted and/or
> > > legally privileged, and is intended solely for the use of
> > the individual or
> > > entity named in this message. If you are not the intended
> > recipient, and
> > > have received this message in error, please immediately
> > return this by email
> > > and then delete it.
> > >
> >
>
> Notice: This email message, together with any attachments, may contain
> information of BEA Systems, Inc., its subsidiaries and affiliated
> entities, that may be confidential, proprietary, copyrighted and/or
> legally privileged, and is intended solely for the use of the individual or
> entity named in this message. If you are not the intended recipient, and
> have received this message in error, please immediately return this by email
> and then delete it.
RE: svn commit: r526212 - in /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java sql/DBDictionary.java
Posted by Patrick Linskey <pl...@bea.com>.
Hmm... that's odd. I just attached it to the JIRA issue.
-Patrick
--
Patrick Linskey
BEA Systems, Inc.
_______________________________________________________________________
Notice: This email message, together with any attachments, may contain
information of BEA Systems, Inc., its subsidiaries and affiliated
entities, that may be confidential, proprietary, copyrighted and/or
legally privileged, and is intended solely for the use of the individual
or entity named in this message. If you are not the intended recipient,
and have received this message in error, please immediately return this
by email and then delete it.
> -----Original Message-----
> From: Ritika Maheshwari [mailto:ritikamster@gmail.com]
> Sent: Friday, April 06, 2007 11:13 AM
> To: open-jpa-dev@incubator.apache.org
> Subject: Re: svn commit: r526212 - in
> /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache
> /openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java
> sql/DBDictionary.java
>
> Patrick
> I didn't get the patch
>
>
> On 4/6/07, Patrick Linskey <pl...@bea.com> wrote:
> >
> > Gotcha. The attached patch should probably get around that
> problem; I
> > haven't tested it at all though. Let me know what happens in your
> > environment.
> >
> > -Patrick
> >
> > --
> > Patrick Linskey
> > BEA Systems, Inc.
> >
> >
> ______________________________________________________________
> _________
> > Notice: This email message, together with any attachments,
> may contain
> > information of BEA Systems, Inc., its subsidiaries and
> affiliated
> > entities, that may be confidential, proprietary,
> copyrighted and/or
> > legally privileged, and is intended solely for the use of
> the individual
> > or entity named in this message. If you are not the
> intended recipient,
> > and have received this message in error, please immediately
> return this
> > by email and then delete it.
> >
> > > -----Original Message-----
> > > From: Ritika Maheshwari [mailto:ritikamster@gmail.com]
> > > Sent: Friday, April 06, 2007 10:27 AM
> > > To: open-jpa-dev@incubator.apache.org
> > > Subject: Re: svn commit: r526212 - in
> > > /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache
> > > /openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java
> > > sql/DBDictionary.java
> > >
> > > Patrick,
> > > Derby does not support this.And I am running on
> > > the most recent
> > > code and still seeing same behaviour.Essentially for DB2 you
> > > cannot check
> > > (forUpdate && !simulateLocking).DB2 will always have a
> > > forUpdate clause
> > > whether forUpdae is true or false
> > >
> > >
> > > On 4/6/07, Patrick Linskey <pl...@bea.com> wrote:
> > > >
> > > > Yes -- see my more recent commit. It should resolve this issue.
> > > >
> > > > Once you guys get some unit tests in place for this,
> and we have DB2
> > > > coverage in our checkin tests, this type of thing
> shouldn't happen.
> > > >
> > > > Does Derby provide the same support? IIRC, Derby shares
> > > quite a bit of
> > > > DB2 syntax; maybe you could change the DerbyDictionary (extends
> > > > AbstractDB2Dictionary) to do the same thing, in which case
> > > we'll be able
> > > > to unit test this stuff without any new database resources.
> > > >
> > > > -Patrick
> > > >
> > > > --
> > > > Patrick Linskey
> > > > BEA Systems, Inc.
> > > >
> > > >
> > > ______________________________________________________________
> > > _________
> > > > Notice: This email message, together with any attachments,
> > > may contain
> > > > information of BEA Systems, Inc., its subsidiaries and
> > > affiliated
> > > > entities, that may be confidential, proprietary,
> > > copyrighted and/or
> > > > legally privileged, and is intended solely for the use of
> > > the individual
> > > > or entity named in this message. If you are not the
> > > intended recipient,
> > > > and have received this message in error, please immediately
> > > return this
> > > > by email and then delete it.
> > > >
> > > > > -----Original Message-----
> > > > > From: Ritika Maheshwari [mailto:ritikamster@gmail.com]
> > > > > Sent: Friday, April 06, 2007 10:14 AM
> > > > > To: open-jpa-dev@incubator.apache.org
> > > > > Subject: Re: svn commit: r526212 - in
> > > > > /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache
> > > > > /openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java
> > > > > sql/DBDictionary.java
> > > > >
> > > > > Patrick,
> > > > > With your recent changes regarding the
> > > > > OPENJPA-182 The logic
> > > > > has changed a little.What was intended was that if the
> > > > > forUpdate flag = true
> > > > > we append the FOR UPDATE CLAUSE.But in case of DB2 if the
> > > > > forUpdate flag =
> > > > > false then we append FOR READ ONLY clause.Now the FOR READ
> > > > > ONLY Clause is
> > > > > not getting generated.This is because you moved
> > > toOperation back to
> > > > > DBDictionary and there you check if (forUpdate &&
> > > > > !simulateLocking) then
> > > > > append forUpdateClause.Well in this case forUpdate is false
> > > > > and we still
> > > > > want the forUpdateClause.That was the reason I had
> overridden the
> > > > > toOperation in DB2Dictionary and was just checking
> > > > > (!simulateLocking) before
> > > > > appending the forUpdate Clause.
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > On 4/6/07, pcl@apache.org <pc...@apache.org> wrote:
> > > > > >
> > > > > > Author: pcl
> > > > > > Date: Fri Apr 6 09:08:27 2007
> > > > > > New Revision: 526212
> > > > > >
> > > > > > URL: http://svn.apache.org/viewvc?view=rev&rev=526212
> > > > > > Log:
> > > > > > OPENJPA-182
> > > > > >
> > > > > > Modified:
> > > > > >
> > > > > >
> > > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > >
> > > > > >
> > > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > openjpa/jdbc/sql/DBDictionary.java
> > > > > >
> > > > > > Modified:
> > > > > >
> > > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > > URL:
> > > > > >
> > > > > http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-j
> > > >
> > > dbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConf
> > > igurationI
> > > > mpl.java?> view=diff&rev=526212&r1=526211&r2=526212
> > > > > >
> > > > > >
> > > > > ==============================================================
> > > > > ================
> > > > > > ---
> > > > > >
> > > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > > (original)
> > > > > > +++
> > > > > >
> > > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > > Fri Apr 6 09:08:27 2007
> > > > > > @@ -327,7 +327,7 @@
> > > > > > }
> > > > > >
> > > > > > public JDBCFetchConfiguration
> setIsolationLevel(int level) {
> > > > > > - if (level != -1
> > > > > > + if (level != -1 && level != DEFAULT
> > > > > > && level != Connection.TRANSACTION_NONE
> > > > > > && level !=
> Connection.TRANSACTION_READ_UNCOMMITTED
> > > > > > && level !=
> Connection.TRANSACTION_READ_COMMITTED
> > > > > > @@ -335,8 +335,11 @@
> > > > > > && level != Connection.TRANSACTION_SERIALIZABLE)
> > > > > > throw new IllegalArgumentException(
> > > > > > _loc.get("bad-level", Integer.valueOf
> > > > > > (level)).getMessage());
> > > > > > -
> > > > > > - _state.isolationLevel = level;
> > > > > > +
> > > > > > + if (level == DEFAULT)
> > > > > > + _state.isolationLevel = -1;
> > > > > > + else
> > > > > > + _state.isolationLevel = level;
> > > > > > return this;
> > > > > > }
> > > > > > }
> > > > > >
> > > > > > Modified:
> > > > > >
> > > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > openjpa/jdbc/sql/DBDictionary.java
> > > > > > URL:
> > > > > >
> > > > > http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-j
> > > >
> > > dbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.jav
> > > a?view=dif
> > > > f&rev=526212&r1=> 526211&r2=526212
> > > > > >
> > > > > >
> > > > > ==============================================================
> > > > > ================
> > > > > > ---
> > > > > >
> > > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > openjpa/jdbc/sql/DBDictionary.java
> > > > > > (original)
> > > > > > +++
> > > > > >
> > > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > > openjpa/jdbc/sql/DBDictionary.java
> > > > > > Fri Apr 6 09:08:27 2007
> > > > > > @@ -2205,8 +2205,8 @@
> > > > > >
> > > > > > if (forUpdate && !simulateLocking) {
> > > > > > assertSupport(supportsSelectForUpdate,
> > > > > > "SupportsSelectForUpdate");
> > > > > > - if (this.forUpdateClause != null)
> > > > > > - buf.append("
> ").append(this.forUpdateClause);
> > > > > > + if (forUpdateClause != null)
> > > > > > + buf.append(" ").append(forUpdateClause);
> > > > > > }
> > > > > > if (range && rangePosition == RANGE_POST_LOCK)
> > > > > > appendSelectRange(buf, start, end);
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > > > Notice: This email message, together with any attachments,
> > > may contain
> > > > information of BEA Systems, Inc., its subsidiaries and
> > > affiliated
> > > > entities, that may be confidential, proprietary,
> > > copyrighted and/or
> > > > legally privileged, and is intended solely for the use of
> > > the individual or
> > > > entity named in this message. If you are not the intended
> > > recipient, and
> > > > have received this message in error, please immediately
> > > return this by email
> > > > and then delete it.
> > > >
> > >
> >
> > Notice: This email message, together with any attachments,
> may contain
> > information of BEA Systems, Inc., its subsidiaries and
> affiliated
> > entities, that may be confidential, proprietary,
> copyrighted and/or
> > legally privileged, and is intended solely for the use of
> the individual or
> > entity named in this message. If you are not the intended
> recipient, and
> > have received this message in error, please immediately
> return this by email
> > and then delete it.
>
Notice: This email message, together with any attachments, may contain information of BEA Systems, Inc., its subsidiaries and affiliated entities, that may be confidential, proprietary, copyrighted and/or legally privileged, and is intended solely for the use of the individual or entity named in this message. If you are not the intended recipient, and have received this message in error, please immediately return this by email and then delete it.
Re: svn commit: r526212 - in /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java sql/DBDictionary.java
Posted by Ritika Maheshwari <ri...@gmail.com>.
Patrick
I didn't get the patch
On 4/6/07, Patrick Linskey <pl...@bea.com> wrote:
>
> Gotcha. The attached patch should probably get around that problem; I
> haven't tested it at all though. Let me know what happens in your
> environment.
>
> -Patrick
>
> --
> Patrick Linskey
> BEA Systems, Inc.
>
> _______________________________________________________________________
> Notice: This email message, together with any attachments, may contain
> information of BEA Systems, Inc., its subsidiaries and affiliated
> entities, that may be confidential, proprietary, copyrighted and/or
> legally privileged, and is intended solely for the use of the individual
> or entity named in this message. If you are not the intended recipient,
> and have received this message in error, please immediately return this
> by email and then delete it.
>
> > -----Original Message-----
> > From: Ritika Maheshwari [mailto:ritikamster@gmail.com]
> > Sent: Friday, April 06, 2007 10:27 AM
> > To: open-jpa-dev@incubator.apache.org
> > Subject: Re: svn commit: r526212 - in
> > /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache
> > /openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java
> > sql/DBDictionary.java
> >
> > Patrick,
> > Derby does not support this.And I am running on
> > the most recent
> > code and still seeing same behaviour.Essentially for DB2 you
> > cannot check
> > (forUpdate && !simulateLocking).DB2 will always have a
> > forUpdate clause
> > whether forUpdae is true or false
> >
> >
> > On 4/6/07, Patrick Linskey <pl...@bea.com> wrote:
> > >
> > > Yes -- see my more recent commit. It should resolve this issue.
> > >
> > > Once you guys get some unit tests in place for this, and we have DB2
> > > coverage in our checkin tests, this type of thing shouldn't happen.
> > >
> > > Does Derby provide the same support? IIRC, Derby shares
> > quite a bit of
> > > DB2 syntax; maybe you could change the DerbyDictionary (extends
> > > AbstractDB2Dictionary) to do the same thing, in which case
> > we'll be able
> > > to unit test this stuff without any new database resources.
> > >
> > > -Patrick
> > >
> > > --
> > > Patrick Linskey
> > > BEA Systems, Inc.
> > >
> > >
> > ______________________________________________________________
> > _________
> > > Notice: This email message, together with any attachments,
> > may contain
> > > information of BEA Systems, Inc., its subsidiaries and
> > affiliated
> > > entities, that may be confidential, proprietary,
> > copyrighted and/or
> > > legally privileged, and is intended solely for the use of
> > the individual
> > > or entity named in this message. If you are not the
> > intended recipient,
> > > and have received this message in error, please immediately
> > return this
> > > by email and then delete it.
> > >
> > > > -----Original Message-----
> > > > From: Ritika Maheshwari [mailto:ritikamster@gmail.com]
> > > > Sent: Friday, April 06, 2007 10:14 AM
> > > > To: open-jpa-dev@incubator.apache.org
> > > > Subject: Re: svn commit: r526212 - in
> > > > /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache
> > > > /openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java
> > > > sql/DBDictionary.java
> > > >
> > > > Patrick,
> > > > With your recent changes regarding the
> > > > OPENJPA-182 The logic
> > > > has changed a little.What was intended was that if the
> > > > forUpdate flag = true
> > > > we append the FOR UPDATE CLAUSE.But in case of DB2 if the
> > > > forUpdate flag =
> > > > false then we append FOR READ ONLY clause.Now the FOR READ
> > > > ONLY Clause is
> > > > not getting generated.This is because you moved
> > toOperation back to
> > > > DBDictionary and there you check if (forUpdate &&
> > > > !simulateLocking) then
> > > > append forUpdateClause.Well in this case forUpdate is false
> > > > and we still
> > > > want the forUpdateClause.That was the reason I had overridden the
> > > > toOperation in DB2Dictionary and was just checking
> > > > (!simulateLocking) before
> > > > appending the forUpdate Clause.
> > > >
> > > >
> > > >
> > > >
> > > > On 4/6/07, pcl@apache.org <pc...@apache.org> wrote:
> > > > >
> > > > > Author: pcl
> > > > > Date: Fri Apr 6 09:08:27 2007
> > > > > New Revision: 526212
> > > > >
> > > > > URL: http://svn.apache.org/viewvc?view=rev&rev=526212
> > > > > Log:
> > > > > OPENJPA-182
> > > > >
> > > > > Modified:
> > > > >
> > > > >
> > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > >
> > > > >
> > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > openjpa/jdbc/sql/DBDictionary.java
> > > > >
> > > > > Modified:
> > > > >
> > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > URL:
> > > > >
> > > > http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-j
> > >
> > dbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConf
> > igurationI
> > > mpl.java?> view=diff&rev=526212&r1=526211&r2=526212
> > > > >
> > > > >
> > > > ==============================================================
> > > > ================
> > > > > ---
> > > > >
> > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > (original)
> > > > > +++
> > > > >
> > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > > Fri Apr 6 09:08:27 2007
> > > > > @@ -327,7 +327,7 @@
> > > > > }
> > > > >
> > > > > public JDBCFetchConfiguration setIsolationLevel(int level) {
> > > > > - if (level != -1
> > > > > + if (level != -1 && level != DEFAULT
> > > > > && level != Connection.TRANSACTION_NONE
> > > > > && level != Connection.TRANSACTION_READ_UNCOMMITTED
> > > > > && level != Connection.TRANSACTION_READ_COMMITTED
> > > > > @@ -335,8 +335,11 @@
> > > > > && level != Connection.TRANSACTION_SERIALIZABLE)
> > > > > throw new IllegalArgumentException(
> > > > > _loc.get("bad-level", Integer.valueOf
> > > > > (level)).getMessage());
> > > > > -
> > > > > - _state.isolationLevel = level;
> > > > > +
> > > > > + if (level == DEFAULT)
> > > > > + _state.isolationLevel = -1;
> > > > > + else
> > > > > + _state.isolationLevel = level;
> > > > > return this;
> > > > > }
> > > > > }
> > > > >
> > > > > Modified:
> > > > >
> > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > openjpa/jdbc/sql/DBDictionary.java
> > > > > URL:
> > > > >
> > > > http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-j
> > >
> > dbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.jav
> > a?view=dif
> > > f&rev=526212&r1=> 526211&r2=526212
> > > > >
> > > > >
> > > > ==============================================================
> > > > ================
> > > > > ---
> > > > >
> > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > openjpa/jdbc/sql/DBDictionary.java
> > > > > (original)
> > > > > +++
> > > > >
> > > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > > openjpa/jdbc/sql/DBDictionary.java
> > > > > Fri Apr 6 09:08:27 2007
> > > > > @@ -2205,8 +2205,8 @@
> > > > >
> > > > > if (forUpdate && !simulateLocking) {
> > > > > assertSupport(supportsSelectForUpdate,
> > > > > "SupportsSelectForUpdate");
> > > > > - if (this.forUpdateClause != null)
> > > > > - buf.append(" ").append(this.forUpdateClause);
> > > > > + if (forUpdateClause != null)
> > > > > + buf.append(" ").append(forUpdateClause);
> > > > > }
> > > > > if (range && rangePosition == RANGE_POST_LOCK)
> > > > > appendSelectRange(buf, start, end);
> > > > >
> > > > >
> > > > >
> > > >
> > >
> > > Notice: This email message, together with any attachments,
> > may contain
> > > information of BEA Systems, Inc., its subsidiaries and
> > affiliated
> > > entities, that may be confidential, proprietary,
> > copyrighted and/or
> > > legally privileged, and is intended solely for the use of
> > the individual or
> > > entity named in this message. If you are not the intended
> > recipient, and
> > > have received this message in error, please immediately
> > return this by email
> > > and then delete it.
> > >
> >
>
> Notice: This email message, together with any attachments, may contain
> information of BEA Systems, Inc., its subsidiaries and affiliated
> entities, that may be confidential, proprietary, copyrighted and/or
> legally privileged, and is intended solely for the use of the individual or
> entity named in this message. If you are not the intended recipient, and
> have received this message in error, please immediately return this by email
> and then delete it.
RE: svn commit: r526212 - in /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java sql/DBDictionary.java
Posted by Patrick Linskey <pl...@bea.com>.
Gotcha. The attached patch should probably get around that problem; I
haven't tested it at all though. Let me know what happens in your
environment.
-Patrick
--
Patrick Linskey
BEA Systems, Inc.
_______________________________________________________________________
Notice: This email message, together with any attachments, may contain
information of BEA Systems, Inc., its subsidiaries and affiliated
entities, that may be confidential, proprietary, copyrighted and/or
legally privileged, and is intended solely for the use of the individual
or entity named in this message. If you are not the intended recipient,
and have received this message in error, please immediately return this
by email and then delete it.
> -----Original Message-----
> From: Ritika Maheshwari [mailto:ritikamster@gmail.com]
> Sent: Friday, April 06, 2007 10:27 AM
> To: open-jpa-dev@incubator.apache.org
> Subject: Re: svn commit: r526212 - in
> /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache
> /openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java
> sql/DBDictionary.java
>
> Patrick,
> Derby does not support this.And I am running on
> the most recent
> code and still seeing same behaviour.Essentially for DB2 you
> cannot check
> (forUpdate && !simulateLocking).DB2 will always have a
> forUpdate clause
> whether forUpdae is true or false
>
>
> On 4/6/07, Patrick Linskey <pl...@bea.com> wrote:
> >
> > Yes -- see my more recent commit. It should resolve this issue.
> >
> > Once you guys get some unit tests in place for this, and we have DB2
> > coverage in our checkin tests, this type of thing shouldn't happen.
> >
> > Does Derby provide the same support? IIRC, Derby shares
> quite a bit of
> > DB2 syntax; maybe you could change the DerbyDictionary (extends
> > AbstractDB2Dictionary) to do the same thing, in which case
> we'll be able
> > to unit test this stuff without any new database resources.
> >
> > -Patrick
> >
> > --
> > Patrick Linskey
> > BEA Systems, Inc.
> >
> >
> ______________________________________________________________
> _________
> > Notice: This email message, together with any attachments,
> may contain
> > information of BEA Systems, Inc., its subsidiaries and
> affiliated
> > entities, that may be confidential, proprietary,
> copyrighted and/or
> > legally privileged, and is intended solely for the use of
> the individual
> > or entity named in this message. If you are not the
> intended recipient,
> > and have received this message in error, please immediately
> return this
> > by email and then delete it.
> >
> > > -----Original Message-----
> > > From: Ritika Maheshwari [mailto:ritikamster@gmail.com]
> > > Sent: Friday, April 06, 2007 10:14 AM
> > > To: open-jpa-dev@incubator.apache.org
> > > Subject: Re: svn commit: r526212 - in
> > > /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache
> > > /openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java
> > > sql/DBDictionary.java
> > >
> > > Patrick,
> > > With your recent changes regarding the
> > > OPENJPA-182 The logic
> > > has changed a little.What was intended was that if the
> > > forUpdate flag = true
> > > we append the FOR UPDATE CLAUSE.But in case of DB2 if the
> > > forUpdate flag =
> > > false then we append FOR READ ONLY clause.Now the FOR READ
> > > ONLY Clause is
> > > not getting generated.This is because you moved
> toOperation back to
> > > DBDictionary and there you check if (forUpdate &&
> > > !simulateLocking) then
> > > append forUpdateClause.Well in this case forUpdate is false
> > > and we still
> > > want the forUpdateClause.That was the reason I had overridden the
> > > toOperation in DB2Dictionary and was just checking
> > > (!simulateLocking) before
> > > appending the forUpdate Clause.
> > >
> > >
> > >
> > >
> > > On 4/6/07, pcl@apache.org <pc...@apache.org> wrote:
> > > >
> > > > Author: pcl
> > > > Date: Fri Apr 6 09:08:27 2007
> > > > New Revision: 526212
> > > >
> > > > URL: http://svn.apache.org/viewvc?view=rev&rev=526212
> > > > Log:
> > > > OPENJPA-182
> > > >
> > > > Modified:
> > > >
> > > >
> > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > >
> > > >
> > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > openjpa/jdbc/sql/DBDictionary.java
> > > >
> > > > Modified:
> > > >
> > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > URL:
> > > >
> > > http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-j
> >
> dbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConf
> igurationI
> > mpl.java?> view=diff&rev=526212&r1=526211&r2=526212
> > > >
> > > >
> > > ==============================================================
> > > ================
> > > > ---
> > > >
> > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > (original)
> > > > +++
> > > >
> > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > > Fri Apr 6 09:08:27 2007
> > > > @@ -327,7 +327,7 @@
> > > > }
> > > >
> > > > public JDBCFetchConfiguration setIsolationLevel(int level) {
> > > > - if (level != -1
> > > > + if (level != -1 && level != DEFAULT
> > > > && level != Connection.TRANSACTION_NONE
> > > > && level != Connection.TRANSACTION_READ_UNCOMMITTED
> > > > && level != Connection.TRANSACTION_READ_COMMITTED
> > > > @@ -335,8 +335,11 @@
> > > > && level != Connection.TRANSACTION_SERIALIZABLE)
> > > > throw new IllegalArgumentException(
> > > > _loc.get("bad-level", Integer.valueOf
> > > > (level)).getMessage());
> > > > -
> > > > - _state.isolationLevel = level;
> > > > +
> > > > + if (level == DEFAULT)
> > > > + _state.isolationLevel = -1;
> > > > + else
> > > > + _state.isolationLevel = level;
> > > > return this;
> > > > }
> > > > }
> > > >
> > > > Modified:
> > > >
> > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > openjpa/jdbc/sql/DBDictionary.java
> > > > URL:
> > > >
> > > http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-j
> >
> dbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.jav
> a?view=dif
> > f&rev=526212&r1=> 526211&r2=526212
> > > >
> > > >
> > > ==============================================================
> > > ================
> > > > ---
> > > >
> > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > openjpa/jdbc/sql/DBDictionary.java
> > > > (original)
> > > > +++
> > > >
> > > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> > openjpa/jdbc/sql/DBDictionary.java
> > > > Fri Apr 6 09:08:27 2007
> > > > @@ -2205,8 +2205,8 @@
> > > >
> > > > if (forUpdate && !simulateLocking) {
> > > > assertSupport(supportsSelectForUpdate,
> > > > "SupportsSelectForUpdate");
> > > > - if (this.forUpdateClause != null)
> > > > - buf.append(" ").append(this.forUpdateClause);
> > > > + if (forUpdateClause != null)
> > > > + buf.append(" ").append(forUpdateClause);
> > > > }
> > > > if (range && rangePosition == RANGE_POST_LOCK)
> > > > appendSelectRange(buf, start, end);
> > > >
> > > >
> > > >
> > >
> >
> > Notice: This email message, together with any attachments,
> may contain
> > information of BEA Systems, Inc., its subsidiaries and
> affiliated
> > entities, that may be confidential, proprietary,
> copyrighted and/or
> > legally privileged, and is intended solely for the use of
> the individual or
> > entity named in this message. If you are not the intended
> recipient, and
> > have received this message in error, please immediately
> return this by email
> > and then delete it.
> >
>
Notice: This email message, together with any attachments, may contain information of BEA Systems, Inc., its subsidiaries and affiliated entities, that may be confidential, proprietary, copyrighted and/or legally privileged, and is intended solely for the use of the individual or entity named in this message. If you are not the intended recipient, and have received this message in error, please immediately return this by email and then delete it.
Re: svn commit: r526212 - in /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java sql/DBDictionary.java
Posted by Ritika Maheshwari <ri...@gmail.com>.
Patrick,
Derby does not support this.And I am running on the most recent
code and still seeing same behaviour.Essentially for DB2 you cannot check
(forUpdate && !simulateLocking).DB2 will always have a forUpdate clause
whether forUpdae is true or false
On 4/6/07, Patrick Linskey <pl...@bea.com> wrote:
>
> Yes -- see my more recent commit. It should resolve this issue.
>
> Once you guys get some unit tests in place for this, and we have DB2
> coverage in our checkin tests, this type of thing shouldn't happen.
>
> Does Derby provide the same support? IIRC, Derby shares quite a bit of
> DB2 syntax; maybe you could change the DerbyDictionary (extends
> AbstractDB2Dictionary) to do the same thing, in which case we'll be able
> to unit test this stuff without any new database resources.
>
> -Patrick
>
> --
> Patrick Linskey
> BEA Systems, Inc.
>
> _______________________________________________________________________
> Notice: This email message, together with any attachments, may contain
> information of BEA Systems, Inc., its subsidiaries and affiliated
> entities, that may be confidential, proprietary, copyrighted and/or
> legally privileged, and is intended solely for the use of the individual
> or entity named in this message. If you are not the intended recipient,
> and have received this message in error, please immediately return this
> by email and then delete it.
>
> > -----Original Message-----
> > From: Ritika Maheshwari [mailto:ritikamster@gmail.com]
> > Sent: Friday, April 06, 2007 10:14 AM
> > To: open-jpa-dev@incubator.apache.org
> > Subject: Re: svn commit: r526212 - in
> > /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache
> > /openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java
> > sql/DBDictionary.java
> >
> > Patrick,
> > With your recent changes regarding the
> > OPENJPA-182 The logic
> > has changed a little.What was intended was that if the
> > forUpdate flag = true
> > we append the FOR UPDATE CLAUSE.But in case of DB2 if the
> > forUpdate flag =
> > false then we append FOR READ ONLY clause.Now the FOR READ
> > ONLY Clause is
> > not getting generated.This is because you moved toOperation back to
> > DBDictionary and there you check if (forUpdate &&
> > !simulateLocking) then
> > append forUpdateClause.Well in this case forUpdate is false
> > and we still
> > want the forUpdateClause.That was the reason I had overridden the
> > toOperation in DB2Dictionary and was just checking
> > (!simulateLocking) before
> > appending the forUpdate Clause.
> >
> >
> >
> >
> > On 4/6/07, pcl@apache.org <pc...@apache.org> wrote:
> > >
> > > Author: pcl
> > > Date: Fri Apr 6 09:08:27 2007
> > > New Revision: 526212
> > >
> > > URL: http://svn.apache.org/viewvc?view=rev&rev=526212
> > > Log:
> > > OPENJPA-182
> > >
> > > Modified:
> > >
> > >
> > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > >
> > >
> > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> openjpa/jdbc/sql/DBDictionary.java
> > >
> > > Modified:
> > >
> > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > URL:
> > >
> > http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-j
> dbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConfigurationI
> mpl.java?> view=diff&rev=526212&r1=526211&r2=526212
> > >
> > >
> > ==============================================================
> > ================
> > > ---
> > >
> > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > (original)
> > > +++
> > >
> > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > > Fri Apr 6 09:08:27 2007
> > > @@ -327,7 +327,7 @@
> > > }
> > >
> > > public JDBCFetchConfiguration setIsolationLevel(int level) {
> > > - if (level != -1
> > > + if (level != -1 && level != DEFAULT
> > > && level != Connection.TRANSACTION_NONE
> > > && level != Connection.TRANSACTION_READ_UNCOMMITTED
> > > && level != Connection.TRANSACTION_READ_COMMITTED
> > > @@ -335,8 +335,11 @@
> > > && level != Connection.TRANSACTION_SERIALIZABLE)
> > > throw new IllegalArgumentException(
> > > _loc.get("bad-level", Integer.valueOf
> > > (level)).getMessage());
> > > -
> > > - _state.isolationLevel = level;
> > > +
> > > + if (level == DEFAULT)
> > > + _state.isolationLevel = -1;
> > > + else
> > > + _state.isolationLevel = level;
> > > return this;
> > > }
> > > }
> > >
> > > Modified:
> > >
> > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> openjpa/jdbc/sql/DBDictionary.java
> > > URL:
> > >
> > http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-j
> dbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java?view=dif
> f&rev=526212&r1=> 526211&r2=526212
> > >
> > >
> > ==============================================================
> > ================
> > > ---
> > >
> > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> openjpa/jdbc/sql/DBDictionary.java
> > > (original)
> > > +++
> > >
> > incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
> openjpa/jdbc/sql/DBDictionary.java
> > > Fri Apr 6 09:08:27 2007
> > > @@ -2205,8 +2205,8 @@
> > >
> > > if (forUpdate && !simulateLocking) {
> > > assertSupport(supportsSelectForUpdate,
> > > "SupportsSelectForUpdate");
> > > - if (this.forUpdateClause != null)
> > > - buf.append(" ").append(this.forUpdateClause);
> > > + if (forUpdateClause != null)
> > > + buf.append(" ").append(forUpdateClause);
> > > }
> > > if (range && rangePosition == RANGE_POST_LOCK)
> > > appendSelectRange(buf, start, end);
> > >
> > >
> > >
> >
>
> Notice: This email message, together with any attachments, may contain
> information of BEA Systems, Inc., its subsidiaries and affiliated
> entities, that may be confidential, proprietary, copyrighted and/or
> legally privileged, and is intended solely for the use of the individual or
> entity named in this message. If you are not the intended recipient, and
> have received this message in error, please immediately return this by email
> and then delete it.
>
RE: svn commit: r526212 - in /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java sql/DBDictionary.java
Posted by Patrick Linskey <pl...@bea.com>.
Yes -- see my more recent commit. It should resolve this issue.
Once you guys get some unit tests in place for this, and we have DB2
coverage in our checkin tests, this type of thing shouldn't happen.
Does Derby provide the same support? IIRC, Derby shares quite a bit of
DB2 syntax; maybe you could change the DerbyDictionary (extends
AbstractDB2Dictionary) to do the same thing, in which case we'll be able
to unit test this stuff without any new database resources.
-Patrick
--
Patrick Linskey
BEA Systems, Inc.
_______________________________________________________________________
Notice: This email message, together with any attachments, may contain
information of BEA Systems, Inc., its subsidiaries and affiliated
entities, that may be confidential, proprietary, copyrighted and/or
legally privileged, and is intended solely for the use of the individual
or entity named in this message. If you are not the intended recipient,
and have received this message in error, please immediately return this
by email and then delete it.
> -----Original Message-----
> From: Ritika Maheshwari [mailto:ritikamster@gmail.com]
> Sent: Friday, April 06, 2007 10:14 AM
> To: open-jpa-dev@incubator.apache.org
> Subject: Re: svn commit: r526212 - in
> /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache
> /openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java
> sql/DBDictionary.java
>
> Patrick,
> With your recent changes regarding the
> OPENJPA-182 The logic
> has changed a little.What was intended was that if the
> forUpdate flag = true
> we append the FOR UPDATE CLAUSE.But in case of DB2 if the
> forUpdate flag =
> false then we append FOR READ ONLY clause.Now the FOR READ
> ONLY Clause is
> not getting generated.This is because you moved toOperation back to
> DBDictionary and there you check if (forUpdate &&
> !simulateLocking) then
> append forUpdateClause.Well in this case forUpdate is false
> and we still
> want the forUpdateClause.That was the reason I had overridden the
> toOperation in DB2Dictionary and was just checking
> (!simulateLocking) before
> appending the forUpdate Clause.
>
>
>
>
> On 4/6/07, pcl@apache.org <pc...@apache.org> wrote:
> >
> > Author: pcl
> > Date: Fri Apr 6 09:08:27 2007
> > New Revision: 526212
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=526212
> > Log:
> > OPENJPA-182
> >
> > Modified:
> >
> >
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> >
> >
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
openjpa/jdbc/sql/DBDictionary.java
> >
> > Modified:
> >
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > URL:
> >
> http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-j
dbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConfigurationI
mpl.java?> view=diff&rev=526212&r1=526211&r2=526212
> >
> >
> ==============================================================
> ================
> > ---
> >
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > (original)
> > +++
> >
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> > Fri Apr 6 09:08:27 2007
> > @@ -327,7 +327,7 @@
> > }
> >
> > public JDBCFetchConfiguration setIsolationLevel(int level) {
> > - if (level != -1
> > + if (level != -1 && level != DEFAULT
> > && level != Connection.TRANSACTION_NONE
> > && level != Connection.TRANSACTION_READ_UNCOMMITTED
> > && level != Connection.TRANSACTION_READ_COMMITTED
> > @@ -335,8 +335,11 @@
> > && level != Connection.TRANSACTION_SERIALIZABLE)
> > throw new IllegalArgumentException(
> > _loc.get("bad-level", Integer.valueOf
> > (level)).getMessage());
> > -
> > - _state.isolationLevel = level;
> > +
> > + if (level == DEFAULT)
> > + _state.isolationLevel = -1;
> > + else
> > + _state.isolationLevel = level;
> > return this;
> > }
> > }
> >
> > Modified:
> >
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
openjpa/jdbc/sql/DBDictionary.java
> > URL:
> >
> http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-j
dbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java?view=dif
f&rev=526212&r1=> 526211&r2=526212
> >
> >
> ==============================================================
> ================
> > ---
> >
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
openjpa/jdbc/sql/DBDictionary.java
> > (original)
> > +++
> >
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/
openjpa/jdbc/sql/DBDictionary.java
> > Fri Apr 6 09:08:27 2007
> > @@ -2205,8 +2205,8 @@
> >
> > if (forUpdate && !simulateLocking) {
> > assertSupport(supportsSelectForUpdate,
> > "SupportsSelectForUpdate");
> > - if (this.forUpdateClause != null)
> > - buf.append(" ").append(this.forUpdateClause);
> > + if (forUpdateClause != null)
> > + buf.append(" ").append(forUpdateClause);
> > }
> > if (range && rangePosition == RANGE_POST_LOCK)
> > appendSelectRange(buf, start, end);
> >
> >
> >
>
Notice: This email message, together with any attachments, may contain information of BEA Systems, Inc., its subsidiaries and affiliated entities, that may be confidential, proprietary, copyrighted and/or legally privileged, and is intended solely for the use of the individual or entity named in this message. If you are not the intended recipient, and have received this message in error, please immediately return this by email and then delete it.
Re: svn commit: r526212 - in /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc: kernel/JDBCFetchConfigurationImpl.java sql/DBDictionary.java
Posted by Ritika Maheshwari <ri...@gmail.com>.
Patrick,
With your recent changes regarding the OPENJPA-182 The logic
has changed a little.What was intended was that if the forUpdate flag = true
we append the FOR UPDATE CLAUSE.But in case of DB2 if the forUpdate flag =
false then we append FOR READ ONLY clause.Now the FOR READ ONLY Clause is
not getting generated.This is because you moved toOperation back to
DBDictionary and there you check if (forUpdate && !simulateLocking) then
append forUpdateClause.Well in this case forUpdate is false and we still
want the forUpdateClause.That was the reason I had overridden the
toOperation in DB2Dictionary and was just checking (!simulateLocking) before
appending the forUpdate Clause.
On 4/6/07, pcl@apache.org <pc...@apache.org> wrote:
>
> Author: pcl
> Date: Fri Apr 6 09:08:27 2007
> New Revision: 526212
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=526212
> Log:
> OPENJPA-182
>
> Modified:
>
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
>
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java
>
> Modified:
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> URL:
> http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java?view=diff&rev=526212&r1=526211&r2=526212
>
> ==============================================================================
> ---
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> (original)
> +++
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCFetchConfigurationImpl.java
> Fri Apr 6 09:08:27 2007
> @@ -327,7 +327,7 @@
> }
>
> public JDBCFetchConfiguration setIsolationLevel(int level) {
> - if (level != -1
> + if (level != -1 && level != DEFAULT
> && level != Connection.TRANSACTION_NONE
> && level != Connection.TRANSACTION_READ_UNCOMMITTED
> && level != Connection.TRANSACTION_READ_COMMITTED
> @@ -335,8 +335,11 @@
> && level != Connection.TRANSACTION_SERIALIZABLE)
> throw new IllegalArgumentException(
> _loc.get("bad-level", Integer.valueOf
> (level)).getMessage());
> -
> - _state.isolationLevel = level;
> +
> + if (level == DEFAULT)
> + _state.isolationLevel = -1;
> + else
> + _state.isolationLevel = level;
> return this;
> }
> }
>
> Modified:
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java
> URL:
> http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java?view=diff&rev=526212&r1=526211&r2=526212
>
> ==============================================================================
> ---
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java
> (original)
> +++
> incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java
> Fri Apr 6 09:08:27 2007
> @@ -2205,8 +2205,8 @@
>
> if (forUpdate && !simulateLocking) {
> assertSupport(supportsSelectForUpdate,
> "SupportsSelectForUpdate");
> - if (this.forUpdateClause != null)
> - buf.append(" ").append(this.forUpdateClause);
> + if (forUpdateClause != null)
> + buf.append(" ").append(forUpdateClause);
> }
> if (range && rangePosition == RANGE_POST_LOCK)
> appendSelectRange(buf, start, end);
>
>
>