You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Bob Dionne (JIRA)" <ji...@apache.org> on 2011/02/12 22:55:57 UTC
[jira] Created: (COUCHDB-1065) couch_db_updater calls
couch_key_tree:
couch_db_updater calls couch_key_tree:
--------------------------------------
Key: COUCHDB-1065
URL: https://issues.apache.org/jira/browse/COUCHDB-1065
Project: CouchDB
Issue Type: Bug
Components: Database Core
Reporter: Bob Dionne
couch_db_updater at line 123 calls couch_key_tree:map_leafs( fun(RevInfo) -..... incorrectly. The function needs to have two arguments.
This is readily seen by creating two small dbs with a doc in each having the same id, replicating one to the other and then calling
_purge
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (COUCHDB-1065) couch_db_updater calls
couch_key_tree incorrectly
Posted by "Randall Leeds (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Randall Leeds updated COUCHDB-1065:
-----------------------------------
Attachment: couchdb_1065.patch
Here's a patch which includes the tests posted by Jan.
The fun passed to map_leafs/2 was taking the wrong parameters and also expecting #rev_info records as they are in the by_seq_btree but the key tree being mapped here is the by_id_btree whose rev_tree values are just a tuple {IsDeleted, BodyPointer, UpdateSeq}.
> couch_db_updater calls couch_key_tree incorrectly
> -------------------------------------------------
>
> Key: COUCHDB-1065
> URL: https://issues.apache.org/jira/browse/COUCHDB-1065
> Project: CouchDB
> Issue Type: Bug
> Components: Database Core
> Reporter: Bob Dionne
> Fix For: 1.0.3, 1.1
>
> Attachments: couchdb_1065.patch
>
>
> couch_db_updater at line 123 calls couch_key_tree:map_leafs( fun(RevInfo) -..... incorrectly. The function needs to have two arguments.
> This is readily seen by creating two small dbs with a doc in each having the same id, replicating one to the other and then calling
> _purge
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (COUCHDB-1065) couch_db_updater calls
couch_key_tree incorrectly
Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Kocoloski updated COUCHDB-1065:
------------------------------------
Fix Version/s: 1.1
1.0.3
> couch_db_updater calls couch_key_tree incorrectly
> -------------------------------------------------
>
> Key: COUCHDB-1065
> URL: https://issues.apache.org/jira/browse/COUCHDB-1065
> Project: CouchDB
> Issue Type: Bug
> Components: Database Core
> Reporter: Bob Dionne
> Fix For: 1.0.3, 1.1
>
>
> couch_db_updater at line 123 calls couch_key_tree:map_leafs( fun(RevInfo) -..... incorrectly. The function needs to have two arguments.
> This is readily seen by creating two small dbs with a doc in each having the same id, replicating one to the other and then calling
> _purge
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COUCHDB-1065) couch_db_updater calls
couch_key_tree incorrectly
Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994655#comment-12994655 ]
Adam Kocoloski commented on COUCHDB-1065:
-----------------------------------------
Wow. So _purge only works when all revisions of a document are purged, right? Otherwise it must crash. Good find Bob.
> couch_db_updater calls couch_key_tree incorrectly
> -------------------------------------------------
>
> Key: COUCHDB-1065
> URL: https://issues.apache.org/jira/browse/COUCHDB-1065
> Project: CouchDB
> Issue Type: Bug
> Components: Database Core
> Reporter: Bob Dionne
>
> couch_db_updater at line 123 calls couch_key_tree:map_leafs( fun(RevInfo) -..... incorrectly. The function needs to have two arguments.
> This is readily seen by creating two small dbs with a doc in each having the same id, replicating one to the other and then calling
> _purge
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1065) couch_db_updater calls
couch_key_tree incorrectly
Posted by "Jan Lehnardt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011789#comment-13011789 ]
Jan Lehnardt commented on COUCHDB-1065:
---------------------------------------
http://friendpaste.com/4pVKqLvWQEl7PJIZ9EXDMe tests the behaviour, trying to purge either rev causes a 500, purging both works.
> couch_db_updater calls couch_key_tree incorrectly
> -------------------------------------------------
>
> Key: COUCHDB-1065
> URL: https://issues.apache.org/jira/browse/COUCHDB-1065
> Project: CouchDB
> Issue Type: Bug
> Components: Database Core
> Reporter: Bob Dionne
> Fix For: 1.0.3, 1.1
>
>
> couch_db_updater at line 123 calls couch_key_tree:map_leafs( fun(RevInfo) -..... incorrectly. The function needs to have two arguments.
> This is readily seen by creating two small dbs with a doc in each having the same id, replicating one to the other and then calling
> _purge
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (COUCHDB-1065) couch_db_updater calls
couch_key_tree incorrectly
Posted by "Randall Leeds (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Randall Leeds updated COUCHDB-1065:
-----------------------------------
Attachment: couchdb_1065_v2.patch
Whoops. Another version that doesn't introduce an unused variable.
> couch_db_updater calls couch_key_tree incorrectly
> -------------------------------------------------
>
> Key: COUCHDB-1065
> URL: https://issues.apache.org/jira/browse/COUCHDB-1065
> Project: CouchDB
> Issue Type: Bug
> Components: Database Core
> Reporter: Bob Dionne
> Fix For: 1.0.3, 1.1
>
> Attachments: couchdb_1065.patch, couchdb_1065_v2.patch
>
>
> couch_db_updater at line 123 calls couch_key_tree:map_leafs( fun(RevInfo) -..... incorrectly. The function needs to have two arguments.
> This is readily seen by creating two small dbs with a doc in each having the same id, replicating one to the other and then calling
> _purge
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1065) couch_db_updater calls
couch_key_tree incorrectly
Posted by "Jan Lehnardt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011685#comment-13011685 ]
Jan Lehnardt commented on COUCHDB-1065:
---------------------------------------
Is there a patch for this?
> couch_db_updater calls couch_key_tree incorrectly
> -------------------------------------------------
>
> Key: COUCHDB-1065
> URL: https://issues.apache.org/jira/browse/COUCHDB-1065
> Project: CouchDB
> Issue Type: Bug
> Components: Database Core
> Reporter: Bob Dionne
> Fix For: 1.0.3, 1.1
>
>
> couch_db_updater at line 123 calls couch_key_tree:map_leafs( fun(RevInfo) -..... incorrectly. The function needs to have two arguments.
> This is readily seen by creating two small dbs with a doc in each having the same id, replicating one to the other and then calling
> _purge
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (COUCHDB-1065) couch_db_updater calls
couch_key_tree incorrectly
Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Kocoloski updated COUCHDB-1065:
------------------------------------
Skill Level: Regular Contributors Level (Easy to Medium)
> couch_db_updater calls couch_key_tree incorrectly
> -------------------------------------------------
>
> Key: COUCHDB-1065
> URL: https://issues.apache.org/jira/browse/COUCHDB-1065
> Project: CouchDB
> Issue Type: Bug
> Components: Database Core
> Reporter: Bob Dionne
> Fix For: 1.0.3, 1.1
>
>
> couch_db_updater at line 123 calls couch_key_tree:map_leafs( fun(RevInfo) -..... incorrectly. The function needs to have two arguments.
> This is readily seen by creating two small dbs with a doc in each having the same id, replicating one to the other and then calling
> _purge
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (COUCHDB-1065) couch_db_updater calls
couch_key_tree incorrectly
Posted by "Jan Lehnardt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jan Lehnardt closed COUCHDB-1065.
---------------------------------
Resolution: Fixed
Fix Version/s: 1.2
Applied, thanks.
> couch_db_updater calls couch_key_tree incorrectly
> -------------------------------------------------
>
> Key: COUCHDB-1065
> URL: https://issues.apache.org/jira/browse/COUCHDB-1065
> Project: CouchDB
> Issue Type: Bug
> Components: Database Core
> Reporter: Bob Dionne
> Fix For: 1.0.3, 1.1, 1.2
>
> Attachments: couchdb_1065.patch, couchdb_1065_v2.patch
>
>
> couch_db_updater at line 123 calls couch_key_tree:map_leafs( fun(RevInfo) -..... incorrectly. The function needs to have two arguments.
> This is readily seen by creating two small dbs with a doc in each having the same id, replicating one to the other and then calling
> _purge
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira