You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Etienne Chauchot (Jira)" <ji...@apache.org> on 2021/10/28 09:48:00 UTC
[jira] [Updated] (BEAM-13136) Clean leftovers of old ESIO versions / test mechanism

     [ https://issues.apache.org/jira/browse/BEAM-13136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Etienne Chauchot updated BEAM-13136:
------------------------------------
    Description: 
While auditing about flakiness issues, I saw lefovers on the test code and production code of the IO. This list is not comprehensive but spots some places:
 * In ESTestCommon#testSplit there is a reference to ES2: ES2 cannot split the shards (missing API) so the split are fixed to the number of shards (5 by default in the test). As ES2 support was removed, this special case in the test can be removed
 * org.elasticsearch.bootstrap.JarHell was a hacky fix to disable jarHell test in ES test framework. This framework is no more used (testContainers) so we could remove the hack in all places
 * please audit for other places that could need cleaning.

  was:
While auditing about flakiness issues, I saw lefovers on the test code and production code of the IO. This list is not comprehensive but stops some places:
 * In ESTestCommon in testSplit there is a refence to ES2: ES2 cannot split the shards (missing API) so the split are fixed to the number of shards (5). As ES2 support was removed, this special case in the test can be removed
 * org.elasticsearch.bootstrap.JarHell was a hacky fix to disable jarHell test in ES test framework. This framework is no more used (testContainers) so we could remove the hack in all places
 * please audit for other places that could need cleaning.


> Clean leftovers of old ESIO versions / test mechanism
> -----------------------------------------------------
>
>                 Key: BEAM-13136
>                 URL: https://issues.apache.org/jira/browse/BEAM-13136
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-elasticsearch
>            Reporter: Etienne Chauchot
>            Assignee: Evan Galpin
>            Priority: P0
>
> While auditing about flakiness issues, I saw lefovers on the test code and production code of the IO. This list is not comprehensive but spots some places:
>  * In ESTestCommon#testSplit there is a reference to ES2: ES2 cannot split the shards (missing API) so the split are fixed to the number of shards (5 by default in the test). As ES2 support was removed, this special case in the test can be removed
>  * org.elasticsearch.bootstrap.JarHell was a hacky fix to disable jarHell test in ES test framework. This framework is no more used (testContainers) so we could remove the hack in all places
>  * please audit for other places that could need cleaning.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)