You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/26 13:06:02 UTC

[GitHub] [cloudstack] ravening opened a new pull request #4618: Allow users to update volume name

ravening opened a new pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618


   Provide an api support to update volume name by all users
   UI changes ported from https://github.com/apache/cloudstack-primate/pull/920
   ### Description
   
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [X] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618#issuecomment-895053688


   @ravening ping - can you fix the conflict? You can enable email settings in your github https://github.com/settings/notifications


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618#issuecomment-791901429


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd closed pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ravening commented on pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618#issuecomment-900927202


   > @ravening ping - can you fix the conflict? You can enable email settings in your github https://github.com/settings/notifications
   
   @rhtyd yes thats all enabled.. no idea why its not sending notifications!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez merged pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618#issuecomment-791905242


   Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2879


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618#issuecomment-791901505


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618#issuecomment-887171095


   Hi @ravening can you please resolve the conflicts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618#issuecomment-901593577


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 919


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ravening commented on pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618#issuecomment-900927202


   > @ravening ping - can you fix the conflict? You can enable email settings in your github https://github.com/settings/notifications
   
   @rhtyd yes thats all enabled.. no idea why its not sending notifications!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618#issuecomment-813308489


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618#issuecomment-901585324


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] sureshanaparti commented on pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618#issuecomment-868289955


   Hi @ravening, Can you resolve the code conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ravening commented on pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618#issuecomment-889690911


   > Hi @ravening can you please resolve the conflicts?
   
   @rhtyd @sureshanaparti @nvazquez will work on it today.
   I didnt get any notification from github on tagging my username and so was unaware of this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618#issuecomment-813308016


   @blueorangutan package
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618#issuecomment-813331472


   Packaging result: :heavy_multiplication_x: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 326


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618#issuecomment-901602692


   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618#issuecomment-901969219


   <b>Trillian test result (tid-1706)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34257 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4618-t1706-kvm-centos7.zip
   Smoke tests completed. 89 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618#issuecomment-768153754


   @ravening I recall this being discussed before. is it a reopening with old code?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618#issuecomment-901602493


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618#issuecomment-768154300


   yes, to answer my own question: #4584


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4618: Allow users to update volume name

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4618:
URL: https://github.com/apache/cloudstack/pull/4618#issuecomment-901585411


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org