You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/13 06:38:36 UTC
[GitHub] [flink] zhangjun888 opened a new pull request #11398: Reduce hive
source parallelism when limit push down
zhangjun888 opened a new pull request #11398: Reduce hive source parallelism when limit push down
URL: https://github.com/apache/flink/pull/11398
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Reduce hive source parallelism when limit push down
## Brief change log
Reduce hive source parallelism when limit push down
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager noCheckpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhangjun888 closed pull request #11398: [FLINK-16413]Reduce
hive source parallelism when limit push down
Posted by GitBox <gi...@apache.org>.
zhangjun888 closed pull request #11398: [FLINK-16413]Reduce hive source parallelism when limit push down
URL: https://github.com/apache/flink/pull/11398
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhangjun888 commented on a change in pull request #11398:
[FLINK-16413]Reduce hive source parallelism when limit push down
Posted by GitBox <gi...@apache.org>.
zhangjun888 commented on a change in pull request #11398: [FLINK-16413]Reduce hive source parallelism when limit push down
URL: https://github.com/apache/flink/pull/11398#discussion_r392114556
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java
##########
@@ -168,7 +168,9 @@ public boolean isBounded() {
} catch (IOException e) {
throw new FlinkHiveException(e);
}
- source.setParallelism(Math.min(Math.max(1, splitNum), max));
+ int parallelism = Math.min(Math.max(1, splitNum), max);
+ parallelism = limit > 0l ? Math.min(parallelism, (int)limit) : parallelism;
Review comment:
hi,jingsong:
parallelism is int type, limit is long type , If it is 0, not 0l, the system cannot be compiled,Math.min() will throw a exception. In addition, because the system default maximum parallelism is 1000, if limit > 1000, Math.min(parallelism, (int) limit) will take the minimum of 1000, (int)limit is only to do a type cast.
I will add the comment and the Test Class later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhangjun888 opened a new pull request #11398:
[FLINK-16413]Reduce hive source parallelism when limit push down
Posted by GitBox <gi...@apache.org>.
zhangjun888 opened a new pull request #11398: [FLINK-16413]Reduce hive source parallelism when limit push down
URL: https://github.com/apache/flink/pull/11398
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Reduce hive source parallelism when limit push down
## Brief change log
Reduce hive source parallelism when limit push down
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager noCheckpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #11398:
[FLINK-16413]Reduce hive source parallelism when limit push down
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #11398: [FLINK-16413]Reduce hive source parallelism when limit push down
URL: https://github.com/apache/flink/pull/11398#discussion_r392055291
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java
##########
@@ -168,7 +168,9 @@ public boolean isBounded() {
} catch (IOException e) {
throw new FlinkHiveException(e);
}
- source.setParallelism(Math.min(Math.max(1, splitNum), max));
+ int parallelism = Math.min(Math.max(1, splitNum), max);
+ parallelism = limit > 0l ? Math.min(parallelism, (int)limit) : parallelism;
Review comment:
`(int)limit` -> maybe `limit/1000` ?
`0l` -> `0`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhangjun888 closed pull request #11398: [FLINK-16413]Reduce
hive source parallelism when limit push down
Posted by GitBox <gi...@apache.org>.
zhangjun888 closed pull request #11398: [FLINK-16413]Reduce hive source parallelism when limit push down
URL: https://github.com/apache/flink/pull/11398
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11398:
[FLINK-16413]Reduce hive source parallelism when limit push down
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11398: [FLINK-16413]Reduce hive source parallelism when limit push down
URL: https://github.com/apache/flink/pull/11398#issuecomment-598579739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6272",
"triggerID" : "4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec",
"triggerType" : "PUSH"
}, {
"hash" : "4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153129571",
"triggerID" : "4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec",
"triggerType" : "PUSH"
}, {
"hash" : "726c57d3f58bcf3adba172273a8b207e5f0281fb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "726c57d3f58bcf3adba172273a8b207e5f0281fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/153129571) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6272)
* 726c57d3f58bcf3adba172273a8b207e5f0281fb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11398: [FLINK-16413]Reduce
hive source parallelism when limit push down
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11398: [FLINK-16413]Reduce hive source parallelism when limit push down
URL: https://github.com/apache/flink/pull/11398#issuecomment-598579739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11398:
[FLINK-16413]Reduce hive source parallelism when limit push down
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11398: [FLINK-16413]Reduce hive source parallelism when limit push down
URL: https://github.com/apache/flink/pull/11398#issuecomment-598579739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6272",
"triggerID" : "4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec",
"triggerType" : "PUSH"
}, {
"hash" : "4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153129571",
"triggerID" : "4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/153129571) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6272)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11398:
[FLINK-16413]Reduce hive source parallelism when limit push down
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11398: [FLINK-16413]Reduce hive source parallelism when limit push down
URL: https://github.com/apache/flink/pull/11398#issuecomment-598579739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6272",
"triggerID" : "4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec",
"triggerType" : "PUSH"
}, {
"hash" : "4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153129571",
"triggerID" : "4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec",
"triggerType" : "PUSH"
}, {
"hash" : "726c57d3f58bcf3adba172273a8b207e5f0281fb",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153201637",
"triggerID" : "726c57d3f58bcf3adba172273a8b207e5f0281fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 726c57d3f58bcf3adba172273a8b207e5f0281fb Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/153201637)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11398:
[FLINK-16413]Reduce hive source parallelism when limit push down
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11398: [FLINK-16413]Reduce hive source parallelism when limit push down
URL: https://github.com/apache/flink/pull/11398#issuecomment-598579739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6272",
"triggerID" : "4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec",
"triggerType" : "PUSH"
}, {
"hash" : "4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153129571",
"triggerID" : "4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/153129571) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6272)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11398: [FLINK-16413]Reduce
hive source parallelism when limit push down
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11398: [FLINK-16413]Reduce hive source parallelism when limit push down
URL: https://github.com/apache/flink/pull/11398#issuecomment-598575006
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4fe5672c65d62cb5e1854db4bf3404d1f4a5fdec (Fri Mar 13 06:41:18 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-16413).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services