You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/23 20:08:57 UTC

[GitHub] [flink] zentol opened a new pull request #16264: [FLINK-23130][rest] Remove netty 3 reference

zentol opened a new pull request #16264:
URL: https://github.com/apache/flink/pull/16264


   Replaces a netty 3 reference without flink-shaded-netty version. This currently works on master because it uses the netty version provided by akka.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16264: [FLINK-23130][rest] Remove netty 3 reference

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16264:
URL: https://github.com/apache/flink/pull/16264#issuecomment-867136927


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ce72bf1566b00188cdb97ef05a31414d9f3d550b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19420",
       "triggerID" : "ce72bf1566b00188cdb97ef05a31414d9f3d550b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac1898dc31128dfe3fcafd72acf6fbfb8d87d3d9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19474",
       "triggerID" : "ac1898dc31128dfe3fcafd72acf6fbfb8d87d3d9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ce72bf1566b00188cdb97ef05a31414d9f3d550b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19420) 
   * ac1898dc31128dfe3fcafd72acf6fbfb8d87d3d9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19474) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16264: [FLINK-23130][rest] Remove netty 3 reference

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16264:
URL: https://github.com/apache/flink/pull/16264#issuecomment-867136927


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ce72bf1566b00188cdb97ef05a31414d9f3d550b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ce72bf1566b00188cdb97ef05a31414d9f3d550b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ce72bf1566b00188cdb97ef05a31414d9f3d550b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16264: [FLINK-23130][rest] Remove netty 3 reference

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16264:
URL: https://github.com/apache/flink/pull/16264#issuecomment-867136927


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ce72bf1566b00188cdb97ef05a31414d9f3d550b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19420",
       "triggerID" : "ce72bf1566b00188cdb97ef05a31414d9f3d550b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ce72bf1566b00188cdb97ef05a31414d9f3d550b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19420) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16264: [FLINK-23130][rest] Remove netty 3 reference

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16264:
URL: https://github.com/apache/flink/pull/16264#issuecomment-867136927


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ce72bf1566b00188cdb97ef05a31414d9f3d550b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19420",
       "triggerID" : "ce72bf1566b00188cdb97ef05a31414d9f3d550b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ce72bf1566b00188cdb97ef05a31414d9f3d550b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19420) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #16264: [FLINK-23130][rest] Remove netty 3 reference

Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #16264:
URL: https://github.com/apache/flink/pull/16264#issuecomment-867430647


   It was never true. I don't know how to force a ChannelException at this place, and it could even be that it doesn't happen at all with netty4. Maybe we should just remove that instanceof check; after all it was ineffective so far so it doesn't seem necessary.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger commented on pull request #16264: [FLINK-23130][rest] Remove netty 3 reference

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #16264:
URL: https://github.com/apache/flink/pull/16264#issuecomment-867425730


   Is there a test covering this case?
   
   I don't fully understand this change: Since no dependency or any other code has been changed, why can we just change the type of the exception? Either `e instanceof org.jboss.netty.channel.ChannelException` was never true, or after this change it will never be true?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16264: [FLINK-23130][rest] Remove netty 3 reference

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16264:
URL: https://github.com/apache/flink/pull/16264#issuecomment-867125948


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit ce72bf1566b00188cdb97ef05a31414d9f3d550b (Wed Jun 23 20:11:54 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16264: [FLINK-23130][rest] Remove netty 3 reference

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16264:
URL: https://github.com/apache/flink/pull/16264#issuecomment-867136927


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ce72bf1566b00188cdb97ef05a31414d9f3d550b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19420",
       "triggerID" : "ce72bf1566b00188cdb97ef05a31414d9f3d550b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac1898dc31128dfe3fcafd72acf6fbfb8d87d3d9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac1898dc31128dfe3fcafd72acf6fbfb8d87d3d9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ce72bf1566b00188cdb97ef05a31414d9f3d550b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19420) 
   * ac1898dc31128dfe3fcafd72acf6fbfb8d87d3d9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #16264: [FLINK-23130][rest] Remove netty 3 reference

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #16264:
URL: https://github.com/apache/flink/pull/16264


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org