[GitHub] ddragosd commented on a change in pull request #59: calling openwhisk from action fails because api host is set to "localhost" #58

[gi...@git.apache.org]

ddragosd commented on a change in pull request #59: calling openwhisk from action fails because api host is set to "localhost" #58
URL: https://github.com/apache/incubator-openwhisk-devtools/pull/59#discussion_r142553104
 
 

 ##########
 File path: docker-compose/Makefile
 ##########
 @@ -1,4 +1,4 @@
-DOCKER_HOST_IP ?= $(shell echo ${DOCKER_HOST} | grep -o "[0-9]\{1,3\}\.[0-9]\{1,3\}\.[0-9]\{1,3\}\.[0-9]\{1,3\}" || echo localhost)
+DOCKER_HOST_IP ?= $(shell echo ${DOCKER_HOST} | grep -o "[0-9]\{1,3\}\.[0-9]\{1,3\}\.[0-9]\{1,3\}\.[0-9]\{1,3\}" || hostname)
 
 Review comment:
   ?  `hostname` is better than localhost.
   
   In some cases it won't be resolved from within the container. Should we document that the developer needs to ensure the hostname is resolvable ?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services