[jira] Commented: (THRIFT-762) Cocoa library won't compile on Mac OS X

["Bryan Duxbury (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859619#action_12859619 ] 

Bryan Duxbury commented on THRIFT-762:
--------------------------------------

I applied this patch and it looks ok... but can you tell me how to actually verify it works? I've never built the cocoa library.

> Cocoa library won't compile on Mac OS X
> ---------------------------------------
>
>                 Key: THRIFT-762
>                 URL: https://issues.apache.org/jira/browse/THRIFT-762
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Cocoa)
>    Affects Versions: 0.2, 0.3
>         Environment: Mac OS X Snow Leopard 10.6, Mac OS X Leopard 10.5
>            Reporter: Jeremy Fergason
>         Attachments: build_on_osx.patch
>
>
> The cocoa library will not compile for Objective-C Cocoa applications on Mac OS X because it tries to include <CFNetwork/CFSocketStream.h> in transport/TSocketClient.m.  This should be a pound-define that includes <CoreServices/CoreServices.h> if being compiled on Mac OS X or <CFNetwork/CFNetwork.h> if being compiled for iPhone OS.
> Also, the Mac OS X build will give a warning because the NSStreamDelegate protocol is not implemented in transport/TNSStreamTransport.{h,m}
> I have attached a patch to fix both issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.