You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4net-dev@logging.apache.org by Dominik Psenner <dp...@gmail.com> on 2013/01/22 14:41:06 UTC
[PATCH 2 of 5] Step 2: bugfix
In RollOverIfDateBoundaryCrossing preserveLogFileExtension wasn't respected.
diff -r dc18d71a5304 -r 76c5f9136b8f src/Appender/RollingFileAppender.cs
--- a/src/Appender/RollingFileAppender.cs Tue Jan 22 14:31:05 2013 +0100
+++ b/src/Appender/RollingFileAppender.cs Tue Jan 22 14:31:24 2013 +0100
@@ -814,7 +814,7 @@
if (!(last.ToString(m_datePattern,System.Globalization.DateTimeFormatInfo.InvariantInfo).Equals(m_now.ToString(m_datePattern, System.Globalization.DateTimeFormatInfo.InvariantInfo))))
{
- m_scheduledFilename = m_baseFileName + last.ToString(m_datePattern, System.Globalization.DateTimeFormatInfo.InvariantInfo);
+ m_scheduledFilename = CombinePath(m_baseFileName, last.ToString(m_datePattern, System.Globalization.DateTimeFormatInfo.InvariantInfo));
LogLog.Debug(declaringType, "Initial roll over to ["+m_scheduledFilename+"]");
RollOverTime(false);
LogLog.Debug(declaringType, "curSizeRollBackups after rollOver at ["+m_curSizeRollBackups+"]");
Re: [PATCH 2 of 5] Step 2: bugfix
Posted by Dominik Psenner <dp...@gmail.com>.
What are the effects of this bug? It is not yet reported as an issue, is it?
On 01/22/2013 02:41 PM, Dominik Psenner wrote:
> In RollOverIfDateBoundaryCrossing preserveLogFileExtension wasn't respected.
>
> diff -r dc18d71a5304 -r 76c5f9136b8f src/Appender/RollingFileAppender.cs
> --- a/src/Appender/RollingFileAppender.cs Tue Jan 22 14:31:05 2013 +0100
> +++ b/src/Appender/RollingFileAppender.cs Tue Jan 22 14:31:24 2013 +0100
> @@ -814,7 +814,7 @@
>
> if (!(last.ToString(m_datePattern,System.Globalization.DateTimeFormatInfo.InvariantInfo).Equals(m_now.ToString(m_datePattern, System.Globalization.DateTimeFormatInfo.InvariantInfo))))
> {
> - m_scheduledFilename = m_baseFileName + last.ToString(m_datePattern, System.Globalization.DateTimeFormatInfo.InvariantInfo);
> + m_scheduledFilename = CombinePath(m_baseFileName, last.ToString(m_datePattern, System.Globalization.DateTimeFormatInfo.InvariantInfo));
> LogLog.Debug(declaringType, "Initial roll over to ["+m_scheduledFilename+"]");
> RollOverTime(false);
> LogLog.Debug(declaringType, "curSizeRollBackups after rollOver at ["+m_curSizeRollBackups+"]");