You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/07/07 04:13:21 UTC
[GitHub] [hive] ayushtkn opened a new pull request #2452: HIVE-22626. Fix TestStatsReplicationScenariosACIDNoAutogather.
ayushtkn opened a new pull request #2452:
URL: https://github.com/apache/hive/pull/2452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ayushtkn commented on pull request #2452: HIVE-22626. Fix TestStatsReplicationScenariosACIDNoAutogather.
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on pull request #2452:
URL: https://github.com/apache/hive/pull/2452#issuecomment-879573879
Enables 3 tests:
**TestStatsReplicationScenariosMMNoAutogather:**
http://ci.hive.apache.org/job/hive-flaky-check/308/testReport/org.apache.hadoop.hive.ql.parse/
**TestStatsReplicationScenariosACIDNoAutogather:**
http://ci.hive.apache.org/job/hive-flaky-check/304/testReport/org.apache.hadoop.hive.ql.parse/
**TestStatsReplicationScenariosACID:**
http://ci.hive.apache.org/job/hive-flaky-check/305/testReport/org.apache.hadoop.hive.ql.parse/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ArkoSharma commented on a change in pull request #2452: HIVE-22626. Fix TestStatsReplicationScenariosACIDNoAutogather.
Posted by GitBox <gi...@apache.org>.
ArkoSharma commented on a change in pull request #2452:
URL: https://github.com/apache/hive/pull/2452#discussion_r668447977
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestReplChangeManager.java
##########
@@ -95,7 +95,7 @@ private static void internalSetUpProvidePerm() throws Exception {
String noPermBaseDir = Files.createTempDirectory("noPerm").toFile().getAbsolutePath();
configuration.set(MiniDFSCluster.HDFS_MINIDFS_BASEDIR, noPermBaseDir);
configuration.set("dfs.client.use.datanode.hostname", "true");
- permDdfs = new MiniDFSCluster.Builder(configuration).numDataNodes(1).format(true).build();
+ permDdfs = new MiniDFSCluster.Builder(configuration).numDataNodes(2).format(true).build();
Review comment:
Also requires same in 'internalSetUp' function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ArkoSharma commented on a change in pull request #2452: HIVE-22626. Fix TestStatsReplicationScenariosACIDNoAutogather.
Posted by GitBox <gi...@apache.org>.
ArkoSharma commented on a change in pull request #2452:
URL: https://github.com/apache/hive/pull/2452#discussion_r668649790
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/ReplLogger.java
##########
@@ -1,4 +1,4 @@
-/*
+/**
Review comment:
typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aasha merged pull request #2452: HIVE-22626. Fix Replication related tests.
Posted by GitBox <gi...@apache.org>.
aasha merged pull request #2452:
URL: https://github.com/apache/hive/pull/2452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ArkoSharma commented on a change in pull request #2452: HIVE-22626. Fix TestStatsReplicationScenariosACIDNoAutogather.
Posted by GitBox <gi...@apache.org>.
ArkoSharma commented on a change in pull request #2452:
URL: https://github.com/apache/hive/pull/2452#discussion_r668447557
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/BaseReplicationAcrossInstances.java
##########
@@ -59,7 +59,7 @@ static void internalBeforeClassSetup(Map<String, String> overrides, Class clazz)
conf.set("hive.repl.cmrootdir", "/tmp/");
conf.set("dfs.namenode.acls.enabled", "true");
MiniDFSCluster miniDFSCluster =
- new MiniDFSCluster.Builder(conf).numDataNodes(1).format(true).build();
+ new MiniDFSCluster.Builder(conf).numDataNodes(2).format(true).build();
Review comment:
Needs to be done in 'internalBeforeClassSetupExclusiveReplica' function too in 2 places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aasha merged pull request #2452: HIVE-22626. Fix Replication related tests.
Posted by GitBox <gi...@apache.org>.
aasha merged pull request #2452:
URL: https://github.com/apache/hive/pull/2452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ArkoSharma commented on a change in pull request #2452: HIVE-22626. Fix TestStatsReplicationScenariosACIDNoAutogather.
Posted by GitBox <gi...@apache.org>.
ArkoSharma commented on a change in pull request #2452:
URL: https://github.com/apache/hive/pull/2452#discussion_r668447557
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/BaseReplicationAcrossInstances.java
##########
@@ -59,7 +59,7 @@ static void internalBeforeClassSetup(Map<String, String> overrides, Class clazz)
conf.set("hive.repl.cmrootdir", "/tmp/");
conf.set("dfs.namenode.acls.enabled", "true");
MiniDFSCluster miniDFSCluster =
- new MiniDFSCluster.Builder(conf).numDataNodes(1).format(true).build();
+ new MiniDFSCluster.Builder(conf).numDataNodes(2).format(true).build();
Review comment:
Needs to be done in 'internalBeforeClassSetupExclusiveReplica' function too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aasha merged pull request #2452: HIVE-22626. Fix Replication related tests.
Posted by GitBox <gi...@apache.org>.
aasha merged pull request #2452:
URL: https://github.com/apache/hive/pull/2452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org