[GitHub] [airflow] potiuk commented on issue #28159: Error when inherit from QuboleOperator

[GitBox <gi...@apache.org>]

potiuk commented on issue #28159:
URL: https://github.com/apache/airflow/issues/28159#issuecomment-1339633262

   I don't think we should remove it. Looks like QuboleOpertor is precisely created in the way that template fields are SUPPOSED to be added when you derive from it.
   
   This is what I understand from the comment in #1090 (and maybe @msumit still rememeber something that happened 6 years aago (!) and can confirm:
   
   > I do agree with your concerns. Actually we didn't wanted to add dozens of new operators like QuboleHiveOperator, QuboleHadoopOperator etc, so we'd to do hacks like that. If we had individual command operators like I said above, then we could adhere to simple design like the other operators have.
   
   I believe the initial idea was that The template_fields will be overridden by a "child" class (@yoavfeld what you should try, is you should likely define template_fields in your derived operator:
   
   ```
   class MyQuboleOperator(QuboleOperator):
   
       template_fields = ()
   
       def init(self):
           super().init()
   
   ````
   
   I tihnk this should help you @yoavfeld  and we should close the issue. Can you please confirm @yoavfeld that it solves your problem?
   
   Converting into a discussion - unless we decide that this is an issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org